From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB06C001DF for ; Thu, 19 Oct 2023 22:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346679AbjJSWu2 (ORCPT ); Thu, 19 Oct 2023 18:50:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235553AbjJSWu0 (ORCPT ); Thu, 19 Oct 2023 18:50:26 -0400 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9E9A124 for ; Thu, 19 Oct 2023 15:50:23 -0700 (PDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4083dbc43cfso1404925e9.3 for ; Thu, 19 Oct 2023 15:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent.com; s=google; t=1697755822; x=1698360622; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Jdr6puVGLRO0RmMF34iaJR4HMguVgSrk1Dz2ZWASTGA=; b=XIjimzjDpnxFkaDMIpwNwEr9TBnrQhlvBeA+DYXh+sBfpMU/2COWtKKe9YdlUxZk/9 PLW5hOPhZV1t5YEKNtMBte5E5dbisvOadWLh9wFQwxfAjxlJGl2WgZsFFeF3Mbce9vzI 9tMUvqCaLhJnC2cHpKghiEuERuN+vn9ALOEZ8kEK0cNwYz5/ofQ6+Cq6xKtjvk41EoUL czXECoBPGw6/eSj9UFV+b5wXUy5kPlw3cMeuTFoJwZQJA4QRADN2tDnPT0o3ExjIwGHY XKXWffiyMaCzMaStzYITB6ZOR5G0rGFdmLTLuRpcCLNJM3A6JAB5FMrJ5++BH3m8ad4w 4qzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697755822; x=1698360622; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Jdr6puVGLRO0RmMF34iaJR4HMguVgSrk1Dz2ZWASTGA=; b=xE7EZuXDCV7L9bWjWxlpRI5rFJkr2DQvJJF7BK7yqmSZB83o3XihVimyPloMzj77Uo 17vYlMVsd7MdBQBP3YL1g/yUHSPU+VvNrouM9Vl8uXHEERKQwEZ7qvQwXj3FgSo74BDk Ztl9qyylb0rvT5SEEqnVFQsuAkJy79YkcvUzfs6n3CfkQocYSvPYf559y1OfrTnqsAKZ tacT9xQ35RxdnYIhE2e0hD3whwoKPXXwVg6i4NAOn1Zq56YPK1OfZ4FirKCNEDZ2uaTV i6yqLov4V+xlTk575F5WgVCerum+2bUX0HvhA4dUFkB/yM0zQBmXV/7jwn7217OaviVF Wkng== X-Gm-Message-State: AOJu0YzwqBe31Uw8i254rQUjX4DDb2r2VYlykii/TdyrbpnzTHiC2Lra cpfcs5X5nUIopCQphZ06ij5qbDCyB2bJju1xHWIOWeMO X-Google-Smtp-Source: AGHT+IFlk3PHTvUyJ39TE4N+dMbY5ycoWERcj/slQTNy/uDLm1uVMvps5E2gM8CZ+Ywfb6zET7o6gw== X-Received: by 2002:a05:600c:154e:b0:401:73b2:f043 with SMTP id f14-20020a05600c154e00b0040173b2f043mr175919wmg.1.1697755822117; Thu, 19 Oct 2023 15:50:22 -0700 (PDT) Received: from ?IPV6:2a02:8011:e80c:0:a8cd:a90a:ba21:5ae1? ([2a02:8011:e80c:0:a8cd:a90a:ba21:5ae1]) by smtp.gmail.com with ESMTPSA id n12-20020adfe78c000000b00326f0ca3566sm341243wrm.50.2023.10.19.15.50.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 15:50:21 -0700 (PDT) Message-ID: Date: Thu, 19 Oct 2023 23:50:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] tools build: Fix llvm feature detection, still used by bpftool Content-Language: en-GB To: Andrii Nakryiko , Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Manu Bretelle , Adrian Hunter , Alexander Shishkin , Andi Kleen , Andrii Nakryiko , Anshuman Khandual , Carsten Haitzler , Eduard Zingerman , Fangrui Song , He Kuang , Ian Rogers , Ingo Molnar , James Clark , Jiri Olsa , Kan Liang , Leo Yan , llvm@lists.linux.dev, Madhavan Srinivasan , Mark Rutland , Namhyung Kim , Nathan Chancellor , "Naveen N. Rao" , Nick Desaulniers , Peter Zijlstra , Ravi Bangoria , Rob Herring , Tiezhu Yang , Tom Rix , Wang Nan , Wang ShaoBo , Yang Jihong , Yonghong Song , YueHaibing , linux-perf-users@vger.kernel.org, bpf@vger.kernel.org References: From: Quentin Monnet In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/10/2023 23:47, Andrii Nakryiko wrote: > On Thu, Oct 19, 2023 at 2:17 PM Arnaldo Carvalho de Melo > wrote: >> >> When removing the BPF event for perf a feature test that checks if the >> llvm devel files are availabe was removed but that is also used by >> bpftool. >> >> bpftool uses it to decide what kind of disassembly it will use: llvm or >> binutils based. >> >> Removing the tools/build/feature/test-llvm.cpp file made bpftool to >> always fallback to binutils disassembly, even with the llvm devel files >> installed, fix it by restoring just that small test-llvm.cpp test file. >> >> Fixes: 56b11a2126bf2f42 ("perf bpf: Remove support for embedding clang for compiling BPF events (-e foo.c)") > > Should we route this through the bpf-next tree to get the fix for > bpftool into Github mirror ASAP? It shouldn't be necessary. The GitHub mirror for bpftool uses its own feature detection mechanism, and is not affected here. This patch won't even make it to the mirror. Quentin