From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013058.outbound.protection.outlook.com [40.93.196.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 97AC325DB1A for ; Mon, 1 Jun 2026 05:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.58 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780293041; cv=fail; b=bigeMVZiyNqVCH0RyvlxGJG5IhIMmkfswua5bPlJIrE8GaP04h67cMgN+R/u6Jwk88HpMX8QsRDJNTazVFHrHvyVSJeQ1LLX8tvy6mrhTY9aLkpRi4L6MmOEGYTXAYCH3L++7uIAompQKZmh6Afk/9gNuVjf4wy1zj77/PkGyiQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780293041; c=relaxed/simple; bh=kWSIBfVgM58BqssIVJrqtmixZdzQ+xW1aXIZJnpHi/g=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=n3WocyCgZ2DDaJuIO50Cj4qxpagqL+ZlQd3leDkwCUM7BXUHk/HYhY491zJwszr/8hDeNBM2dBgvSlBE9UwDYVVIl9UzrCWrrO979vVFtTzN7qcyiXTVFfdL3zsSzqKt3lIGTcKSVpidVmEISGhxy1YA+LgNilePYsJb5iyeiK8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=kapt5b25; arc=fail smtp.client-ip=40.93.196.58 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="kapt5b25" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jVoE9VH+io5TRj45RB79kTx4D38j3KmNnTMotEDQARqeKk/kzs9xPHuuy6D3iG2mHkWQZjecx3mObBlWbuaP56GBENEQRsutAu10tJ+2Nwa4VK943T7RYC99RTzPnP8Vo7V8YwvJ+A5MZ6iu/N5JzFkQjHsu3opVpRjKe3z9PerDTY7bT7rG7fH7alg29wGyfZYyKm4IBmUHgLn5CJQyhRd3kihJ52ElwU5WH8o2FLtNTOK6EBPYxtYNTTOxy9+VAdAWb03P9eMyNDPkIOfVUdLUK7D3YIXKBe177aEGC4X4uvOvh8sYawIncaqSbz4t4xsEQ0ObF9GSDlBUOSXfjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7csJkkkQUpivjkNjPgEpEN7IlVRfKNIiN6si+Xbyl4=; b=zVwONWpSIxwXq6z9zo9RxuavyiiR9y1gUa+yrydiiHX0OseoG3YUdhaZhCZFu/0YgjZHnDLyO+PVJ+lTU7pf4jpW7CCnHOja93ldP0/VjjO90Z90k1b52B+9Od7TQpiYfA9mksYNW1z9XllIN6qVWwqqLOOVv2mP60bmQTwbRqC26oqa786XI2aJlb9lJoLxvvRCMO2hNyWfvi+/oOeLhDk1E2GC3fd6Sx+OeBE9eAATlplRVSCfb+lYEkSfbJm2MkT4byQJoJxbVZse6pNKz+9Few12XJtnBS3i3fj0XvtT06B0AahnYUQlqDsaNxUOtkwJjvmsuevt6KNPX84QlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=bytedance.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t7csJkkkQUpivjkNjPgEpEN7IlVRfKNIiN6si+Xbyl4=; b=kapt5b25Lr6N1yrIrASLvvTiloFMJ00wyA2THEO9/v40NcbUCFgQAop/sgYuvPlW1ykzqoXiZUAF6o+gOjrs2i0wAzwUYLegYaDFjgdt0qFKS94wBIfaBF46YrqJlIcxcX7D2YRhC+wuThzcSSKq0HvxGsThX3EbT6YbwBCPpTg= Received: from CH0PR03CA0447.namprd03.prod.outlook.com (2603:10b6:610:10e::24) by IA0PPFFEC453979.namprd12.prod.outlook.com (2603:10b6:20f:fc04::beb) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.13; Mon, 1 Jun 2026 05:50:36 +0000 Received: from DS3PEPF000099DD.namprd04.prod.outlook.com (2603:10b6:610:10e:cafe::a6) by CH0PR03CA0447.outlook.office365.com (2603:10b6:610:10e::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.71.16 via Frontend Transport; Mon, 1 Jun 2026 05:50:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by DS3PEPF000099DD.mail.protection.outlook.com (10.167.17.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.5 via Frontend Transport; Mon, 1 Jun 2026 05:50:36 +0000 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 1 Jun 2026 00:50:35 -0500 Received: from [172.31.184.125] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 1 Jun 2026 00:50:31 -0500 Message-ID: Date: Mon, 1 Jun 2026 11:20:30 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] sched/fair: Call update_curr() before unthrottling the hierarchy To: Aaron Lu CC: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Josh Don , References: <20260528094830.13291-1-kprateek.nayak@amd.com> <20260528094830.13291-4-kprateek.nayak@amd.com> <20260601035201.GA690044@bytedance.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260601035201.GA690044@bytedance.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099DD:EE_|IA0PPFFEC453979:EE_ X-MS-Office365-Filtering-Correlation-Id: 50a7518d-2f63-4ee9-c820-08debfa1b3e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|1800799024|36860700016|82310400026|22082099003|18002099003|56012099006|11063799006|4143699003; X-Microsoft-Antispam-Message-Info: Cd7tF8wg6pikWE0L8Yre/qKGv6pSz2/+rrhXN4rWBLyiTuXYTUzd/C2hvoYGsQRICdF5JdXxcIqtP+erzD9qtKCdbE1KuywZzHfyz5GpwEht3eK36Q3z55e/wY/070N/UduYP1zXBEeIptv58CqEtY2L6ERIqrHv5liMLaak7VZ5ZY+6tENmUQ96+IDphMHQvDqCmMik8nOSfOJFaN1CasLsARW/TfaA9SllNPGt3xdTwF4/05f+wOf4ssFGieyiLGCs+wX60BFS6nwRNXZ5NAFHCMFk9rSV+bC9sFQpjycGMN8VLKY5cg9O3ppQV2KFoox7+w79J/+/5iTM+Y5jfsw13NyaHD5pOMnD0h2NbI1EKpzJ3YHeU49i2jm9iGTc8KcWcODOblWAyUXN/dYPDFKlwk57trzB8GLsvye82l9n8jK1Pvc1HdjeVlM2OWbHKZ5nJUWdLfDncVrYVOBdwXh09PJekb0qMUiBZhnhaUYXMFxCaK/BHIGnQQ5RLaFlxtJuFa6AlOanKfe28YuvFM9891XLB4xEjMUfA3QJskznMaqt9L0inuOxgYCVVH4Y/RVUGePq9xzr3q5IbHHkaShTBglj2OqNvQIaeYz4p98yMghkFMzeonuZJ32pl1aWCuNF4qdLf+QARz1BxHEdvgsmh1QAyT3d8sPIjIPFKl6nSCTXdnfhjuxPB6dxpXcLcQWOE/pqUIPa8Wb6XsOENIBsf4m8SY142V+gJZlR8/c= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(36860700016)(82310400026)(22082099003)(18002099003)(56012099006)(11063799006)(4143699003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AO8ETYqwnaxsNotpdB0sI8kXF8QabYDKh/sODsJzWmvj6ei3sfpc2yZyYCXgLiidC2KKWVekW/85rljglJV/8Tvpk3XawNVSPRFk8PcO5nE5bygGkjIQi/ttbKB/vrr1jxj1mgknQoM/a2zltwkwoug/nkDFOZs8t2/K6uIyU4Ts9/6D1fZgj61vBp9U5CZ57lkMXTtUm29OA/HG0m5aacA6YWB/5BM9xKPFKGJqvXoJo7C/lyVfxNMxWonh9pUcgpN3s+fAMvDF2WJ6XWiuQ/ylWFWZX+82WmFwaYNTWGJxoGrasBXu77wGJpJUuTqJ4MvRBoPmFzOSunEvv3EE+qt55Af5wANNni4kohO+4S0imRxGMq/d2btfjrvF5G9cm2CU0//Mb24egBv804BE+20Nz5xhbGKcTVbJbHLhvuo8eFzlyKE5bG5nptjTFXV2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2026 05:50:36.1416 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50a7518d-2f63-4ee9-c820-08debfa1b3e8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099DD.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PPFFEC453979 Hello Aaron, On 6/1/2026 9:22 AM, Aaron Lu wrote: >> Since all callers of unthrottle_cfs_rq(), except one, already update the >> rq_clock and call rq_clock_start_loop_update(), move the >> update_rq_clock() in unthrottle_cfs_rq() to the lonely caller that >> doesn't update the rq_clock. > > Looks like there is one more path that doesn't have clock updated: > cpu_max_write() -> tg_set_bandwidth() -> tg_set_cfs_bandwidth() -> > unthrottle_cfs_rq(). Woops! Completely missed that. Thank you for pointing it out. I'll add an update_rq_clock() there too once we grab the rq_lock. -- Thanks and Regards, Prateek