From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933440AbcLMOdx (ORCPT ); Tue, 13 Dec 2016 09:33:53 -0500 Received: from resqmta-po-10v.sys.comcast.net ([96.114.154.169]:53598 "EHLO resqmta-po-10v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933396AbcLMOdu (ORCPT ); Tue, 13 Dec 2016 09:33:50 -0500 Reply-To: shuah@kernel.org Subject: Re: [PATCH] selftest: sync: improve assert() failure message References: <1481636929-25738-1-git-send-email-gustavo@padovan.org> To: Gustavo Padovan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, emilio.lopez@collabora.co.uk, Gustavo Padovan , Shuah Khan , Shuah Khan From: Shuah Khan Message-ID: Date: Tue, 13 Dec 2016 07:33:47 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1481636929-25738-1-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfPntEJh6LInKzR7YRUgcI/nLjhjCgMVd7D6QxD3kApnQutDebOnG0nq7O1z7FpWkfzcWs5A3m8eUI6xSOOzmsuvtXFDt4kpiln+d1SYN3A7BZdYElqJ2 fGrJG8rwOQx687hDN4XWaWgAE8l6F6HQbz5hXze1CUTRlvPSCpasaK77tl2JqaNvsyf0yQ2TBGIh6qe7zZek5IR/2vB8YGz4Ww6oW1HfLbLLoaiO5rEJY+n/ qDtnLHeW74Kl5wN074f4QXQCVTxWbc45npPnj+udZM/4XQWuFeK3e9tlLIVsXflzPvdLr7S7j4NWqOvYY5IFyqqnyxcFdQBCKFBmayydznD+lwNn85UXnos0 hn8jExBQ5lbgVxjoCosnhXGTNdki1NmLAuxJMeZ03EerXOuz+ZJ3SYDWS7AWnOtFoCMNmvTG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13/2016 06:48 AM, Gustavo Padovan wrote: > From: Gustavo Padovan > > Print "ERROR" on all messages instead of using the not well defined terms > like "BAD". > > Signed-off-by: Gustavo Padovan > --- > tools/testing/selftests/sync/synctest.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/sync/synctest.h b/tools/testing/selftests/sync/synctest.h > index 4e0e59f..e7d1d57 100644 > --- a/tools/testing/selftests/sync/synctest.h > +++ b/tools/testing/selftests/sync/synctest.h > @@ -32,7 +32,7 @@ > > #define ASSERT(cond, msg) do { \ > if (!(cond)) { \ > - printf("[BAD]\t%s", (msg)); \ > + printf("[ERROR]\t%s", (msg)); \ > return 1; \ > } \ > } while (0) > Thanks, Applied to linux-kselftest next for 4.10-rc1 -- Shuah