From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45DF53B27DB for ; Mon, 27 Jul 2026 15:42:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785166974; cv=none; b=cD7YZch9Qg6KWnS8rb8xMR7HgT7/TmHy8KGEDCWjV8PzeRsLWpv7gKLwo36fpvTr/Ukf9st3FuWlgdEi2PCJsTE5NcF08whnAHzGQRwJnQ4YTjzy+d+4vElyRuQTXFGLkPS1U1C0PQKU5F3Z21fhcjxblIbv197pZBCdpQA3faQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785166974; c=relaxed/simple; bh=bA66g9xOsMUn1roReIQv0HLGEaRNZLUQ2Kc9czuM1zc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VBpi5LM67AMCZ1M0E36GXmxtmTcCCoT5iRzmo3Gryu2MyEVlOKy8tslXVtZx+1H65rK4sNdMFSsmERN5tlXjQDSopLy3IS6VlpOWPfwW6uKxpAKpLl134tJxce2cjnDlzk1+okmz/nCEgi8iHugmGypPlaXW/GaWRQygVSRte2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Ndong4jf; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Ndong4jf" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66RDnI7x2374802; Mon, 27 Jul 2026 15:42:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=6J3gnQbVG5F32M1ODXud3+fpqy/Uu5 wURU5jevcJFLY=; b=Ndong4jfH4A47D8juXaN6VEO3OTQ+xwAwF2aTjQZG/Zo70 huG5/1z18vRkW9WjsIJ1qpZcaEqr4lOt1J/IyosS2hvwszP9liVRguSgqDrxLhwd x/fPnM4zJqhCWr7zWXDAjHGC6djYB9v+UI0QQL4tvigC1cr7i1AKLaIT8x9eCxEU Bf13cu9uUGfJVnXPArimdGJCBo5CinbGFDu11XNMYdbwz/W/66i67wEkr3Lm/mY7 4H3c/ejlM8oXnXxQKg7JoEP0EfkSQqAjByWxy3kkWSbZR0SnX5bXrWJxSGHgRO7j hZaeHnG6iEHsVuY8WldbrGbzS9tOxaPutDO/+4+Q== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fmuw78tdq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jul 2026 15:42:13 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66RFfiqA027216; Mon, 27 Jul 2026 15:42:12 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4fna5xwp9y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jul 2026 15:42:12 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66RFg8Lt31326578 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jul 2026 15:42:08 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6014B201D8; Mon, 27 Jul 2026 15:42:08 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0BFEA201BD; Mon, 27 Jul 2026 15:42:08 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.224.92.206]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 27 Jul 2026 15:41:50 +0000 (GMT) Date: Mon, 27 Jul 2026 17:41:49 +0200 From: Alexander Gordeev To: Luiz Capitulino Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, david@kernel.org, baolin.wang@linux.alibaba.com, ziy@nvidia.com, lance.yang@linux.dev, corbet@lwn.net, tsbogend@alpha.franken.de, maddy@linux.ibm.com, mpe@ellerman.id.au, gerald.schaefer@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, x86@kernel.org, tglx@kernel.org, mingo@redhat.com, bp@alien8.de, ira.weiny@intel.com, hughd@google.com, dave.hansen@linux.intel.com, djbw@kernel.org, vishal.l.verma@intel.com, dave.jiang@intel.com, akpm@linux-foundation.org, yintirui@huawei.com, ljs@kernel.org, dev.jain@arm.com Subject: Re: [PATCH v6 08/14] s390: move has_transparent_hugepage() out of THP guard Message-ID: References: <3ab69c6a9210d2764f714a093eff731dcb55ed14.1784856856.git.luizcap@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ab69c6a9210d2764f714a093eff731dcb55ed14.1784856856.git.luizcap@redhat.com> X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: Hpo6P-3G9ZSGxN5ZPEqd4roe8e1ndcp2 X-Proofpoint-ORIG-GUID: bSb6a6soED65r4O5K0zWqMWtVj-YvDn7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDE0NCBTYWx0ZWRfXyZ7uk54aX2+6 AoBig7mz3BHW3A6sCIp/1israkN4R2CnuP8v9sn7Baoa++HaprL+NoC4VS6OdKJQ/DOKHlksgmF 7rRy+y7fv4jwHZ2SceT01/knP9Hjhf5mzzHplf5fNqcFi8xLf7QR9ZkoVWVCMugJ+5VXiQlpVby 15yjJQFRp7fDyKVILNeqY1f16VekRsX9xNhJHinlzbRFIKRY3CP3CeqFo4aa5PVs1nXChBInFuI OnnnlHgvfKTksEvJm7eveuXISe6HXKLLw2wcOi8McanvcOU0M2bbFx6PylXJOsMmiTHmb5A2ys9 TyrkkU6ozbgjQWAyO/ypsh1W/mKn4CH2gShGOTpyigM/Wq9UFISNposdSv5F5mvxUqGwcq8dnes YiflO1zu6+nk3lF9/CHtPARcOWgnXOR8hDjb9MjYFCuzTlPEEvgscUkyh/jAEgN5zUi91i8Z9Wg vWqDnmnMsdMrnr1VEyQ== X-Authority-Analysis: v=2.4 cv=SKFykuvH c=1 sm=1 tr=0 ts=6a677c55 cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=20KFwNOVAAAA:8 a=7DZdcF_Zup3vnnvw1dUA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDE0NCBTYWx0ZWRfX12iEE3N1poRZ kwXZD4/RXfWwuS+MJuxL5wclF+l4F/HLs/UqIl5j9fL8BVNYXN3k4QatF4isne/GaNiHgFlE0JA M/1evJgtUMrsiIh6k7fkAXo9PiMc3FU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_04,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 clxscore=1011 adultscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270144 On Thu, Jul 23, 2026 at 09:34:12PM -0400, Luiz Capitulino wrote: > has_transparent_hugepage() definition is guarded by > CONFIG_TRANSPARENT_HUGEPAGE, but there's a need to use it when ^^^^^^^^^^^^^^ What need? The commit message needs to be self-sufficient or at least explain why that it is a pre-requisite. > CONFIG_TRANSPARENT_HUGEPAGE=n. Move the definition out of the THP guard. > > Signed-off-by: Luiz Capitulino > --- > arch/s390/include/asm/pgtable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks!