From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51AF7C4332F for ; Tue, 18 Oct 2022 11:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229896AbiJRLVf convert rfc822-to-8bit (ORCPT ); Tue, 18 Oct 2022 07:21:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbiJRLVd (ORCPT ); Tue, 18 Oct 2022 07:21:33 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B630A5732 for ; Tue, 18 Oct 2022 04:21:31 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-232-MyyZk4qTO_2gQ2IgehS1sQ-1; Tue, 18 Oct 2022 12:21:28 +0100 X-MC-Unique: MyyZk4qTO_2gQ2IgehS1sQ-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 18 Oct 2022 12:21:26 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.042; Tue, 18 Oct 2022 12:21:26 +0100 From: David Laight To: 'Greg KH' , Deepak R Varma CC: "outreachy@lists.linux.dev" , "Larry.Finger@lwfinger.net" , "phil@philpotter.co.uk" , "paskripkin@gmail.com" , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "kumarpraveen@linux.microsoft.com" , "saurabh.truth@gmail.com" Subject: RE: [PATCH 2/4] staging: r8188eu: reformat long computation lines Thread-Topic: [PATCH 2/4] staging: r8188eu: reformat long computation lines Thread-Index: AQHY4jImRI1yBSI2nkicUdp3IjMNEK4UAvtg Date: Tue, 18 Oct 2022 11:21:26 +0000 Message-ID: References: <2dd27eff9aab5ffe31e61086c0584982794507cf.1666011479.git.drv@mailo.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg KH > Sent: 17 October 2022 15:10 > > On Mon, Oct 17, 2022 at 06:52:50PM +0530, Deepak R Varma wrote: > > Reformat long running computation instructions to improve code readability. > > Address following checkpatch script complaints: > > CHECK: line length of 171 exceeds 100 columns > > CHECK: line length of 113 exceeds 100 columns > > > > Signed-off-by: Deepak R Varma > > --- > > drivers/staging/r8188eu/core/rtw_br_ext.c | 20 +++++++++++++------- > > 1 file changed, 13 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > > index 79daf8f269d6..427da7e8ba4c 100644 > > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > > @@ -211,8 +211,10 @@ static int __nat25_network_hash(unsigned char *network_addr) > > } else if (network_addr[0] == NAT25_IPX) { > > unsigned long x; > > > > - x = network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ network_addr[4] ^ > network_addr[5] ^ > > - network_addr[6] ^ network_addr[7] ^ network_addr[8] ^ network_addr[9] ^ > network_addr[10]; > > + x = network_addr[1] ^ network_addr[2] ^ network_addr[3] ^ > > Why not go out to [4] here and then you are one line shorter? and/or use a shorter variable name.... David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)