From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E904C62 for ; Tue, 21 Jan 2025 12:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737462676; cv=none; b=EYVAk8G6iDpAnLFa5K/m6BLNNCnj/bZxqxIF22YRqNgggHErFTKwBXQGuxKuppFU7dfwW55IvywwSabZl7uE1Tj9p07CsC6BEQ2I24EjOa1V5+0q4LPdxtNFbSRGWd08/AfYWHIajMr7cKRaQ5GRrHiavY28yn9HDLvnKYpQ+tM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737462676; c=relaxed/simple; bh=eQQSI7aX8teQ/PlHD6j2OduY1n+DoVmDJmwE1vLJeQI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=IGR4E7yDVOpHfUATAAUplCcRN2+Q7kk1kNI7sTfs45EOAkH9a61VBwJVurB9EDumbEqKsaj1TlzUCoYxQU9F0W4+1TsLfqRyFVJcoD6f7lK0u8WZJsqipIJ834GlrbXaaxXzOjwuLNQ7XY3+E/tzkdIYzGCjDYvQQ1/cRwppht0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=h+UCZc+F; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="h+UCZc+F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737462673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TVwRDbUYkhH5Lk2TvvJR8UKk+yuKxoLllxy+r28q7wI=; b=h+UCZc+F7V9krXVrKvpHTqQJnyAgFTEMSR7iLFkvXa1dWa8N5WWD/wn8B03TVeXzb//l0z zzyJqd+gnN8mAtNjEF7rD2lJYiY5Wok+xhqvIP9HjKzVICwWlnWDoGypPILF4oOgPyQjZn vU3nLBMLg7N/hiYYpO7r4FzIEv1GWKs= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-116-vvCSyuy6Pg2vqBoSs-HqXQ-1; Tue, 21 Jan 2025 07:31:10 -0500 X-MC-Unique: vvCSyuy6Pg2vqBoSs-HqXQ-1 X-Mimecast-MFC-AGG-ID: vvCSyuy6Pg2vqBoSs-HqXQ Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 60DE919560A3; Tue, 21 Jan 2025 12:31:08 +0000 (UTC) Received: from [10.45.224.57] (unknown [10.45.224.57]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3529719560A7; Tue, 21 Jan 2025 12:31:05 +0000 (UTC) Date: Tue, 21 Jan 2025 13:31:01 +0100 (CET) From: Mikulas Patocka To: Hou Tao cc: dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Alasdair Kergon , Mike Snitzer , Ignat Korchagin , houtao1@huawei.com Subject: Re: [PATCH 0/6] dm-crypt: misc cleanups and fixes In-Reply-To: <20250120082951.1423804-1-houtao@huaweicloud.com> Message-ID: References: <20250120082951.1423804-1-houtao@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On Mon, 20 Jan 2025, Hou Tao wrote: > From: Hou Tao > > Hi, > > The patchset contains misc cleanups and minor fixes for dm-crypt. These > problem were spotted during the code inspection. The patchset have been > tested by running fio on dm-crypt devices (both with and without > integrity feature). Patch #6 is tested by asynchronizing the > crypt/decrypt algorithm when using random IV. > > Please see individual patches for more details. Comments are always > welcome. > > Hou Tao (6): > dm-crypt: set atomic as false when calling crypt_convert() in kworker > dm-crypt: fully initialize clone->bi_iter in crypt_alloc_buffer() > dm-crypt: use bi_sector in bio when initialize integrity seed > dm-crypt: don't update io->sector after > kcryptd_crypt_write_io_submit() > dm-crypt: don't initialize cc_sector again > dm-crypt: track tag_offset in convert_context > > drivers/md/dm-crypt.c | 42 ++++++++++++++++-------------------------- > 1 file changed, 16 insertions(+), 26 deletions(-) > > -- > 2.29.2 I applied the patches. Thanks. Mikulas