From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D443D9DD1 for ; Mon, 6 Jul 2026 09:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783329090; cv=none; b=cShUrFmc06bHPBjC4v7G390EdJGjtT0FVJqa59fR0M15iiGHOdB/Dt26xS9FrFSEvDawUa+CFCbDPUwmXimiid3TpheTi8yGXbStv5nls5z8lAoj0EZoCECWC+PtI6WVZMLMK31p9Jjxg4B5JOddOdL/ryq2D4C4OWVzp/KxYRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783329090; c=relaxed/simple; bh=INACSRF0fMlMov5Ke5zow+WhwK613mlG+72Er7VCwbI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G3eQVmwadaib6fhOGzzp8B6yOJV9OIl0DeTWFb9qNexey0zvl2fg4bDiba6BHjDh/ww2/Mai1pTwTLG8teGEVauCjs3GbdvuoTvAGqCsUFEL7B9o8tZxPuJLQ2ehbvTd8TmrWvqPPyB01uD4KzsrRyDR3pPo+vdBm7u7gSX+tg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mJvdy0FY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ye5oM7O6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mJvdy0FY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ye5oM7O6" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666949cx056993 for ; Mon, 6 Jul 2026 09:11:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WbhTr9uhP0D20AAKNUPS7YeXV2C/L9L9t4Xe4eF6VBE=; b=mJvdy0FYGEC1xWeo ZMxMm5fDDkulgM6//y4jhJj3sLS/p7Yc6FqUZmpSnewA9/prOmY3SczBtkkXM5wC eWe8I6BmOQn9zNyHQcs1ex0s7nZOJ1SLdvJ77HgPG/retLeWj7c2VXDD6Kupawab A7W4vIE/W7ymcSDZuYLOuDsPA+rgp3K88WpRpa+jqxtoD82Pcegi6B9ylq0/L16Q GiY6ue9vG94e/WatlEgbZvB01oY60TrTMMj2MSYHFRZoqOJpo+6hJd4G0XpdIUJL WikppTlj7PTHh6Gq2ni3yr8HBxe+IcFSBxQI3U671/UcluNwydqQzEX/eXOtz4RN yv2cZQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7gg46-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 09:11:19 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51bfe75b7dbso9189331cf.3 for ; Mon, 06 Jul 2026 02:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783329079; x=1783933879; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WbhTr9uhP0D20AAKNUPS7YeXV2C/L9L9t4Xe4eF6VBE=; b=Ye5oM7O6+ktjLZCD2JZ0nAuF/nVQMrxnfRAvyX+felSrjojUxSiv3cH1nhgr2xMJ7C WR+BduM56g9SA5RMgNl0LF9NyreNLGhgqi587SBKhpNCIePeb2svIQQg2jl8sOSwMvq7 3BFnFSNDZDHum5wT8MQ6ZsmgAyDWYfzfhuPo1vSusaq9xv2NODVueVbIICoWjmWmsZz/ KFNQAYU5jR0jV/NEW1yO79xU6Ns5HZqMbd0LQR/l4YKIpVrgWVf+XFlcbt5lwF0K76AN 5WWFAhBQkOv4HGPT0eB/hBv5K6r4TXLj5T8D/gKspEQShkE5OsPNUEE0aZbFZLgs1/Or Od1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783329079; x=1783933879; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WbhTr9uhP0D20AAKNUPS7YeXV2C/L9L9t4Xe4eF6VBE=; b=GMVU/dS4hovK0EEGUkRkuNsjE1JtSjBapxoLbi9qibnlDOZFl0mWGRNz/uDS1PLeaS L08/Y2/mMqlN8TDqNb3XgmlkVvpU99slnO2oxUlgEVpktZ6jT6pcJx/gfCPYSR1mVPSV ADvKR9qSNzj5B2yqVpw0y94YAnrtXZlAli1nuoZS3LjmuKctEsE+Xqd6hOpGB7RetVzq OZlmzsyfgT3R7NGH0NCakr6NGZRR1pASUGTBRUtDqh3t9qiIoISJRsj/O5T+1J+Vd/Ie M60HMDqJjkBTxbnkZGray5pZvFYwBp4JINdSjBrFXO65Od8QtgM1C/x6GW+VGW137kfN lOjQ== X-Forwarded-Encrypted: i=1; AHgh+RqXzCON/eE7Reym84kuC2KdICMpD6KD1lEShLybVgb97E+7Iup98DvbkwNrmi4MO9jCjNdIjKMdM7be5LM=@vger.kernel.org X-Gm-Message-State: AOJu0YzhhlkLIDc9u2BjVyywYUpec2hVzP3tTkd/dpC+P6n9E5BPHAly gxY9lYAEdOOzSuidzucfD69UFNwqR+Dgk9ALu7Mh3FTYilFTXVOhWi+CPE/fxXHkeMKyCivVaNe cN6BzL5QfuDCNisIU/QinGpe6kxjT9fjkGomL63Ex46DZn3Ygb4vDx1F1/RXT5UKEKcE= X-Gm-Gg: AfdE7cmIWjqgpAy/P86SW24k7F0GknQ8D8oJunyI5kgw8OJDc5L5IVgS4VnQh8sPBJJ +YiSR6uNmfwephzWTu1Gl8Gc3AvSBKeMoQNKnl7JoOPjpaY5lsSZzGhWOuo0mCjgfzMj+0aJzZu fjBS03Cs2qK0z2MisFv+jb3Yb7TIW8+6v5MdvCFZ6J4PIJbM9GE2YKSPH9USNIQ2ALgIjqulHwY r4Pc56p5oyyTCz3aUfW7sQwUsw+jS49SAY9Lv+o9vVdKzGG30KRWF86/5s8U56QTE2cB0WjfAng HyJW+K9qdptROKsPyEbpN9XLvM+V6+ljpRRIVZigHiq1J9naDN5j7hk2ILHHv9k9FI44zLBou5q T4nkcOg/Dy5DnESw2GVfAzgQVTIBP9wqQgVg= X-Received: by 2002:a05:622a:349:b0:51c:d16:b498 with SMTP id d75a77b69052e-51c4bf1e961mr84781211cf.10.1783329078908; Mon, 06 Jul 2026 02:11:18 -0700 (PDT) X-Received: by 2002:a05:622a:349:b0:51c:d16:b498 with SMTP id d75a77b69052e-51c4bf1e961mr84780971cf.10.1783329078449; Mon, 06 Jul 2026 02:11:18 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b628c16fsm722188166b.37.2026.07.06.02.11.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jul 2026 02:11:17 -0700 (PDT) Message-ID: Date: Mon, 6 Jul 2026 11:11:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 5/6] ASoC: cs35l36: Implement set_tdm_slot to program RX slot register To: david@ixit.cz, Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , David Rhodes , Richard Fitzgerald , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , David Rhodes , Conor Dooley Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, phone-devel@vger.kernel.org References: <20260705-pixel3-audio-v1-0-3b66f33859f1@ixit.cz> <20260705-pixel3-audio-v1-5-3b66f33859f1@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260705-pixel3-audio-v1-5-3b66f33859f1@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDA5MiBTYWx0ZWRfX4Qr198AtUpB6 hz2rH9TA/QIxAuP5fBWansAr+kLV/EAW450ac2EW6AXSA5cj2TMsQMXYrYQAyMqnPPMPsbRGTNZ auvIi8JcJz78QXi/f2qSlUDXW6V8b3DNvHhJ01zaFL4yCGNtCQOgl2vwzRq5CwdxMj4D9eag4qa FQGvi4HS8kOIc2WhTz6SfDUC3tniZFevEt8EaWxLJ3meEbW7MZPiMz502VC6n4O6Y3rLZDMpXd/ QnbcV1dalfS7yUVhsXEoSwMSwJvYS0NbIQtwDp+XzcY/XyPOEiP+EiSJCFIVOdGBCHNWULdh3Lu WM/OAPn4H7MmsvOhjX7mQGZDEffvbA4sJDG/mWBcNYe0t+gprqlYcfzBKa/5sCqOrePLEbsHkVm gnNDltHyPj/wbWU7uIvMPEwXIVF9r8w6fxyI6NBDuXitseanqkZ8QNrOwZ4dodX7hYcpseskRgI 5agmE784ZT3Mgl+4W8g== X-Proofpoint-ORIG-GUID: P_2winnPQ0G5oCKOEWsEi4wf2NnmgWeH X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDA5MiBTYWx0ZWRfXwOxcgGNtNiac UYPU6bfpF1v2Oy35EjxGn2pqlYyOTtyHnwAaJgy0K2D+GUVHt4/gVgxGvOqlLg+S1uvdmBu4y28 trQgOQ7vAyGBOeXc0pJwlLFsgqRE4Jk= X-Proofpoint-GUID: P_2winnPQ0G5oCKOEWsEi4wf2NnmgWeH X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4b7137 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=PWbkM1JAYS1s-zoVCkcA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060092 On 7/5/26 10:06 PM, David Heidelberg via B4 Relay wrote: > From: David Heidelberg > > Program ASP_RX1_SLOT with the first set bit of rx_mask so the > amplifier listens on the correct TDM slot when configured by > machine drivers. > > Assisted-by: Claude:claude-4.6-opus > Signed-off-by: David Heidelberg > --- > sound/soc/codecs/cs35l36.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c > index 89645327945f1..944f4cb5763e4 100644 > --- a/sound/soc/codecs/cs35l36.c > +++ b/sound/soc/codecs/cs35l36.c > @@ -942,20 +942,36 @@ static const struct cs35l36_pll_config *cs35l36_get_clk_config( > for (i = 0; i < ARRAY_SIZE(cs35l36_pll_sysclk); i++) { > if (cs35l36_pll_sysclk[i].freq == freq) > return &cs35l36_pll_sysclk[i]; > } > > return NULL; > } > > +static int cs35l36_set_tdm_slot(struct snd_soc_dai *dai, > + unsigned int tx_mask, unsigned int rx_mask, > + int slots, int slot_width) > +{ > + struct cs35l36_private *cs35l36 = > + snd_soc_component_get_drvdata(dai->component); > + > + if (rx_mask) > + regmap_update_bits(cs35l36->regmap, CS35L36_ASP_RX1_SLOT, > + CS35L36_ASP_RX1_SLOT_MASK, > + ffs(rx_mask) - 1); if (!rx_mask) return 0; (or does the field need to be cleared?) return regmap_update_bits Konrad