mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: Daniel Wade <danjwade95@gmail.com>,
	Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>
Cc: "H . Peter Anvin" <hpa@zytor.com>,
	Andrei Vagin <avagin@google.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/fpu: Put non-enabled dynamic features into init state on sigreturn
Date: Wed, 18 Nov 2026 12:19:02 -0800	[thread overview]
Message-ID: <a0c51547-a354-4dbb-9194-0b359ea604cf@intel.com> (raw)
In-Reply-To: <20261117112640.1435-1-danjwade95@gmail.com>

On 11/17/2026 3:26 AM, Daniel Wade wrote:
> On sigreturn restore_fpregs_from_user() restores the features the signal
> frame carries and inits the rest, but both masks are limited to
> fpstate::user_xfeatures. If the task lost the registers earlier in the
> syscall, a dynamic feature it has not enabled yet -- XTILE_DATA before
> its first AMX use -- still holds the previous task state, and

How could that happen?

> fpregs_mark_activate() makes the registers current's. The first AMX
> instruction then raises #NM and fpstate_realloc() clears XFD without
> reloading, 

Reloading what? XFD traps before the instruction accessing the state, so
there should be nothing to reload.

Well, I have a hard time following the problem...

Thanks,
Chang

      reply	other threads:[~2026-11-18 20:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 11:26 Daniel Wade
2026-11-18 20:19 ` Chang S. Bae [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0c51547-a354-4dbb-9194-0b359ea604cf@intel.com \
    --to=chang.seok.bae@intel.com \
    --cc=avagin@google.com \
    --cc=bp@alien8.de \
    --cc=danjwade95@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®