mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Matteo Rizzo <matteorizzo@google.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	io-uring@vger.kernel.org
Cc: jordyzomer@google.com, evn@google.com, poprdi@google.com,
	corbet@lwn.net, axboe@kernel.dk, asml.silence@gmail.com,
	akpm@linux-foundation.org, keescook@chromium.org,
	rostedt@goodmis.org, dave.hansen@linux.intel.com,
	ribalda@chromium.org, chenhuacai@kernel.org, steve@sk2.org,
	gpiccoli@igalia.com, ldufour@linux.ibm.com, bhe@redhat.com,
	oleksandr@natalenko.name
Subject: Re: [PATCH v2 1/1] Add a new sysctl to disable io_uring system-wide
Date: Thu, 29 Jun 2023 08:15:52 -0700	[thread overview]
Message-ID: <a0c8d74a-dcfe-78a7-74bd-4447ed6944dc@acm.org> (raw)
In-Reply-To: <20230629132711.1712536-2-matteorizzo@google.com>

On 6/29/23 06:27, Matteo Rizzo wrote:
> +static int __read_mostly sysctl_io_uring_disabled;

Shouldn't this be a static key instead of an int in order to minimize the
performance impact on the io_uring_setup() system call? See also
Documentation/staging/static-keys.rst.

Thanks,

Bart.

  reply	other threads:[~2023-06-29 15:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-29 13:27 [PATCH v2 0/1] Add a " Matteo Rizzo
2023-06-29 13:27 ` [PATCH v2 1/1] Add a new " Matteo Rizzo
2023-06-29 15:15   ` Bart Van Assche [this message]
2023-06-29 15:28     ` Matteo Rizzo
2023-06-29 17:37       ` Bart Van Assche
2023-06-29 16:17   ` Jeff Moyer
2023-06-29 18:36   ` Gabriel Krisman Bertazi
2023-06-30 15:04     ` Matteo Rizzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0c8d74a-dcfe-78a7-74bd-4447ed6944dc@acm.org \
    --to=bvanassche@acm.org \
    --cc=akpm@linux-foundation.org \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bhe@redhat.com \
    --cc=chenhuacai@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=evn@google.com \
    --cc=gpiccoli@igalia.com \
    --cc=io-uring@vger.kernel.org \
    --cc=jordyzomer@google.com \
    --cc=keescook@chromium.org \
    --cc=ldufour@linux.ibm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matteorizzo@google.com \
    --cc=oleksandr@natalenko.name \
    --cc=poprdi@google.com \
    --cc=ribalda@chromium.org \
    --cc=rostedt@goodmis.org \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®