From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D6BC33CB6 for ; Tue, 21 Jan 2020 08:21:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B772B2253D for ; Tue, 21 Jan 2020 08:21:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="om3HH/h1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbgAUIVX (ORCPT ); Tue, 21 Jan 2020 03:21:23 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:57055 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbgAUIVW (ORCPT ); Tue, 21 Jan 2020 03:21:22 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4821hb2t7rz9txkq; Tue, 21 Jan 2020 09:21:19 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=om3HH/h1; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 51BydYp8UKfd; Tue, 21 Jan 2020 09:21:19 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4821hb1p5vz9v0yr; Tue, 21 Jan 2020 09:21:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1579594879; bh=oGUF+BNPGftCGW3dISgEIF2yqNvo6BJ3zmTHJ4nPG3s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=om3HH/h1IIoLi1XQBnSo1OU3BjcuIrUa1xNZFjufyFWs1+fdxZUPsFEUiVXhYzobi KhErHAyC//pTb+n4I82rNwPuGjsHUugx1eAdR2HaaJZPmsp4K/8zQSv8jF4j5ncZzp 6vU1RBtDhUr4z+m33RJ3n6MSuCQiG+yanG5JbDPo= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 2C2A48B7DB; Tue, 21 Jan 2020 09:21:20 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id LAV7Ig-UZZ_C; Tue, 21 Jan 2020 09:21:20 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 729648B7D9; Tue, 21 Jan 2020 09:21:18 +0100 (CET) Subject: Re: [PATCH] powerpc/sysdev: fix compile errors To: =?UTF-8?B?546L5paH6JmO?= , Andrew Donnellan Cc: Kate Stewart , Richard Fontana , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, wangwenhu , Paul Mackerras , trivial@kernel.org, Thomas Gleixner , linuxppc-dev@lists.ozlabs.org, lonehugo@hotmail.com References: From: Christophe Leroy Message-ID: Date: Tue, 21 Jan 2020 09:21:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 21/01/2020 à 07:59, 王文虎 a écrit : > 发件人：Andrew Donnellan > 发送日期：2020-01-21 14:13:07 > 收件人：wangwenhu ,Benjamin Herrenschmidt ,Paul Mackerras ,Michael Ellerman ,Kate Stewart ,Greg Kroah-Hartman ,Richard Fontana ,Thomas Gleixner ,linuxppc-dev@lists.ozlabs.org,linux-kernel@vger.kernel.org > 抄送人：trivial@kernel.org,lonehugo@hotmail.com,wenhu.wang@vivo.com > 主题：Re: [PATCH] powerpc/sysdev: fix compile errors>On 21/1/20 4:31 pm, wangwenhu wrote: >>> From: wangwenhu >>> >>> Include arch/powerpc/include/asm/io.h into fsl_85xx_cache_sram.c to >>> fix the implicit declaration compile errors when building Cache-Sram. >>> >>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c: In function ‘instantiate_cache_sram’: >>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:26: error: implicit declaration of function ‘ioremap_coherent’; did you mean ‘bitmap_complement’? [-Werror=implicit-function-declaration] >>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, >>> ^~~~~~~~~~~~~~~~ >>> bitmap_complement >>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:97:24: error: assignment makes pointer from integer without a cast [-Werror=int-conversion] >>> cache_sram->base_virt = ioremap_coherent(cache_sram->base_phys, >>> ^ >>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c:123:2: error: implicit declaration of function ‘iounmap’; did you mean ‘roundup’? [-Werror=implicit-function-declaration] >>> iounmap(cache_sram->base_virt); >>> ^~~~~~~ >>> roundup >>> cc1: all warnings being treated as errors >>> >>> Signed-off-by: wangwenhu >> >> How long has this code been broken for? > > It's been broken almost 15 months since the commit below: > "commit aa91796ec46339f2ed53da311bd3ea77a3e4dfe1 Can you then add a Fixes: tag ? Thanks Christophe > Author: Christophe Leroy > Date: Tue Oct 9 13:51:41 2018 +0000 > > powerpc: don't use ioremap_prot() nor __ioremap() unless really needed." > > And we are working on it now for further development. > >> >>> --- >>> arch/powerpc/sysdev/fsl_85xx_cache_sram.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c >>> index f6c665dac725..29b6868eff7d 100644 >>> --- a/arch/powerpc/sysdev/fsl_85xx_cache_sram.c >>> +++ b/arch/powerpc/sysdev/fsl_85xx_cache_sram.c >>> @@ -17,6 +17,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> #include "fsl_85xx_cache_ctlr.h" >>> >> >> -- >> Andrew Donnellan OzLabs, ADL Canberra >> ajd@linux.ibm.com IBM Australia Limited >> > > Wenhu >