From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49708A48 for ; Sat, 20 Sep 2025 07:23:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758352999; cv=none; b=HEDKUweXTRyfiRVjq4YRU3XmuwU05jIlIsXtmauu6jTP94uD/gUoy1ib+I4sZzixyq5A5WjsuDF+EfT10i7N4R7zveiyJ3r3yZPsDQMUq0TawwRwG4W0Jj6DYZDEaeKJxBdVesOGGWfdB5kA6LZTsKmM0s/LVeB+TgWhSLS5oSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758352999; c=relaxed/simple; bh=nBDhyd2sKhjCLs0KLMOCgBwZYW709q4bxO6fngH7W3g=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eg7I4odkrPW40GGVZQLo/V/itquLo0mHVvyk32EiSKlgwQLKMd32ZgBX+fm8k2V4aFnW1CIEt0us5YhSOu898U/xrM4eNnhhnXCDwRPoMr+nmNyp2pesJ4b6N5Woyw5bRmpxhiZd0hHXb9JJhyZTAVysHlGmYBnyhO4QzBZ7qcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Vq2Mtp9O; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Vq2Mtp9O" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3f0ae439b56so926450f8f.3 for ; Sat, 20 Sep 2025 00:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758352995; x=1758957795; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ApjCVyxmlxpVT9WHGyaAdu9HZWD3mwm2FRllaMQUQmE=; b=Vq2Mtp9O4Y56h0N917wwGaGKWu8oqUdAfi4X5SzwijBc5VpglhSHcBw5VJepYqWQlr pIcB5JD7zpeoL4bM71RsQFJcS2m5huTzBGUftuoWv7cwTuXRA2cdA19ncCagfLpQaVAs b+cQKRL4bVUvB/CpeWf1wLFaQXbKZu9LBEWdBioJYlDCMF4NsYRxbys2PBQIShWkwRfe MvvfKylxWkeNaMqn4PXi7dm9N10vZxFFDAsFhlA4pKW1KWJbNAnQaKMOJ2Km3gTFI1WS /wRna6GmdnNg+JDKixTg1u9a7qWAbItYJ1Cz1bu+sKHQh3x9ev+DYehsLN0VKQm6ma75 1Flg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758352995; x=1758957795; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ApjCVyxmlxpVT9WHGyaAdu9HZWD3mwm2FRllaMQUQmE=; b=mkWD146199xciw0M6/+z0Qf1jVfB0An2T2oSEuIZUWOhoCu1KmtzFpsQffLSGWkZlP 9xaaaUnzSCbMP4TZGOuhLwDFBq5N3yjZeGQviqKCb5xXuikz2Z4bdYW37u9yUn0wtxDj CizQk0owj+f3hw36wccYTaB5bKa3pGi7bOc33KBHlh3qAJd/Bj289AfpBHAZSWeBdMAS sd5NHpfse1M3dUBI56RaLXXDU6yYh9N35EY9cAwi1JoJxqA0P6QF30x1gK/oBhmV3ZYU ZEfjVsCQ328h1OfzlUy85turUrRe40U9fQbkuEbr9PjStw6NzNAAOUaNKNADBhqShk3h NGGg== X-Forwarded-Encrypted: i=1; AJvYcCV4BywSe5aXWmg4eBEefjXkD0mCV2aKdgBEGHiu74Re+di2tygKUT99rU8jDu6gu7kNP22ITxmvirWGPhk=@vger.kernel.org X-Gm-Message-State: AOJu0YzzkbgsugD1UmC1bwf2qptHtu6BK6TkukVIgjFkjkrG5j95iftG Ao7wa1nt5IKQTVJN85iLIZmvJA1HU9+qtlrjYZamYkCkFvcE1EIW6pEY X-Gm-Gg: ASbGncsaX3UYMP7yAb45zLiWdnDAcjYrNQBfI7W+6QSEScTjQSa3tSUFSDq3o6h+zlb 8FZKrB6tBdODhM6uWFASZ9XcalsyzCacaumW0Ddv9y0gaewN/XmPr2ezuS6WpyEIRl7mCbkyRMb aG9Rd/Z+/BfUXE30UqBqMqArkJCfc5EFIqy1Jh4SnW/mVMLrL7GBxUS6BXDW6nwuBbzeiwPBtnc f6BvexpTT2Z5PQZJClQWagh2YL7Za5SNUBgXxdSiC3jGeE5V6vYHEvmKgyM9u2wbq1jzlAgeOJH SII6m0/ec6xZYPRHWIfgz3MlhK2ktRiUDaC1NNJnl4+jE/oSJ3LfucbKnZbPAgWuOkcPdF29Lu7 69N1c3wb5VyJJsj6MKUjUES7JmGbM278I+XfD5r4qoGnLPHlLwf4JLA== X-Google-Smtp-Source: AGHT+IHQ/XHfmmVlqcvkBjMQX5+z6izyk0e6FqMAalU7cycDTL3qFUQ12Q7Tw8CXbf7brzi9bJP9Yg== X-Received: by 2002:a05:6000:1842:b0:3ee:1233:4673 with SMTP id ffacd0b85a97d-3ee7d0c7f3cmr4373741f8f.16.1758352994450; Sat, 20 Sep 2025 00:23:14 -0700 (PDT) Received: from giga-mm-1.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f32674bf8sm91662745e9.11.2025.09.20.00.23.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Sep 2025 00:23:13 -0700 (PDT) Message-ID: Subject: Re: [PATCH] hwrng: fix division by zero in ks_sa_rng_init From: Alexander Sverdlin To: Nishanth Menon , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Herbert Xu , Olivia Mackall Cc: Alexander Sverdlin , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Date: Sat, 20 Sep 2025 09:23:10 +0200 In-Reply-To: <20250919132002.180874-1-nm@ti.com> References: <20250919132002.180874-1-nm@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Nishanth, On Fri, 2025-09-19 at 08:20 -0500, Nishanth Menon wrote: > Fix division by zero in ks_sa_rng_init caused by missing clock > pointer initialization. The clk_get_rate() call is performed on > an uninitialized clk pointer, resulting in division by zero when > calculating delay values. >=20 > Add clock initialization code before using the clock. >=20 > Fixes: 6d01d8511dce ("hwrng: ks-sa - Add minimum sleep time before ready-= polling") > Signed-off-by: Nishanth Menon Reviewed-by: Alexander Sverdlin > =C2=A0drivers/char/hw_random/ks-sa-rng.c | 7 +++++++ > =C2=A01 file changed, 7 insertions(+) > --- >=20 > Noticed this when looking at kci logs: > https://dashboard.kernelci.org/log-viewer?itemId=3Dti%3A0af42187f4b24261b= 0c102f0&org=3Dti&type=3Dtest&url=3Dhttp%3A%2F%2Ffiles.kernelci.org%2F%2Fti%= 2Fmainline%2Fmaster%2Fv6.17-rc6-43-g8b789f2b7602%2Farm%2Fmulti_v7_defconfig= %2BCONFIG_EFI%3Dy%2BCONFIG_ARM_LPAE%3Dy%2Bdebug%2Bkselftest%2Btinyconfig%2F= gcc-12%2Fbaseline-nfs-boot.nfs-k2hk-evm.txt.gz >=20 > Fixed version boot: > https://gist.github.com/nmenon/0996e5f7bdbcd3b014cee9921a60d88c >=20 > =C2=A0drivers/char/hw_random/ks-sa-rng.c | 4 ++++ > =C2=A01 file changed, 4 insertions(+) >=20 > diff --git a/drivers/char/hw_random/ks-sa-rng.c b/drivers/char/hw_random/= ks-sa-rng.c > index d8fd8a354482..9e408144a10c 100644 > --- a/drivers/char/hw_random/ks-sa-rng.c > +++ b/drivers/char/hw_random/ks-sa-rng.c > @@ -231,6 +231,10 @@ static int ks_sa_rng_probe(struct platform_device *p= dev) > =C2=A0 if (IS_ERR(ks_sa_rng->regmap_cfg)) > =C2=A0 return dev_err_probe(dev, -EINVAL, "syscon_node_to_regmap failed\= n"); > =C2=A0 > + ks_sa_rng->clk =3D devm_clk_get_enabled(dev, NULL); > + if (IS_ERR(ks_sa_rng->clk)) > + return dev_err_probe(dev, PTR_ERR(ks_sa_rng->clk), "Failed to get cloc= k\n"); > + > =C2=A0 pm_runtime_enable(dev); > =C2=A0 ret =3D pm_runtime_resume_and_get(dev); > =C2=A0 if (ret < 0) { --=20 Alexander Sverdlin.