From: Dan Carpenter <dan.carpenter@linaro.org>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>
Cc: ivan.orlov0322@gmail.com, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
mathieu.desnoyers@efficios.com, shuah@kernel.org
Subject: Re: [PATCH v1] selftests/media_tests: fix a resource leak
Date: Tue, 21 Nov 2023 04:42:33 -0500 [thread overview]
Message-ID: <a0cdd2a9-08db-4b9e-aba4-7837df7fd2eb@suswa.mountain> (raw)
In-Reply-To: <20231121093238.5376-1-zhujun2@cmss.chinamobile.com>
On Tue, Nov 21, 2023 at 01:32:38AM -0800, Zhu Jun wrote:
> From: zhujun2 <zhujun2@cmss.chinamobile.com>
>
> The opened file should be closed in main(), otherwise resource
> leak will occur that this problem was discovered by code reading
>
> Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
> ---
>
> Hi Dan Carpenter
>
> I believe that the Linux kernel code is sacred and should strictly adhere to C code conventions
>
*sigh*. You do you, I guess. This patch is pointless but I don't care
whether it's merged or not.
regards,
dan carpenter
prev parent reply other threads:[~2023-11-21 9:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:38 [PATCH] " zhujun2
2023-11-15 15:34 ` Mathieu Desnoyers
2023-11-21 2:59 ` zhujun2
2023-11-21 7:47 ` Dan Carpenter
2023-11-21 9:32 ` [PATCH v1] " Zhu Jun
2023-11-21 9:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0cdd2a9-08db-4b9e-aba4-7837df7fd2eb@suswa.mountain \
--to=dan.carpenter@linaro.org \
--cc=ivan.orlov0322@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=shuah@kernel.org \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®