mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "diogo.ivo@bootlin.com" <diogo.ivo@bootlin.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"andreas@kemnade.info" <andreas@kemnade.info>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"tony@atomide.com" <tony@atomide.com>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"aaro.koskinen@iki.fi" <aaro.koskinen@iki.fi>,
	"rogerq@kernel.org" <rogerq@kernel.org>,
	"khilman@baylibre.com" <khilman@baylibre.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/3] watchdog: omap: Preserve OMAP watchdog across boot to detect faulty boots
Date: Thu, 19 Nov 2026 16:12:13 +0000	[thread overview]
Message-ID: <a0ce41df99aeb47edc733733be54b9c0e9ead767.camel@siemens.com> (raw)
In-Reply-To: <f1adea74-8f87-4442-aa12-18536cabec3c@roeck-us.net>

Hi Guenter, Diogo!

On Fri, 2026-09-11 at 10:25 -0700, Guenter Roeck wrote:
> > > > Allow the OMAP watchdog to survive being stopped on kernel initialization
> > > > so it can detect a faulty boot in cases where the bootloader leaves it
> > > > running and the watchdog driver picks it up during kernel init.
> > > > 
> > > > - Patch 1 removes a duplicate omap_wdt_start() call left behind by
> > > > cd004d8299f1 ("watchdog: Fix OMAP watchdog early handling"). This is
> > > > unrelated to the main goal of the series and can be picked up
> > > > independently.
> > > > 
> > > > - Patch 2 adds support for reading the watchdog boot status. Probe now
> > > > checks whether the watchdog is already running and takes it over instead
> > > > of blindly stopping it based on early_enable alone. This introduces a
> > > > regression possibility, explained in detail in the patch's message.
> > > > 
> > > > - Patch 3 marks the OMAP4 watchdog node ti,no-reset-on-init so the
> > > > ti-sysc driver stops resetting it. A detailed explaination of why is
> > > > also provided in the commit message of the patch.
> > > > 
> > > > This series has been tested on a platform based on the VAR-SOM-OM44 from
> > > > Variscite, running a TI OMAP4460 SoC.
> > > > 
> > > Please address the issues reported by Sashiko, or explain why they don't apply.
> > 
> > I have just replied to the Sashiko reviews but I'm not sure if you got
> > the replies as Sashiko did not include your e-mail in its review. If you
> > did not receive them please let me know and I can resend them. In
> > any case if you could give your opinion on the comments I left on the
> > patches about regressions that would be great as I think after the
> > Sashiko points are addressed that is the main blocker for this series.
> > 
> I did. I just wonder if the effort is worth the pain / cost.
> 
> Is there an actual use case ? Is the problem you are trying to solve
> a real problem, or a theoretic one ? For example, the patches impose
> a hard boot delay of more than 30 ms in omap_wdt_is_running().
> Even though that could be optimized (there is no reason to wait
> that long; the value could change a microsecond after the first read),
> it is nevertheless a mandatory boot delay.
> 
> Another concern is the impact and potential side effects of setting
> ti,no-reset-on-init (and the possible boot loop cause by it due to the odd
> 30-second init delay). After this change, a running watchdog is no longer
> stopped. What happens on systems which do not load the watchdog at all
> (for example because the driver was not configured) ? Will that also cause
> a boot loop on such systems ?
> 
> This is just a couple of problems introduced by this series. You better have
> a very good reason for it to warrant having to deal with the potential fallout.

I actually find the series promising/useful and will be testing/providing
feedback on it. I think it's too early to throw it away! ;-)
Thanks for your work, Diogo!

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com

      parent reply	other threads:[~2026-11-19 16:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  9:17 Diogo Ivo
2026-09-11  9:17 ` [PATCH 1/3] watchdog: omap: Remove duplicate start() with early_init Diogo Ivo
2026-09-11  9:17 ` [PATCH 2/3] watchdog: omap: Add support for reading boot status Diogo Ivo
2026-09-11  9:17 ` [PATCH 3/3] arm: dts: ti: omap: Prevent watchdog from being reset on kernel boot Diogo Ivo
2026-09-11 14:29 ` [PATCH 0/3] watchdog: omap: Preserve OMAP watchdog across boot to detect faulty boots Guenter Roeck
2026-09-11 15:17   ` Diogo Ivo
2026-09-11 17:25     ` Guenter Roeck
2026-09-14  8:32       ` Diogo Ivo
2026-11-19 16:12       ` Sverdlin, Alexander [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0ce41df99aeb47edc733733be54b9c0e9ead767.camel@siemens.com \
    --to=alexander.sverdlin@siemens.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=diogo.ivo@bootlin.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tony@atomide.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®