From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B17173002C1 for ; Thu, 14 Aug 2025 13:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755177836; cv=none; b=mEUSRWl79PM+NIw9kYcpey/UqP8/tgvkfQTuz/cCzqQJW94QnbuUdHKD6I2xb8boiuRcJ41EvQ91krBcJx1Nl6LLCYEQVps1ngxtH4xOsvmrl9+4nP8Q4Rh3EhwFrY/+VmMJxV71JMpMyQas7vxbZDbCBJEiRPyhxn0ZnU4ldYg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755177836; c=relaxed/simple; bh=j2lJMHwL/mryALVVeqNju/rLZLU5pws84MPhbxVUNy4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m/aFvBtOUoh2wWZaKg86sb1DFTJiAvygC4qWil5H1/JbaPXFEoY6VIW3ud06NKzgijqQAmHmekCz0d3ZNNgCSX0ch3zunEYRjzsPv9t4+MfOm+5pXFKUNfwiYi5pE/tw7KfJo75Fc+Me1o6x5tff3mv1yrxjfJY8p049tPSoc9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wBMrmAc/; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wBMrmAc/" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-45a1b066b5eso4415105e9.1 for ; Thu, 14 Aug 2025 06:23:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1755177833; x=1755782633; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hEb06N5Fa4rPEtmflX9srzTgGFvnEZaC4f274YC/kn4=; b=wBMrmAc/ssv8H3ItNktg+xvObTxNhaBKsCut3lcqhwweVBmxpBbddYH7grGRfTvCur ThyImNueh+zmu3bkFDzKHBtGWcefrFXwyPyzrAGRGtlxaTe3BQPmijo3PiJaoYUgra4e tOYoQfklvzP7u37OvKQLpGCrBpZljYpOKGzNdogVvhZI60qNULR+zkN8UiBKJhZZji1B 4v3kI/bR5pZPhwzsfm2hH1+DYmCQanqtwR6H1VnVzb1rrCTe28tXrIlVkF1LrZfq37OI 5/y3IKh168mzjhICLnu3VbNSrnXfqbatIBY7Wox4mU8AoJg/aEiFBSvzeEoPfQs3/o0E OhxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755177833; x=1755782633; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hEb06N5Fa4rPEtmflX9srzTgGFvnEZaC4f274YC/kn4=; b=pQ7jatOz64rDphBrQCUT1m/4w+M8exmhbtc46i/nB086L03/DcSAtN7VzLM8KVZBl4 7SdjEZqT6Q9P34wpTuDmtToq7ZrpPHSg9kO7xoHan6nqXmEHClCvupajshvfEkB02SWA Od53V3KkGjN3SlTCK0vCQRbLEfTelT1et4PsW2CQNs24cSFwcrG9droXVVnZzIZIKC38 /XlBq4o/lMjXJupRT8PBCrd3/5ZUkJ8REolq0MaOj7Z9wIbrQwLUN6WLarthiaVTKPvX ipuiaCcxtFem0m/Uvt0bXnTB47YD5fJy+jYBfuAzefUS9fHNYYMwR6hU6cx6NYyh7p4U nC2w== X-Forwarded-Encrypted: i=1; AJvYcCVSmUDCQAtG6ETJlqE4Lcnq7t09zozW2Lwah9g6b7IHkkx8O7NS+depGweAt8Kg36dJjciy030u6G866qI=@vger.kernel.org X-Gm-Message-State: AOJu0YyPCiuouyDRelHhJxpnUbIxM2wL9DzvEa1+lvWqnVtffaGHWP5p 7/Ps+KbzMvTyGtLNggNqmq5J299lVlZKKG0Ex6zo1SKcTD1B/klmP/QHmCoBNW9ocnw= X-Gm-Gg: ASbGnctCohmjwZZMas0eVdPgvl/R2uBdnxn6S/5VHir3H6XUVnonaueGvCaQ8Qjl28V qbxWNPUuBYGg+2PUr3ra10qS1ARoGm1wViCYDZX3KOozcGLvyRFAtwLPNKXDnfAg+gdwxvtGkUn u4dO9fORJkIzkCTqRnxsyFNrNAgn73cTjHPvaEYhtZue9qlAY97di0j9JcNmbkLTJ5W9OOZ9e2p pE7Uwmh9jBjw071/8iIxXskCHCbw6GQtOqG+tvMxVFwTF7wofD1QBjp8c6kyVr/w6X1iOT+x0k3 HuonTqoj7alaTpagTEq7rrr1E/Pad5R/ndkUtyRD0QbSCwnJGoIVFiOdTh8Th04gXRy4K3bXS85 Ogztx0pRstgq8+rOgbSj0vx8oK/vfKhFGTmOHOq9pYUPvTbKY/Y1VWnl8m/WNdw== X-Google-Smtp-Source: AGHT+IEeWDaYHaX1ixVeGZrg1niQ27if5sJYq8roDVzPgUppHd5n/Iw2kUmDMcNmiQTa/EJbkU3Psw== X-Received: by 2002:a05:600c:450e:b0:456:496:2100 with SMTP id 5b1f17b1804b1-45a1b6753a2mr28657505e9.31.1755177832928; Thu, 14 Aug 2025 06:23:52 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-45a1c70acc7sm20591415e9.25.2025.08.14.06.23.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Aug 2025 06:23:52 -0700 (PDT) Message-ID: Date: Thu, 14 Aug 2025 15:23:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] Add the s32g2 and s32g3 FTM PWM support To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ghennadi.Procopciuc@nxp.com, s32@nxp.com References: <20250812200036.3432917-1-daniel.lezcano@linaro.org> Content-Language: en-US From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/08/2025 12:54, Uwe Kleine-König wrote: > Hello Daniel, > > On Tue, Aug 12, 2025 at 10:00:34PM +0200, Daniel Lezcano wrote: >> The NXP Automotive platform s32g2 and s32g3 have on their board a >> FlexTimer (FTM) dedicated for the PWM. The same IP is found on the >> Freescale Vybrid Family and the i.MX8 SoCs. However, there is a small >> difference with some registers not available on the s32g2/3 and 6 >> channels instead of 8. >> >> These two patches provide the DT bindings for the s32g2/3 compatible >> strings and the code to deal with the FTM difference. >> >> Changelog: >> v3: >> - Fixed dt-bindings subject prefix >> v2: >> - Merged the two booleans for the regmap holes check >> - Clarified why this is needed in the changelog >> v1: >> - Initial post >> >> Daniel Lezcano (1): >> dt-bindings: pwm: fsl,vf610-ftm-pwm: Add compatible for s32g2 and >> s32g3 >> >> Ghennadi Procopciuc (1): >> pwm: Add the S32G support in the Freescale FTM driver > > Applied to > https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next > > with this merge conflict resolution: Thanks for fixing the conflict. Restested it and I can confirm it works as expected. > diff --cc drivers/pwm/pwm-fsl-ftm.c > index 6683931872fc,e0069dbdb02d..000000000000 > --- a/drivers/pwm/pwm-fsl-ftm.c > +++ b/drivers/pwm/pwm-fsl-ftm.c > @@@ -396,7 -428,9 +416,7 @@@ static int fsl_pwm_probe(struct platfor > return PTR_ERR(chip); > fpc = to_fsl_chip(chip); > > - mutex_init(&fpc->lock); > - > - fpc->soc = of_device_get_match_data(&pdev->dev); > + fpc->soc = soc; > > base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) > > The pro tip here to make your upstream maintainer lucky is to work on > their tree or next or at least the latest development release and make > use of `git format-patch --base`. Ok noted, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog