From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFB5620330 for ; Sun, 5 Jan 2025 03:04:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736046281; cv=none; b=tfOhrfaNrqcvODRqzmNhPyw09X4wct8YmoKNHA2dTy0rvuGwzJhyiSNeZJ7PbFEyi5/VeDKNvmyOhB/C4boIbNWeD2ZqNp3J+5iYh9+sdlYTf9t6KdBe0m13/VMp6p5RjIsD7wNeB6uy+O+qairLSg6LCqfHc1ibsPPElJifPfY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736046281; c=relaxed/simple; bh=wVPtncUionGSGB6weARFJPnaU0WDaku2K1rIZTIFdI8=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=BpCSxHqCO1ru8vZiB5f7H1HanrJ04pDRFrEUlhVpL9nSnpWbTbRvQsJLCEFTu1ICrFtaQ6+tevhtll+an6jwnK9g/+N8+X41uUEMjqlh4LhRgnFXff2KEuNz+U9CsAtjxRIFsdYr2MrDarRQVKz7JnuGNnNFk8YaW3TLH8HhQXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=I1uzif15; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="I1uzif15" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-467a17055e6so148628711cf.3 for ; Sat, 04 Jan 2025 19:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1736046279; x=1736651079; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=6955gtKfg5oEFuxtQGlyDD5kuPjGFQ5vk5JbxQicH/U=; b=I1uzif15fhgYjmpjRt0yNw+SM4AJCKHt+g7jGhO5eihJwni1DUXGpUbVr+dop6SVnS YsIKlUwbpw8X9kZA6mFdfzdVYLcqbpHVrpasrmE3fzqbAW3/L3WfwKpXDAzr3rPxp0SJ UdgZUKUDgthV5p1PMT6W/4IDJplWvo3XJ2LRFW8NjJ4u/+ycEHg9LHwzuik8Ngyp10wl D8uAq3pVK8x78hZLvZEqiqRj21m+2DVFGqBgjEtNH5Nh9pkRxqO6Te0etAfn+gErMeCt QctFrh4daK6yPzcdNNSYm9aCqLyZrILJOj12SIXmDDM5Nm1t/ixLRnHlqbMTL/Mz2nz0 Pg9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736046279; x=1736651079; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6955gtKfg5oEFuxtQGlyDD5kuPjGFQ5vk5JbxQicH/U=; b=KSJJJE8U5yEn11fI93D2do1JWkDGH2koXNPRr6CIVqOODX9Eg5S2SgqFNBEJWHnu6B jWMp0SGGpM5/KM0imIizbZbJJ2r81z/aI6yD0kGGsDc0EHTo0+q/D6ilKJUydNPdSCkN NoCNbfOQqMf/C9RS+fv/KjOZMImDB3ZKK3Oy5da9Dsx8jwEj96K3TdrQrpG3Tt2wfXNg lz55sGpgSFgHs2ZlK0lVLTY6A6uSW+UxtvbA/1CZF8veyeDbI9E8oEe/8QFE/XoUDA3U e4cgiJRS5g3YgWlskPjOoor3fWFP1LmVZVdAqwUeSvEw2PRd7KGDcRyoelYvsK5XbkTo 3ckA== X-Forwarded-Encrypted: i=1; AJvYcCV03ebCR9/UhHpHikc+2yqKyE/IlYaJmpu2ermp8CPxvRpKt6qC9donqKIi0b1gR37l5N4/JInr/fApRR0=@vger.kernel.org X-Gm-Message-State: AOJu0YwPgdJB5w/SFfXqGe/fvuy3q68yFM4SEXKkLxuA6/wr1HgNi5NT tuz68fs7vC1WyAtKsdAy8lJid43pT4T6forrGW/cHxdAWe/8BN1L2UYpqefhxQ== X-Gm-Gg: ASbGncuv+DHKGsZbhd8dZ0kt5xjfKd+ROYTyKnA1L4styWxXoAR+zfs2SVSowCImJ0e YZ199kEel8NkYVHk9fZJ+aFhAlKrgBI6IE+Cv53Six0fXpQCiajATK6nAtWLf2D49JlhieZa+Vy rOEm9BPU1nzE14WpVuPvBe0IieHdkrHXvjDlqzBxetpkS4/RCfDcgjEPxx6RCc3dPry6NHfs4Qs BgFr+fqk7sR0VJWi0XCI34Wmrqk9jjx9EQVlrsPdBk4MLHy0bA= X-Google-Smtp-Source: AGHT+IE27NYmWwTdi5HNIXq4FMJ6UExsCybpWZLcTHc/1IkULeeLF6BI+iMXURnMbLFG6lC6o05CZw== X-Received: by 2002:a05:622a:287:b0:45d:82a0:5028 with SMTP id d75a77b69052e-46a4a8b879cmr794375121cf.1.1736046278825; Sat, 04 Jan 2025 19:04:38 -0800 (PST) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3eb2c578sm161953691cf.77.2025.01.04.19.04.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jan 2025 19:04:38 -0800 (PST) Date: Sat, 04 Jan 2025 22:04:38 -0500 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20250104_1133/pstg-lib:20250104_1133/pstg-pwork:20250104_1133 From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= Cc: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , James Morris , "Serge E. Hallyn" , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: Re: [PATCH 2/2] lsm: rename variable to avoid shadowing References: <20241125105926.47141-1-cgoettsche@seltendoof.de> In-Reply-To: <20241125105926.47141-1-cgoettsche@seltendoof.de> On Nov 25, 2024 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > The function dump_common_audit_data() contains two variables with the > name comm: one declared at the top and one nested one. > Rename the nested variable to improve readability and make future refactorings > of the function less error prone. > > Reported by clang: > > security/lsm_audit.c:302:10: error: declaration shadows a local variable [-Werror,-Wshadow] > 302 | char comm[sizeof(tsk->comm)]; > | ^ > security/lsm_audit.c:200:7: note: previous declaration is here > 200 | char comm[sizeof(current->comm)]; > | ^ > > Signed-off-by: Christian Göttsche > --- > security/lsm_audit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Merged into lsm/dev, thanks. -- paul-moore.com