From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D91E3CE4A5 for ; Wed, 25 Mar 2026 11:20:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774437653; cv=none; b=tMljxSE6xSDWt/DLntN9/fYPrYnKhFt37OOQ57vA7Ebp5qk6a1Ha6Tubjv5Za2NY8Xjp2dxngrK0BMbESoK1qbTvYCb+OZ0REQlgzv+Dp3zhaKVt5ras4m0APFtvDsFOYQOhJ5zs5j9XS5PLozEaIylE6sr40Aca+o8tNhAswag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774437653; c=relaxed/simple; bh=MqqPvaCpMUSdpy8bJlGFo4cZtQj3//vtqXYIJw14Cu8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m2jFMHMkjJ77Fp/RErHoKBnsIPDkV4AmF2/uN/XOzfJu21GZPrGogb1cmBtjRbvY8zXX+MymiNxoLtcF38woe/U+gusl6Rm66kj3yd2jQ1V8Ck8iTS5Y4ci3Ctf955Ny1JZnamHvdpSZcxUYslBER+AVrZO9XCHBg+qFh90WMp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NuHgc/e0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OtIbaArs; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NuHgc/e0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OtIbaArs" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62PBH7b21024469 for ; Wed, 25 Mar 2026 11:20:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bo04PPluhNxDs3dNvQUl61WfLNkmR2AQ12kwe+gKE2I=; b=NuHgc/e0oACN8Kv3 HaamJVnrePiqyFWpPCM7S/36+EvAJ1V+MLo3P8Y6ftuaOUcKoD90YGH7aOK4m7VB PlW560yrTGKGmSfZia1KW4RhFlCOCOfY+mCytKYUVmLGOPQWdjpj6xi/ta6CGGAA Phw2ZlCVZ5srV6VngfQ9mtu3Z2MdELY9W7fx8zL+r1XQUqthusks2V23C9bvIK+k zkXhG98nUgVWuoLLYFkThTN8V9hXg49em9Y6gQ/7Vk1rXxu6of27JsNVaz2p+Gu4 SVph1uJsyyU8H/hdoshAK9SpINESeog4xmgsBcTXZDrRL3n6fvkuCtTXQ/505Pdi CCsn1g== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d3vhvv63k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 25 Mar 2026 11:20:51 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b2d5e61f6so36347831cf.1 for ; Wed, 25 Mar 2026 04:20:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774437650; x=1775042450; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bo04PPluhNxDs3dNvQUl61WfLNkmR2AQ12kwe+gKE2I=; b=OtIbaArsM5sak/2moIaFT7xckJXWN8057ZxWzODOGBwe2UDTouaHBwa0FCFXcqAz93 x1QggfK5pHK1qiZUeYsscWxyM7s1zLiMks5Y7yqSA/5AXKygur26LZrRIZXTEWevvbtE 46tbvrSydRsfuHnkt9yyKxwoA4iHcY/HSvMBFHwKSZnSEpXpyC5FJGcjB6sLbsH7oChZ uF3ftOCpmVZ/hpghpr+8FteMiiF90xQ4vfe09Bl4H4FsUxwnAA5hI9rSUS7XCPrrzoPL zbx7I7iz784LP44xVUzVD5w+u5oL155CqnCoZqmsisvV2obbGb4zE/jdR1f9wpeghI4H DzBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774437650; x=1775042450; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bo04PPluhNxDs3dNvQUl61WfLNkmR2AQ12kwe+gKE2I=; b=Cmx3fng2dsgcIBrGy5Jju1nHkCID6RnPNXzhPA4UTbzJgA3C+W0Ty/wGUn74sGFP3v N4E1IBUI3t4+mlzBa1a1xamStOZPAjmCNyqW0zDzEFDkXgqPv/LQTR2yLv9gLe97WfAd r3l5mZ3wnU7M/vQJI8sDC53rvhE7cAmgnwhHIZtk/3tmrpIjOeFUc5o6aHiv/ibrb5I7 fnEvvYuuoMT76LoQVp59LaaYI1TF6RVkj/9ORd5Z+ns2kfQQqh5SHsjIcZNyG5BmQqtd soixsCHo5l1oay57g/oRaybGx6i1bEebVSruFRbGfA6Oj6gHuIg/7DbKCIZATB6dYb9+ J/VQ== X-Forwarded-Encrypted: i=1; AJvYcCVy/cYdegrM4YeVCwDSUOsAtlH7u6a4n9O6RHS4VGal+yNPKMxXF0SOBoXcqBxvtybTYPSOXyFadeJsAUk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2A18O9Xz8YkSt3OnIAbZeckPocIGmDVk34oi/5UR+iGlR1+jA L+PJsrGH0d/F1ycN8/eAcoxZWcW1OBhBzVtqO7cRB8LX2Pr+vzUWkfCpt3bxT7NkCdpJDsneVNT pdB8+2B+mbZH/C4ve4tFm7cxMsgMbZOBJ7i65jIj6/hmlzG+9MwgR5j8jki6osYrPHnk= X-Gm-Gg: ATEYQzw0Oi/Xz0NReYQotgx0mSTxr8+8eot1diJqjR6J8ZF0TfVzR6mIW1GGEFSiROR sGdI8RhiVLR1J/KUqAgmew063rMFgkCACKcu9+PSxgfjzQZL/ysvknrmhmmXI5Qq83aqH6q5Xf5 vV/WRDpKidNjlVs3oHDZwDHeXFEAbQviVRAWAjoBdzdgixhAn74MPLQ8VDj8BfwwMAXsQJb4HlL oPA79Y2ZSGSPs2B6zNg1mp/x53dETay5ygZxAhEtudCshFy5koYsTF/uXO/xEisulnbgHPU9TtR URRd8CBp3eTzI3qNnt1E3LSKYvxt8anH4EngeqrE/HoiSTNh9amy6eH9jGeiX6uEdWxf0dKNH8d +zFAgcsgC3xuOkLUA1NoqKYAmDPTVjB+EDyFV9lzGn2fCaifEc/6JkNQGLrEmd5pIW5ZL87qUmp 7vzno= X-Received: by 2002:a05:622a:5287:b0:501:4767:a6f with SMTP id d75a77b69052e-50b80cdd452mr30820841cf.3.1774437650212; Wed, 25 Mar 2026 04:20:50 -0700 (PDT) X-Received: by 2002:a05:622a:5287:b0:501:4767:a6f with SMTP id d75a77b69052e-50b80cdd452mr30820571cf.3.1774437649651; Wed, 25 Mar 2026 04:20:49 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b98335de177sm773644666b.29.2026.03.25.04.20.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 04:20:47 -0700 (PDT) Message-ID: Date: Wed, 25 Mar 2026 12:20:45 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-shift-axolotl: Enable NFC To: David Heidelberg , Konrad Dybcio , Alexander Martinz Cc: Petr Hodina , biemster , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , oe-linux-nfc@lists.linux.dev, Krzysztof Kozlowski , devicetree@vger.kernel.org, Conor Dooley , linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Bjorn Andersson References: <20260324-oneplus-nfc-v2-0-3eef052c9bc6@ixit.cz> <20260324-oneplus-nfc-v2-2-3eef052c9bc6@ixit.cz> <9d9ec994-c954-445d-97b2-772614d66f35@oss.qualcomm.com> <041766dd-422e-40e1-9e5d-c220580871f5@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <041766dd-422e-40e1-9e5d-c220580871f5@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI1MDA4MCBTYWx0ZWRfX8nXlQQ/WATNO 67mEraeDMUTJp4G+EXDUPAtMm0dIhw/ZRMa4IJove5mXtvzQJqcM2Xdv2ogNA2vlK7vFI0aFNhB FQxuCWjVl1T/RCiZzUxQ+6KK+AtyCmG23xKQ2TCUhAwsWqZAUnIYrHvARLKxOLHVtfxVN7J6Rb0 lqGFUWAG0qxGG3bys/IO5ppT7SS9MCmKnTloRJm42MHvVGhdfQ3RdgmEwm38LNXlJatffpRF75t 7kEib5CW7qGVhv9q2HdYGnLYP+DZ5Z7e0AZ1nLr2XoCORqOyQqEMN+VgaT8SiHhkyd7HoTcJj0q pWzneCEq+u2mGYcL18f0PPT4w9QqmJ0u5f1yM7dLjd6BmAzO7vA7sIrBlQ8xO9Hj1B3i0jCbwdI yQeSBm67ngW4UUhhdBTlgPk2DJTiaDgADiH3otHA9Ofdjo1VsyAA5KTLYwqOxbh9PQgrG/PplRS FotGq18eWZT16Mr0yVw== X-Authority-Analysis: v=2.4 cv=P5M3RyAu c=1 sm=1 tr=0 ts=69c3c513 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=uWvuUna9Uad_Tg1iXS4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-ORIG-GUID: fDLPNGdnB8CguptQ2wiRD8ET5IhBVvCs X-Proofpoint-GUID: fDLPNGdnB8CguptQ2wiRD8ET5IhBVvCs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-25_03,2026-03-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603250080 On 3/24/26 7:08 PM, David Heidelberg wrote: > > > On 24/03/2026 14:12, Konrad Dybcio wrote: >> On 3/24/26 12:20 AM, David Heidelberg via B4 Relay wrote: >>> From: David Heidelberg >>> >>> Definition of the NFC. >> >> "meh" commit message >> >> [...] >> >>> +    nfc_enable_default: nfc-enable-default-state { >>> +        pins = "gpio12", "gpio62"; >>> +        function = "gpio"; >>> +        drive-strength = <2>; >>> +        bias-pull-up; >> >> Are you sure about pulling up an active-high pin? > > I'm not sure, but downstream does it (and "works for me"). Maybe Alexander would know more details here. Would changing it to bias-disable also "work for you"? > > David > >> >> FWIW TLMM subnodes are best sorted by pin index (although the file >> currently doesn't really do that) as per dts coding style > > I assume when I group the -pins into -state it doesn't apply anymore? As I don't feel having pins relevant to one device / subsystem all over the place is extra clean. Krzysztof? Konrad