From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753170AbcHPGEQ (ORCPT ); Tue, 16 Aug 2016 02:04:16 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:11709 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751304AbcHPGEO (ORCPT ); Tue, 16 Aug 2016 02:04:14 -0400 X-AuditID: cbfec7f4-f796c6d000001486-6c-57b2acdaa5ac Subject: Re: [PATCH] pinctrl: exynos: remove duplicate calls in irq handler To: perr perr References: <1471256227-6282-1-git-send-email-strongbox8@zoho.com> <20160815165941.GA3769@kozik-lap> <15690a422ec.d724844125972.3079329677610732706@zoho.com> Cc: tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, kgene@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org From: Krzysztof Kozlowski Message-id: Date: Tue, 16 Aug 2016 08:04:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-version: 1.0 In-reply-to: <15690a422ec.d724844125972.3079329677610732706@zoho.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xy7q31mwKN1i8Rsvi9QtDi/7Hr5kt pvxZzmSx6fE1VovN8/8wWlzeNYfNYsb5fUwWh9+0s1p8eHGIzWLVrj+MDlweO2fdZffYtKqT zePOtT1sHpuX1Hv0bVnF6PF5k5zH+fv/2APYo7hsUlJzMstSi/TtErgyFmz9x1wwj6ti3ooZ LA2Mb9i7GDk5JARMJI6tesIEYYtJXLi3nq2LkYtDSGApo8T61YtZIJxnjBKnLq1g7WLk4BAW 8Ja4uTQApEFEQFlizr6LUDULGSXmvd3PDOIwgzRMOXKPBaSKTcBYYvPyJWwgNq+AncTyrlPM IDaLgKrE9B1rGUFsUYEIiVurPjJC1AhK/JgM0csp4Cpx9+ZSsMXMAuoSU6bkgoSZBeQlNq95 yzyBUWAWko5ZCFWzkFQtYGRexSiaWppcUJyUnmuoV5yYW1yal66XnJ+7iRESE192MC4+ZnWI UYCDUYmH9yTDpnAh1sSy4srcQ4wSHMxKIryTVgKFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d 9T5ESCA9sSQ1OzW1ILUIJsvEwSnVwOg4e4vuDb3PG56UmwdlNH50zT1rdadtW+V/t+Tg8gOC L2efEu9yYLue7iRhl1QsYbvCYObMn7lvrqnsOix/5Z1BYHLunTUvJDdcWlVtsmdi3oIqwaRf 5w0ni0i/MTgU9q51uT1vkLtmfpr/21eS789cfy98z+bZlAkx/Y7dS3SMGLy8/pzUMldiKc5I NNRiLipOBABbnUR3hQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/2016 01:58 AM, perr perr wrote: > ---- On Mon, 15 Aug 2016 09:59:41 -0700 Krzysztof Kozlowski wrote ---- > > On Mon, Aug 15, 2016 at 06:17:07PM +0800, perr wrote: > > > Because chained_irq_enter() has already called chip->irq_mask() and > > > chip->irq_ack(), also chained_irq_exit() will call chip->irq_unmask(), > > > so it's not necessary to call chip->irq_*() here. > > > > > > Signed-off-by: perr > > > > > > --- > > > drivers/pinctrl/samsung/pinctrl-exynos.c | 6 +----- > > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > > > > > > Looks correct so for the patch itself: > > Reviewed-by: Krzysztof Kozlowski > > > > However, your name "Perr" confuses me a little bit. For the > > Signed-off-by statement, as mentioned in > > Documentation/SubmittingPatches, a real name is required. The name > > should match the author. > > > > Would you be so kind as to use a full, real name? Unless Perr is your > > full, real name... then sorry for the trouble. > Perr Zhang is OK? > I'm from China. Perr is my first name in English. Yes, seems fine. Could you resend with updated name? Best regards, Krzysztof