From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4F4A432BCD for ; Mon, 20 Jul 2026 14:42:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784558525; cv=none; b=JdayTHgNmWruYnhac4SBFwIb62gHNTVQzYTaGC469ilcEb+/8qCwkXLPP+Z4Rw9m3x5wzkCOVye7s2st+XwnBDJ/dbUUm2tiP7mx4d4ljLr5st0KVLJg4Jl7S3e1+gEO1OjIr0/fYI49J3smzBrgWoNk5THdqMvUj5fScDa2Kns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784558525; c=relaxed/simple; bh=bID2FSRrvzZ/HOE6eJxJfAYUzIhLUTI61YUfrj7oEg8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uGHEmlwtpIsNTEMPAtE9xMsC6NYxzKfInvoQHKZkNv6rlI4rrobT+c8ecuk+4Zd4g+vsVfJ7WQ9VuODtdTprmDLe5kun8oi+e9SgLaPtOThYHOrwESW3ZqsAMM4JCvNlcrhKwe6tr6VM0CL56tTciPyU2BCa3nhPzwdJcOsqhPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=guJskifD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jenQbvY7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="guJskifD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jenQbvY7" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KDqgGf2604396 for ; Mon, 20 Jul 2026 14:41:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2BLpJJYIssKHWV80rmLOSVdZoUsiqPhLQXr2/gGzEvo=; b=guJskifDDR2Z1q3c 7aEtzxRzBofasED68rgt1tMhjFdEoEj5jAmWxrwsC+KdRr6FRCCQf82A3I36Ng8s eSwRECIMDOJ9otlOKE9g68m3hKLA9NSSNgHeJGWsliqfheRZERAueTDamhIp5yZb xGxsScQvmOcuFKU8aLE4Q/FxbFFhAOVjmK5qgG/77o8QUlxlBkNb8tn9REWRj/JS UAzwCc/3vC43cxNQKgVoAIyFeUkoJswZ8Ye+PTS6OSv/NMMDctgZh1nxdROfDQMy mypGLgZ9JRnp+ujkV4Yqh9jWeHTJ+DeMuSJ5gX8Xf85bojW9iqCggeuzWnjISAU+ yTLJhA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhggg9n2n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 20 Jul 2026 14:41:56 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51bfd1772d8so17069761cf.1 for ; Mon, 20 Jul 2026 07:41:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784558515; x=1785163315; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2BLpJJYIssKHWV80rmLOSVdZoUsiqPhLQXr2/gGzEvo=; b=jenQbvY7b2BvFqJDxA7OD+VhrJulJ0mtkRXBzJ9AZcBso8C3W5SUUK6M+9wyfsFyvA 7t5C6ARf5M5QHTmjUhjBBpXKyUuafTFbEHH0+ZmJJS36lXNyLPUMjCWj5iJf/ATe2Ayw ha+CMJqtLPEL1th2GjEUKp5mpSvR81gvbaqrc+4PuWBL0cBQmH4GIYjge0CVegQ/sda5 w8+oBEvoVUnUtUDrBNVFrSbZoAOqKb9hi7FMTIMQxvb5oY5RqmWni8QzuZZ+fPKTqlCd jK6CG+4ZSjPmXWa1eXp+CLN1t8uekaAEVx0um72c8k1UT09wruUKEvtPpEd53MWjbAS3 Y6mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784558515; x=1785163315; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2BLpJJYIssKHWV80rmLOSVdZoUsiqPhLQXr2/gGzEvo=; b=GfDN7K8nuN7EbtNSJc0UyKDrecVGHDzgrOMu5I8reZOGehaQhJ4JGWOK8sXqFCXExA 2bnomlcPCnE233gp9mogee2TCu+fS9qR16Nrw1H3cmqkpHJzZVp83MEQkmyhqWQNvGLE U+65OOW1tcU7s+DEh2XM5yYO4fhLs6QOw6t6+kWeUNSefI2LeFoCAm7WMc5nTYCgygeN P4WI7dOF8El6IHyJpJOs7sXj4kAte+S8GCTxux30ndo5805ORKeqW0NfMjSLq2VpqluT 4hOmwCpwepAuBuBI2wOanYoJyPVFEXBslfQlvWgaQyWt3sWjYuhi+sJfqbDJh6H7lehJ lJLw== X-Gm-Message-State: AOJu0YwJA+R49/F0wGs99aQb9xGdxZ6ybN8h8YfsgdniVu8ks7aoszYX FlMCO14ehBGGwqpuD2+lfHWlVNFFRm3zI1ibhXfVJ5GxAXlcTSBQGLWIt9sXk4Xs8ynWQN/U0Y0 Gcm3aFMmjNKUTbNQlr5Hl3GjV/qVtjWNxUJrKZcB/VFk0pg7q7am/KEuhths66Vv26Dy9qg1cvo E= X-Gm-Gg: AfdE7cltxEb+bf611ZAuCWYliTpFY2k6X6bFVogqkuIDZzo65ZKKOSYoz8RDnp58SpR qtiG8c4SU9vrquj6JDWvFdNtsy5586PWrN0du9e5DZGa1OND6DPNnZC5L7+JJ6zqVKAkpZqejr6 jcMTn863Z3lysgHdHp0oqundtIzqjB+y2tbbDUXjva1iWFmhMrUicqD65oDBtx9hxhLvVdXmMZJ tnCK7Pm73k7EYtKzyqepcue3tgORqcArvbTSiMiRwjqMD+1E8nWQIfPB4+foxdceEcfU6ldzx1Q Q51aDH5JBiHIE0CQaFvqDkUiEPC+e7M5k3MsL7ZOTyiCYonLxP0PqpmZolYnKjlryIVIMJCGcix niqBcK/SXSuiIH7J+gbOm3Nd2 X-Received: by 2002:ac8:5d8e:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-525fb957e1cmr8865161cf.11.1784558515472; Mon, 20 Jul 2026 07:41:55 -0700 (PDT) X-Received: by 2002:ac8:5d8e:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-525fb957e1cmr8864731cf.11.1784558514897; Mon, 20 Jul 2026 07:41:54 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1734b1918asm466578066b.43.2026.07.20.07.41.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 07:41:54 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 16:41:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] dt-bindings: phy: qcom,qmp-usb3-dp: Extend X1E description for USB4 To: Konrad Dybcio , Vinod Koul , Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, usb4-upstream@oss.qualcomm.com, Raghavendra Thoorpu , Mika Westerberg , Sven Peter References: <20260518-topic-usb4phy-v1-0-71d827c49dca@oss.qualcomm.com> <20260518-topic-usb4phy-v1-1-71d827c49dca@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260518-topic-usb4phy-v1-1-71d827c49dca@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: PhJbZaMm-HL9F3bibQgKdvkVjNRgzoMF X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIwMDE2MyBTYWx0ZWRfXwSutPxsVeraI Q8UrBExa0+kQaKRZ6Gof5ejzK7dmZxsUasdUm3oWec4LwJd7u4/E1vOosfRninMBdWF9jXI9Dlc FrLyduIefcrSBsXB6dGYi9+A/60KgBreYS5udVxU5eaaDwQVmoeVBGnBAMjOY5020Gqm/wWoWhl QRDe6Eh1VvvtVfCvKYu4Nlu+MQ/NoXBC3QIQQwy9L5a8w8ZaGY0rEIJCTL6mU7jNNvcTbpCDPE0 WR+S59rAE5Fw1Nuh3ykO5f6HsRJeHnXe17bSZCFwPTz0y0wcOKXUi/6DGAFcpqmhgHBFZ23NApW ASkmnrKCZnXTxb2vC4WMF6jj22BjeBrgwBLH8FnShW3PlXqhjqOJOmZcsExoYaIQW91F6VFE9qO o2hsoZRZiu8hx2dRwGzzObsOnQTBLmNdLzFQtYizhXmXEcTleDmmzITTOdEbZfEP+0KhNsD2L0j h19i/Fc01izdhSyudMg== X-Authority-Analysis: v=2.4 cv=RPmD2Yi+ c=1 sm=1 tr=0 ts=6a5e33b4 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=u94BZUI0yVsv4lWrxd4A:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: PhJbZaMm-HL9F3bibQgKdvkVjNRgzoMF X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIwMDE2MyBTYWx0ZWRfX5gGe8CMqrTc7 G1Fx+vu5k04oh+iBrXRPec76yhz38mfthZlQOJXX6Idxd/Qv5b2tb6LBZVM9M13wKrV9qlTdcq1 Utqt7gqF0bXyDCiHusB1pNQYE+BZh7c= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_03,2026-07-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 bulkscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607200163 On 5/18/26 12:29 PM, Konrad Dybcio wrote: > From: Konrad Dybcio > > Some instances of the QMP combo PHY (called USB43DP) feature a third > functional sub-block, responsible for USB4/Thunderbolt 3 communication. > > Compared to the today's state of the binding, one more clock (P2RR2P - > PHY-to-Router, Router-to-PHY) needs to be enabled for the PHY to be > able to switch to USB4 mode. Allow that for X1E. > > Also, add a bindings define to let consumers access it. > > Signed-off-by: Konrad Dybcio > --- It's been a while and I see Vinod is picking up patches. Krzysztof, could you please take a look at this binding change? Konrad > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 3 ++- > include/dt-bindings/phy/phy-qcom-qmp.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml > index 3d537b7f9985..eba4bee474fb 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml > @@ -52,7 +52,7 @@ properties: > - const: ref > - const: com_aux > - const: usb3_pipe > - - const: cfg_ahb > + - enum: [ p2rr2p_pipe, cfg_ahb ] > > power-domains: > maxItems: 1 > @@ -186,6 +186,7 @@ allOf: > enum: > - qcom,sc7180-qmp-usb3-dp-phy > - qcom,sdm845-qmp-usb3-dp-phy > + - qcom,x1e80100-qmp-usb3-dp-phy > then: > properties: > clocks: > diff --git a/include/dt-bindings/phy/phy-qcom-qmp.h b/include/dt-bindings/phy/phy-qcom-qmp.h > index 6b43ea9e0051..1c3ce0c02b0c 100644 > --- a/include/dt-bindings/phy/phy-qcom-qmp.h > +++ b/include/dt-bindings/phy/phy-qcom-qmp.h > @@ -16,6 +16,7 @@ > /* QMP USB4-USB3-DP PHYs */ > #define QMP_USB43DP_USB3_PHY 0 > #define QMP_USB43DP_DP_PHY 1 > +#define QMP_USB43DP_USB4_PHY 2 > > /* QMP PCIE PHYs */ > #define QMP_PCIE_PIPE_CLK 0 >