From: Danilo Krummrich <dakr@kernel.org>
To: Seyediman Seyedarab <imandevel@gmail.com>
Cc: lyude@redhat.com, airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/nouveau: replace snprintf() with scnprintf() in nvkm_snprintbf()
Date: Sat, 9 Aug 2025 14:00:19 +0200 [thread overview]
Message-ID: <a0e84862-858e-44cf-aadd-31bc6b3fec08@kernel.org> (raw)
In-Reply-To: <20250724195913.60742-1-ImanDevel@gmail.com>
On 7/24/25 9:59 PM, Seyediman Seyedarab wrote:
> snprintf() returns the number of characters that *would* have been
> written, which can overestimate how much you actually wrote to the
> buffer in case of truncation. That leads to 'data += this' advancing
> the pointer past the end of the buffer and size going negative.
>
> Switching to scnprintf() prevents potential buffer overflows and ensures
> consistent behavior when building the output string.
>
> Signed-off-by: Seyediman Seyedarab <ImanDevel@gmail.com>
Applied to drm-misc-next, thanks!
prev parent reply other threads:[~2025-08-09 12:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 19:59 Seyediman Seyedarab
2025-08-02 21:24 ` Seyediman Seyedarab
2025-08-09 12:00 ` Danilo Krummrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0e84862-858e-44cf-aadd-31bc6b3fec08@kernel.org \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imandevel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®