From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8EC7C76194 for ; Thu, 25 Jul 2019 13:50:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CA7922BEF for ; Thu, 25 Jul 2019 13:50:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728939AbfGYNui (ORCPT ); Thu, 25 Jul 2019 09:50:38 -0400 Received: from smtprelay0111.hostedemail.com ([216.40.44.111]:41359 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726666AbfGYNui (ORCPT ); Thu, 25 Jul 2019 09:50:38 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id E46BC182CF66A; Thu, 25 Jul 2019 13:50:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: table00_5c89d2adde534 X-Filterd-Recvd-Size: 2562 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf05.hostedemail.com (Postfix) with ESMTPA; Thu, 25 Jul 2019 13:50:35 +0000 (UTC) Message-ID: Subject: Re: [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] From: Joe Perches To: Julia Lawall Cc: David Laight , cocci , LKML Date: Thu, 25 Jul 2019 06:50:34 -0700 In-Reply-To: References: <7ab8957eaf9b0931a59eff6e2bd8c5169f2f6c41.1563841972.git.joe@perches.com> <66fcdbf607d7d0bea41edb39e5579d63b62b7d84.camel@perches.com> <0f3ba090dfc956f5651e6c7c430abdba94ddcb8b.camel@perches.com> <563222fbfdbb44daa98078db9d404972@AcuMS.aculab.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-07-24 at 20:42 -0500, Julia Lawall wrote: > New version. I check for non-use of the return value of strlcpy and > address some issues that affected the matching of the case where the first > argument involves a pointer dereference. Actually, an isomorphism now > takes care of that case, so it doesn't show up in the semantic patch > explicitly any more. > > julia Nice x 2, thanks again. More comments: @@ identifier f,i2,i1; struct i1 e1; expression e2; local idexpression x; position r.p; @@ ( -x = strlcpy +stracpy (e1.f, e2 - , i2 )@p; ... when != x Just for completeness and correctness, as I at least don't find an existing use: Perhaps this "x =" should also include += and + and the various other operators that are possible or does SmPL grammar already do that? Also, it might be nice to include the trivial conversion with sizeof(e1) and ARRAY_SIZE(e1) so a single script could be run over the kernel. I'll see about adding that and try it myself so an automated conversion should be possible.