From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: add static to !OF stub
Date: Tue, 14 Mar 2023 21:12:50 +0100 [thread overview]
Message-ID: <a0ec54c2-b11e-5f4b-eb0e-ab9a8e71b02c@linaro.org> (raw)
In-Reply-To: <CAPDyKFqaq5ysudyqOe0dB8fm=+p_ywpXdqQr33QUCq3j+Bqnrw@mail.gmail.com>
On 13/03/2023 13:49, Ulf Hansson wrote:
> On Sat, 11 Mar 2023 at 12:12, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> The sdhci_get_compatibility() is not used outside of the unit:
>>
>> drivers/mmc/host/sdhci-pltfm.c:76:6: error: no previous prototype for ‘sdhci_get_compatibility’ [-Werror=missing-prototypes]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> drivers/mmc/host/sdhci-pltfm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>> index 328b132bbe57..245e56324dff 100644
>> --- a/drivers/mmc/host/sdhci-pltfm.c
>> +++ b/drivers/mmc/host/sdhci-pltfm.c
>> @@ -73,7 +73,7 @@ static void sdhci_get_compatibility(struct platform_device *pdev)
>> host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
>> }
>> #else
>> -void sdhci_get_compatibility(struct platform_device *pdev) {}
>> +static void sdhci_get_compatibility(struct platform_device *pdev) {}
>> #endif /* CONFIG_OF */
>
> sdhci_get_compatibility() is using OF functions with stubs for !OF.
>
> Perhaps a cleaner option is to drop the #ifdef CONFIG_OF completely
> around sdhci_get_compatibility(), thus we can drop the stub too.
Works, indeed, better idea. I'll send v2.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-03-14 20:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 11:12 Krzysztof Kozlowski
2023-03-13 12:49 ` Ulf Hansson
2023-03-14 20:12 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0ec54c2-b11e-5f4b-eb0e-ab9a8e71b02c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®