From: Randy Dunlap <rdunlap@infradead.org>
To: kernel test robot <lkp@intel.com>, Andrew Lunn <andrew@lunn.ch>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Rich Felker <dalias@libc.org>
Subject: Re: ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
Date: Sun, 30 May 2021 17:05:42 -0700 [thread overview]
Message-ID: <a0edf640-ec05-524e-9125-44decba27bbb@infradead.org> (raw)
In-Reply-To: <202105300736.7wVLvXHr-lkp@intel.com>
On 5/29/21 4:25 PM, kernel test robot wrote:
> Hi Andrew,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: df8c66c4cfb91f2372d138b9b714f6df6f506966
> commit: a9770eac511ad82390b9f4a3c1728e078c387ac7 net: mdio: Move MDIO drivers into a new subdirectory
> date: 9 months ago
> config: sh-allmodconfig (attached as .config)
> compiler: sh4-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a9770eac511ad82390b9f4a3c1728e078c387ac7
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout a9770eac511ad82390b9f4a3c1728e078c387ac7
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
>>> ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
Just a comment here. kernel test robot has reported this issue
5 times in 2021 that I know of -- and I could have missed some.
I see that Geert recently (June 2020) reverted the
EXPORT_SYMBOL(__delay) in arch/sh/lib/delay.c, with this comment:
__delay() is an internal implementation detail on several architectures.
Drivers should not call __delay() directly, as it has non-standardized
semantics, or may not even exist.
Hence there is no need to export __delay() to modules.
See also include/asm-generic/delay.h:
/* Undefined functions to get compile-time errors */
...
extern void __delay(unsigned long loops);
However, s/several architectures/all but one architecture: SH/.
All architectures except for SH provide either an exported function,
an inline function, or a macro for __delay(). Yeah, they probably
don't all do the same delay.
--
~Randy
next prev parent reply other threads:[~2021-05-31 0:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 23:25 kernel test robot
2021-05-31 0:05 ` Randy Dunlap [this message]
2021-05-31 1:13 ` Randy Dunlap
2021-05-31 7:36 ` Geert Uytterhoeven
2021-05-31 14:34 ` Randy Dunlap
2021-05-31 14:46 ` Andrew Lunn
2021-05-31 15:09 ` Geert Uytterhoeven
2021-05-31 7:29 ` Geert Uytterhoeven
2021-05-31 7:32 ` Geert Uytterhoeven
2021-05-31 15:12 ` Randy Dunlap
2021-05-31 15:45 ` Geert Uytterhoeven
2021-06-02 3:52 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2024-12-28 13:35 kernel test robot
2024-12-28 13:50 ` Geert Uytterhoeven
2024-12-28 13:55 ` Geert Uytterhoeven
2024-12-29 2:23 ` Philip Li
2024-07-26 0:38 kernel test robot
2024-07-26 7:26 ` Geert Uytterhoeven
2024-07-11 17:34 kernel test robot
2024-03-23 20:39 kernel test robot
2022-07-16 6:59 kernel test robot
2021-07-24 23:11 kernel test robot
2021-07-11 0:49 kernel test robot
2021-05-19 23:52 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0edf640-ec05-524e-9125-44decba27bbb@infradead.org \
--to=rdunlap@infradead.org \
--cc=andrew@lunn.ch \
--cc=dalias@libc.org \
--cc=geert+renesas@glider.be \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®