From: Paolo Abeni <pabeni@redhat.com>
To: Sai Krishna <saikrishnag@marvell.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sgoutham@marvell.com, gakula@marvell.com, lcherian@marvell.com,
jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com,
andrew+netdev@lunn.ch, kalesh-anakkur.purayil@broadcom.com
Subject: Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox operations and structures
Date: Thu, 20 Feb 2025 12:50:09 +0100 [thread overview]
Message-ID: <a0f4651c-31a3-4831-89a4-ee3010b3b4ca@redhat.com> (raw)
In-Reply-To: <20250217085257.173652-3-saikrishnag@marvell.com>
On 2/17/25 9:52 AM, Sai Krishna wrote:
> @@ -2443,6 +2469,18 @@ static int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw,
> }
> }
>
> + ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL);
> + if (!ng_rvu_mbox) {
> + err = -ENOMEM;
> + goto free_bitmap;
> + }
> +
> + rvu->ng_rvu = ng_rvu_mbox
AFAICS rvu->ng_rvu is freed only by rvu_remove(), so it's leaked on the
later error paths.
/P
next prev parent reply other threads:[~2025-02-20 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 8:52 [net-next PATCH v10 0/6] CN20K silicon with mbox support Sai Krishna
2025-02-17 8:52 ` [net-next PATCH v10 1/6] octeontx2: Set appropriate PF, VF masks and shifts based on silicon Sai Krishna
2025-02-17 8:52 ` [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox operations and structures Sai Krishna
2025-02-20 11:50 ` Paolo Abeni [this message]
2025-02-25 6:05 ` Sai Krishna Gajula
2025-02-17 8:52 ` [net-next PATCH v10 3/6] octeontx2-af: CN20k mbox to support AF REQ/ACK functionality Sai Krishna
2025-02-20 11:59 ` Paolo Abeni
2025-02-25 6:12 ` Sai Krishna Gajula
2025-02-17 8:52 ` [net-next PATCH v10 4/6] octeontx2-pf: CN20K mbox REQ/ACK implementation for NIC PF Sai Krishna
2025-02-17 8:52 ` [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox implementation for AF's VF Sai Krishna
2025-02-20 12:06 ` Paolo Abeni
2025-02-23 14:40 ` Sai Krishna Gajula
2025-02-17 8:52 ` [net-next PATCH v10 6/6] octeontx2-pf: CN20K mbox implementation between PF-VF Sai Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0f4651c-31a3-4831-89a4-ee3010b3b4ca@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saikrishnag@marvell.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®