From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58DD5372B54 for ; Tue, 17 Feb 2026 18:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771353954; cv=none; b=Z1OKb4TkrJM3sO9uiHkj0MJKzSiarxU/3eW/Dumyxrw/f2Eikbk3tYXC2DGnIJr4pECFQuivPn5PVJgVibDGFV2NNIoq1FiSGJ/swRgqCMow320v71Q27Xj28ef2zC3mFO47zpHnUdzs4a5H6dZZilio0bP+5yBhoZlWXEXGsrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771353954; c=relaxed/simple; bh=ORWEn33cr8TezltWTg7HhteV+K8N7yMVo8rWvGI/V38=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Y3I9Bv6Z6yijGUWkeNNPgoZxLrBhKdcLZjS4Onc00m/jKhnzviuYAAyM+oZrF1X1MYdmow7aF5m9x05jxRtFF9PX2sv8si5rP07hknfvIUV2cnABLg81b1UVRiezVNh0IKVKXf2QV01o3bdaCnKXrOFMaaaGz43ZbusEV2vu0pM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fzhkq4U4; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fzhkq4U4" Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-8cb39647a70so463243985a.0 for ; Tue, 17 Feb 2026 10:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771353952; x=1771958752; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9A3D21adMciyC71cYHrKoVOKLOG80kizDTsQCYR5dlk=; b=Fzhkq4U4345JJH3lEtbC8BILX3PobhYlJ2eLutY6PDp1Sz2c1Z2olHmK5tSlSoe1vV m9Rw6E5iqvk3vsFUZVohuqDsPZOD04NRjiPuB6KpzuwmQuPXbesBCZjMm8PkJUGo7G4j Pfg6UhmareZE6JrNmjqWplIT329CmUurZ8MlerEHQGUSaeBZ5GS3S6yCF0Qy8y77cmuc UwdDSTlp22nsV36E3ex3svos7KTXXV4p4j3UVZLHaKRHSF+mnSmvOlQHS+FV5a9E41uA bRlnDhzVLCHLYOKqH4owx/foDym8RotCS2/YZ8CUJbhoLcZkpsnulTMHXgMJ5B5Xhdqi sJ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771353952; x=1771958752; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9A3D21adMciyC71cYHrKoVOKLOG80kizDTsQCYR5dlk=; b=mkM1+kYZ6boUdReZOFiglkL4oGo/JKCtk4lB/mQ6Fd0WK2yu4J4qBcujGCxuN+5CtW +f4RR3TULZojUX2IekV+u6JU8TYSVB/6xNb6H7qebAtcqK5ECCywlgUtnwRKN1bbBXQV CoT0HI8eQGl52g1D9B9riikwc4ZC5MF11olUBmRHPPUax3ZzM/SPPLzvBpnYYSjyNeuk v66OZkjeXuXWf32qIzvLmbpwLhkPo0muluRrG9szq9XP3craMisv0a6r1iYpAxekTbUO 3dU7Wv3Cz/U7qfoXv72HRDRXRmxyrjECoRUiEM6gKbcSEQqUUEh0tOko8XV8lPp3LeFd Da2Q== X-Forwarded-Encrypted: i=1; AJvYcCUOm7xrjfBNYxbgCROlcdnuRIBSrcwZutZvSQpm3Us7P8KhAtG4WDyxPMmOSLrXLaovLwDTGiA0TkrPsHc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0wVCAsga9+mGqAEmFmAeRm5leBNiK2uB3sAj3IVE8HTSG7rvy tFJccZEu8PegA3n5VqWXh8gcdOWXsa44H/XboJ06a6c6f/y4h1ugjkMY X-Gm-Gg: AZuq6aJnWuzFjAIGLWPUwBAxyMNxY/PHGtZMxtTIUQX3Ny6Za58pjf47J2gPlhjR0wZ Vk8VQKhinQ+aM8j48jsgzJkRYyfAF8/cZ2XRn4o4GK3uJo26gjmlYpzeZKFz8HT/gLhkgNVZNMw Rv+0YECcO5eQ3nuyYg9OyiiVCrD+UKPmkdVkcuW+9y4VaezWKmEvXBJ6k8A4qpPGQjU3Xp7gPnd VqfCUBMlrBMAm0H/aOExzOywivCQvs8Vk8XWUfeXWmTaLlvRPUw3LcKWTKNG+vCua18ghDFo1vB Ei3MAqF6Z1F/k5BSwfAaBoRe1OcBmc3d28fseo+4Qp3yxrb+hFNDI2PmnorSwF2JxwIoqhne4P0 LgxwxO1A7oQ2GnrxItqf3sYvDTLcg6hA6a0MXl/lz4xkvc0VJdhUWo9nzF7Hf/OfApO6snahY4j nhyBJMslSRx/aV2ZQgwkZMalqTpfR7Jgo5M1XKiez2pwra2NxyJ4JdwdVivTHudWc= X-Received: by 2002:a05:620a:4809:b0:8c7:1b3c:8e8 with SMTP id af79cd13be357-8cb4bfb97c0mr1463999185a.40.1771353952153; Tue, 17 Feb 2026 10:45:52 -0800 (PST) Received: from ?IPV6:2a03:83e0:1145:4:15c9:280a:146e:89e4? ([2620:10d:c091:500::5aa8]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8971cc7f540sm167126456d6.5.2026.02.17.10.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 10:45:51 -0800 (PST) Message-ID: Date: Tue, 17 Feb 2026 13:45:50 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net: psp: select CONFIG_SKB_EXTENSIONS To: Arnd Bergmann , Jakub Kicinski , Willem de Bruijn , "David S. Miller" , Eric Dumazet , Paolo Abeni Cc: Arnd Bergmann , Simon Horman , Geert Uytterhoeven , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260216105500.2382181-1-arnd@kernel.org> Content-Language: en-US From: Daniel Zahka In-Reply-To: <20260216105500.2382181-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/16/26 5:54 AM, Arnd Bergmann wrote: > From: Arnd Bergmann > > psp now uses skb extensions, failing to build when that is disabled: > > In file included from include/net/psp.h:7, > from net/psp/psp_sock.c:9: > include/net/psp/functions.h: In function '__psp_skb_coalesce_diff': > include/net/psp/functions.h:60:13: error: implicit declaration of function 'skb_ext_find'; did you mean 'skb_ext_copy'? [-Wimplicit-function-declaration] > 60 | a = skb_ext_find(one, SKB_EXT_PSP); > | ^~~~~~~~~~~~ > | skb_ext_copy > include/net/psp/functions.h:60:31: error: 'SKB_EXT_PSP' undeclared (first use in this function) > 60 | a = skb_ext_find(one, SKB_EXT_PSP); > | ^~~~~~~~~~~ > include/net/psp/functions.h:60:31: note: each undeclared identifier is reported only once for each function it appears in > include/net/psp/functions.h: In function '__psp_sk_rx_policy_check': > include/net/psp/functions.h:94:53: error: 'SKB_EXT_PSP' undeclared (first use in this function) > 94 | struct psp_skb_ext *pse = skb_ext_find(skb, SKB_EXT_PSP); > | ^~~~~~~~~~~ > net/psp/psp_sock.c: In function 'psp_sock_recv_queue_check': > net/psp/psp_sock.c:164:41: error: 'SKB_EXT_PSP' undeclared (first use in this function) > 164 | pse = skb_ext_find(skb, SKB_EXT_PSP); > | ^~~~~~~~~~~ > > Select the Kconfig symbol as we do from its other users. > > Fixes: 6b46ca260e22 ("net: psp: add socket security association code") > Signed-off-by: Arnd Bergmann > --- > net/psp/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/psp/Kconfig b/net/psp/Kconfig > index 371e8771f3bd..84d6b0f25460 100644 > --- a/net/psp/Kconfig > +++ b/net/psp/Kconfig > @@ -6,6 +6,7 @@ config INET_PSP > bool "PSP Security Protocol support" > depends on INET > select SKB_DECRYPTED > + select SKB_EXTENSIONS > select SOCK_VALIDATE_XMIT > help > Enable kernel support for the PSP Security Protocol (PSP). Indeed that is and has always been a mandatory config dependency for psp. Reviewed-by: Daniel Zahka