From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755721AbdBQJka (ORCPT ); Fri, 17 Feb 2017 04:40:30 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:35014 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755502AbdBQJk0 (ORCPT ); Fri, 17 Feb 2017 04:40:26 -0500 Subject: Re: [PATCH] KVM: race-free exit from KVM_RUN without POSIX signals To: David Hildenbrand , linux-kernel@vger.kernel.org, kvm@vger.kernel.org References: <1487169821-14806-1-git-send-email-pbonzini@redhat.com> <8a0f0818-07eb-c33e-9488-5a69c6bb67b1@redhat.com> Cc: james.hogan@imgtec.com, marc.zyngier@arm.com, kvm-ppc@vger.kernel.org, borntraeger@de.ibm.com, paulus@samba.org, cornelia.huck@de.ibm.com, kvmarm@lists.cs.columbia.edu From: Paolo Bonzini Message-ID: Date: Fri, 17 Feb 2017 10:40:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <8a0f0818-07eb-c33e-9488-5a69c6bb67b1@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/2017 20:26, David Hildenbrand wrote: > As mentioned already on IRC, maybe something like "block_vcpu_run" would > fit better now. Hmm, the purpose of the flag is cause an immediate exit and it does do so... Surely incorrect (or just uncommon) usage will prevent a VCPU from running, but that is just a side effect of the semantics, not the intended usage. Paolo > But this is also ok and looks good to me. > > Reviewed-by: David Hildenbrand