From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC34C5519F for ; Wed, 25 Nov 2020 03:35:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A39892087C for ; Wed, 25 Nov 2020 03:35:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727363AbgKYDf5 (ORCPT ); Tue, 24 Nov 2020 22:35:57 -0500 Received: from mail.loongson.cn ([114.242.206.163]:35476 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725776AbgKYDf5 (ORCPT ); Tue, 24 Nov 2020 22:35:57 -0500 Received: from linux.localdomain (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxKtAV0b1fR1kWAA--.36754S2; Wed, 25 Nov 2020 11:35:49 +0800 (CST) From: Tiezhu Yang To: Andrew Morton , Andy Whitcroft , Joe Perches Cc: linux-kernel@vger.kernel.org, Xuefeng Li Subject: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit Date: Wed, 25 Nov 2020 11:35:47 +0800 Message-Id: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf9AxKtAV0b1fR1kWAA--.36754S2 X-Coremail-Antispam: 1UD129KBjvJXoW7CF1xurW5Cw47Gr47CrykXwb_yoW8tr4xpa 1DW34FqrWrGF1UJanrG340qayYgws5Xr1I9ryDuF12vFyUKFn2qr9avr1fZr17AFyF9aya qa1rC3sag3W0kFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkG14x267AKxVWUJVW8JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26F1j6w1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r xl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7MxkIecxEwVAFwVW8 GwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r 1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij 64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr 0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v26r1j6r4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JU5pnQUUU UU= X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When backport the upstream commit to the internal LTS kernel version, we usually use the following description [1] [2]: [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] or commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. We use checkpatch.pl before auto build and there exists auto build failure due to the following checkpatch error: ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit cc6528bc9a0c ("r8169: fix potential skb double free in an error path")' #6: [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] or ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit c51f8f88d705 ("random32: make prandom_u32() output unpredictable")' #6: commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. We can use "--ignore GIT_COMMIT_ID" to avoid this checkpatch error, but I think it is better to modify the check rule of checkpatch. When there exists "Upstream" or "upstream" in the commit line, it seems no need to do more check. [1] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.19.y&id=bc571404829755e4a9504cc5fbc636fea80b2d83 [2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-4.19.y&id=81d7c56d6fab5ccbf522c47a655cd427808679f2 Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> --- RESEND to Andrew Morton <akpm@linux-foundation.org> scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index fab38b4..f5bbfdd 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2889,7 +2889,8 @@ sub process { ($line =~ /\bcommit\s+[0-9a-f]{5,}\b/i || ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i && $line !~ /[\<\[][0-9a-f]{12,40}[\>\]]/i && - $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i))) { + $line !~ /\bfixes:\s*[0-9a-f]{12,40}/i)) && + $line !~ /^\s*Upstream|upstream/i) { my $init_char = "c"; my $orig_commit = ""; my $short = 1; -- 2.1.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-kernel-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB098C5519F for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 03:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BC4520665 for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 03:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727781AbgKYDvv (ORCPT <rfc822;linux-kernel@archiver.kernel.org>); Tue, 24 Nov 2020 22:51:51 -0500 Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:45732 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727724AbgKYDvv (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Nov 2020 22:51:51 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay02.hostedemail.com (Postfix) with ESMTP id 803531730878; Wed, 25 Nov 2020 03:51:50 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: back08_1203d1127373 X-Filterd-Recvd-Size: 1469 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf15.hostedemail.com (Postfix) with ESMTPA; Wed, 25 Nov 2020 03:51:49 +0000 (UTC) Message-ID: <dddb87a6ffb94b6b8046eb2eca1480a7ca37f962.camel@perches.com> Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit From: Joe Perches <joe@perches.com> To: Tiezhu Yang <yangtiezhu@loongson.cn>, Andrew Morton <akpm@linux-foundation.org>, Andy Whitcroft <apw@canonical.com> Cc: linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn> Date: Tue, 24 Nov 2020 19:51:48 -0800 In-Reply-To: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> References: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: > When backport the upstream commit to the internal LTS kernel version, > we usually use the following description [1] [2]: > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] > or > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. Internal to what? If it's your own internal build system, I think you should keep your own local patch to checkpatch. I don't see why the kernel version should accept it. Is this style used by anyone else? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-kernel-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A85CAC5519F for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 04:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 520F520789 for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 04:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbgKYEIM (ORCPT <rfc822;linux-kernel@archiver.kernel.org>); Tue, 24 Nov 2020 23:08:12 -0500 Received: from mail.loongson.cn ([114.242.206.163]:42430 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726533AbgKYEIM (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Nov 2020 23:08:12 -0500 Received: from [10.130.0.80] (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9AxutCk2L1foFwWAA--.36614S3; Wed, 25 Nov 2020 12:08:05 +0800 (CST) Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit To: Joe Perches <joe@perches.com>, Andrew Morton <akpm@linux-foundation.org>, Andy Whitcroft <apw@canonical.com> References: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> <dddb87a6ffb94b6b8046eb2eca1480a7ca37f962.camel@perches.com> Cc: linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn> From: Tiezhu Yang <yangtiezhu@loongson.cn> Message-ID: <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> Date: Wed, 25 Nov 2020 12:08:04 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <dddb87a6ffb94b6b8046eb2eca1480a7ca37f962.camel@perches.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf9AxutCk2L1foFwWAA--.36614S3 X-Coremail-Antispam: 1UD129KBjvdXoWrtF47GrW3GF48uFyrWrWrGrg_yoW3ZFgEqr 4kWrWkC3ykZr1qy3ZYqr4Y9FyUKayDt3W8Jr4fA3y7Ar98XFZ8JFZ3WasYvas7Ars5uFyv kF4jv3s3Kr4avjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbfkFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_ Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VAC jcxG62k0Y48FwI0_Jr0_Gr1lYx0E2Ix0cI8IcVAFwI0_JF0_Jw1lYx0Ex4A2jsIE14v26r 4j6F4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I 648v4I1lc7I2V7IY0VAS07AlzVAYIcxG8wCY02Avz4vE14v_Gryl42xK82IYc2Ij64vIr4 1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK 67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI 8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAv wI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I 0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTRRYL9UUUUU X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2020 11:51 AM, Joe Perches wrote: > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: >> When backport the upstream commit to the internal LTS kernel version, >> we usually use the following description [1] [2]: >> >> [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] >> or >> commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. > Internal to what? > > If it's your own internal build system, I think you should > keep your own local patch to checkpatch. > > I don't see why the kernel version should accept it. > > Is this style used by anyone else? AFAIK, this style is only used in the stable tree, for example: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-kernel-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0258C5519F for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 04:22:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65187208CA for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 04:22:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727986AbgKYEW2 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>); Tue, 24 Nov 2020 23:22:28 -0500 Received: from smtprelay0203.hostedemail.com ([216.40.44.203]:51700 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727957AbgKYEW2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Nov 2020 23:22:28 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 1456A18009120; Wed, 25 Nov 2020 04:22:27 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: suit87_350b63c27373 X-Filterd-Recvd-Size: 2027 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA; Wed, 25 Nov 2020 04:22:25 +0000 (UTC) Message-ID: <a60a7b08ce9dde0452577e4bc556cd6217bbc916.camel@perches.com> Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit From: Joe Perches <joe@perches.com> To: Tiezhu Yang <yangtiezhu@loongson.cn>, Andrew Morton <akpm@linux-foundation.org>, Andy Whitcroft <apw@canonical.com>, Greg KH <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org> Cc: linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn> Date: Tue, 24 Nov 2020 20:22:24 -0800 In-Reply-To: <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> References: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> <dddb87a6ffb94b6b8046eb2eca1480a7ca37f962.camel@perches.com> <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote: > On 11/25/2020 11:51 AM, Joe Perches wrote: > > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: > > > When backport the upstream commit to the internal LTS kernel version, > > > we usually use the following description [1] [2]: > > > > > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] > > > or > > > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. > > Internal to what? > > > > If it's your own internal build system, I think you should > > keep your own local patch to checkpatch. > > > > I don't see why the kernel version should accept it. > > > > Is this style used by anyone else? > > AFAIK, this style is only used in the stable tree, for example: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-kernel-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68CAC5519F for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 04:24:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5914520B80 for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 04:24:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727554AbgKYEYT (ORCPT <rfc822;linux-kernel@archiver.kernel.org>); Tue, 24 Nov 2020 23:24:19 -0500 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:39332 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726330AbgKYEYT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Nov 2020 23:24:19 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id EE9FC180A8CBE; Wed, 25 Nov 2020 04:24:17 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: death67_3d0c23b27373 X-Filterd-Recvd-Size: 2226 Received: from XPS-9350.home (unknown [47.151.128.180]) (Authenticated sender: joe@perches.com) by omf17.hostedemail.com (Postfix) with ESMTPA; Wed, 25 Nov 2020 04:24:16 +0000 (UTC) Message-ID: <a102bb51a8ebde2e22d9527fb00a2c1f64c6e69f.camel@perches.com> Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit From: Joe Perches <joe@perches.com> To: Tiezhu Yang <yangtiezhu@loongson.cn>, Andrew Morton <akpm@linux-foundation.org>, Andy Whitcroft <apw@canonical.com>, Greg KH <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org> Cc: linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn> Date: Tue, 24 Nov 2020 20:24:15 -0800 In-Reply-To: <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> References: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> <dddb87a6ffb94b6b8046eb2eca1480a7ca37f962.camel@perches.com> <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote: > On 11/25/2020 11:51 AM, Joe Perches wrote: > > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: > > > When backport the upstream commit to the internal LTS kernel version, > > > we usually use the following description [1] [2]: > > > > > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] > > > or > > > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. > > Internal to what? > > > > If it's your own internal build system, I think you should > > keep your own local patch to checkpatch. > > > > I don't see why the kernel version should accept it. > > > > Is this style used by anyone else? > > AFAIK, this style is only used in the stable tree, for example: > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7 Greg?/Sasha? https://lore.kernel.org/lkml/995e0acb-c219-ea00-f078-7582516e25de@loongson.cn/T/#m2f3d87bd985bf3d4d7b63f1fa4f0490baa01119b Is this in your scripts? Is this something you want/use? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <linux-kernel-owner@kernel.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD343C63777 for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 07:16:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B73920DD4 for <linux-kernel@archiver.kernel.org>; Wed, 25 Nov 2020 07:16:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WofC9uB4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727758AbgKYHQy (ORCPT <rfc822;linux-kernel@archiver.kernel.org>); Wed, 25 Nov 2020 02:16:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:47450 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725306AbgKYHQy (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 25 Nov 2020 02:16:54 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61925208B8; Wed, 25 Nov 2020 07:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1606288606; bh=gUkyGSpZPzozZHqhwoqFTigIg2G04BKThv9/K6m/Mhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WofC9uB4axUAU+F4T3jQi1jeNLbCInez1DEgfDag10sFVJl5/HEtUwZZQInKZbobo eAoOmQyS5UPL+Mz2kwXqMKuOth+Km5W481wazbrcMChouMXxww/lhO5kgSPEGLxa6U zGFvfebJ34BivXSwv1sMuXVr7+84G3U/6IIHBqYE= Date: Wed, 25 Nov 2020 08:17:52 +0100 From: Greg KH <gregkh@linuxfoundation.org> To: Joe Perches <joe@perches.com> Cc: Tiezhu Yang <yangtiezhu@loongson.cn>, Andrew Morton <akpm@linux-foundation.org>, Andy Whitcroft <apw@canonical.com>, Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn> Subject: Re: [PATCH RESEND] checkpatch: Do not check git commit description style when backport the upstream commit Message-ID: <X74FIJqhOgRrEGYv@kroah.com> References: <1606275347-19297-1-git-send-email-yangtiezhu@loongson.cn> <dddb87a6ffb94b6b8046eb2eca1480a7ca37f962.camel@perches.com> <995e0acb-c219-ea00-f078-7582516e25de@loongson.cn> <a102bb51a8ebde2e22d9527fb00a2c1f64c6e69f.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <a102bb51a8ebde2e22d9527fb00a2c1f64c6e69f.camel@perches.com> Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 24, 2020 at 08:24:15PM -0800, Joe Perches wrote: > On Wed, 2020-11-25 at 12:08 +0800, Tiezhu Yang wrote: > > On 11/25/2020 11:51 AM, Joe Perches wrote: > > > On Wed, 2020-11-25 at 11:35 +0800, Tiezhu Yang wrote: > > > > When backport the upstream commit to the internal LTS kernel version, > > > > we usually use the following description [1] [2]: > > > > > > > > [ Upstream commit cc6528bc9a0c901c83b8220a2e2617f3354d6dd9 ] > > > > or > > > > commit c51f8f88d705e06bd696d7510aff22b33eb8e638 upstream. > > > Internal to what? > > > > > > If it's your own internal build system, I think you should > > > keep your own local patch to checkpatch. > > > > > > I don't see why the kernel version should accept it. > > > > > > Is this style used by anyone else? > > > > AFAIK, this style is only used in the stable tree, for example: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=linux-5.9.y&id=c68a9ca7ca33f1020cca97e4e935c2154bec37c7 > > Greg?/Sasha? > > https://lore.kernel.org/lkml/995e0acb-c219-ea00-f078-7582516e25de@loongson.cn/T/#m2f3d87bd985bf3d4d7b63f1fa4f0490baa01119b > > Is this in your scripts? My scripts put this into a patch when applying it to the stable tree, and so do Sasha's. I don't know why checkpatch would care about this as that's not used for this workflow at all. > Is this something you want/use? I wouldn't use it, and I doubt anyone else would. thanks, greg k-h