From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E67C001DB for ; Sat, 5 Aug 2023 21:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbjHEVrO (ORCPT ); Sat, 5 Aug 2023 17:47:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbjHEVrM (ORCPT ); Sat, 5 Aug 2023 17:47:12 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 905901BCA; Sat, 5 Aug 2023 14:47:11 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 40C3B5C005C; Sat, 5 Aug 2023 17:47:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 05 Aug 2023 17:47:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dustymabe.com; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm1; t=1691272028; x=1691358428; bh=PDZaMOIU4UarYbs6ckRvGTabK al4sIaEiC324VR5DDQ=; b=Crr8G8ou9IOsrquDkzJgJjxC4v9hdtkyHX0m6QXX3 XjfggUJFzOqBY7mJAbL9XfM4jPftOKLdgdc5fjn+PNus4dWfBOu55T/35xXyGl0A A8TvbW0oSfyaY9OL+cvCENBFwfdc/8ZKNRNbsgy8KaYVXUeoNteKHZoS25K62Sbi KEUQAkNPv6CsvvzCGmY8DJXuHVuh2+8TjLX+P0MWf3mFREfdvDpm0wSbzZfwGLCF HLmIMqzrqAgTGaqRATot8sd/An+8OluHf3+/50YxWKILx815kEZgNi3CmOFsWeeg 85BuIsr2LL+GcmcEMu+7I3DbvlK5YUNUvX0MKapTU7uQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1691272028; x=1691358428; bh=PDZaMOIU4UarYbs6ckRvGTabKal4sIaEiC3 24VR5DDQ=; b=xZBsAFcWvRVAlrWM7IkitFjChkIiEdItEmMKO9HPKCJJuzwL7X1 hSk4ZxPj1GcjHeZZd4Rlq/ck7x5lB/iYkOmaQBz85bfAB9diplLjEpWkxTEanmWM FkLwGY3o3ezmjKmqIRXxvyPfvOh7A3inxbx8RYmzina0F4HnJQOsTDgvLrXV6hxb P02sVJ0edeW14yZoI7e8ZuEQD4iLe6ct/4l2842WLpCb+fgoCnpSKLJrLLUa9RNS 3ZI9Srf+D24meFlt5isRw63XfbffcQl24onUBNq5Pocke4s3uM+fvVwUWhFfkG8B 71Pjmj2vRLOamQ5aGpfy5kcIpKiswm1f9Xw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrkeejgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhushht hicuofgrsggvuceoughushhthiesughushhthihmrggsvgdrtghomheqnecuggftrfgrth htvghrnhepieffffeugfdthffgkeeftdektdetfefgveeuleeufeeugedvheetueelgfeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hushhthiesughushhthihmrggsvgdrtghomh X-ME-Proxy: Feedback-ID: i13394474:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 5 Aug 2023 17:47:07 -0400 (EDT) Message-ID: Date: Sat, 5 Aug 2023 17:47:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] zram: take device and not only bvec offset into account Content-Language: en-US To: Christoph Hellwig , Sergey Senozhatsky Cc: minchan@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230805055537.147835-1-hch@lst.de> <20230805074645.GA907732@google.com> <20230805081306.GA29615@lst.de> From: Dusty Mabe In-Reply-To: <20230805081306.GA29615@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/23 04:13, Christoph Hellwig wrote: > On Sat, Aug 05, 2023 at 04:46:45PM +0900, Sergey Senozhatsky wrote: >>> Fixes: af8b04c63708 ("zram: simplify bvec iteration in __zram_make_request") >>> Reported-by: Dusty Mabe >>> Signed-off-by: Christoph Hellwig >> >> Acked-by: Sergey Senozhatsky > > Btw, are there any interesting test suites you want me to run on > a > 4K page size system now that I do have this setup available? The patch is passing tests for me. I ran the Fedora CoreOS root reprovision tests (which are the tests that caught this bug to begin with) and the trivial reproducer: ``` #!/bin/bash set -eux -o pipefail modprobe zram num_devices=0 read dev < /sys/class/zram-control/hot_add echo 10G > /sys/block/zram"${dev}"/disksize mkfs.xfs /dev/zram"${dev}" mkdir -p /tmp/foo mount -t xfs /dev/zram"${dev}" /tmp/foo ``` Dusty