From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933563AbcHJSQy (ORCPT ); Wed, 10 Aug 2016 14:16:54 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:39376 "EHLO s-opensource.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933151AbcHJSQv (ORCPT ); Wed, 10 Aug 2016 14:16:51 -0400 Subject: Re: [PATCH v2] exynos-drm: Fix unsupported GEM memory type error message to be clear To: Shuah Khan , inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, airlied@linux.ie, kgene@kernel.org, k.kozlowski@samsung.com References: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Javier Martinez Canillas Message-ID: Date: Wed, 10 Aug 2016 13:37:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <1470700100-13306-1-git-send-email-shuahkh@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Shuah, On 08/08/2016 07:48 PM, Shuah Khan wrote: > Fix unsupported GEM memory type error message to include the memory type > information. > > Signed-off-by: Shuah Khan > --- > Changes since v1: > -- Comment changed to read clearly > > drivers/gpu/drm/exynos/exynos_drm_fb.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c > index e016640..40ce841 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c > @@ -55,11 +55,11 @@ static int check_fb_gem_memory_type(struct drm_device *drm_dev, > flags = exynos_gem->flags; > > /* > - * without iommu support, not support physically non-continuous memory > - * for framebuffer. > + * Physically non-contiguous memory type for framebuffer is not > + * supported without IOMMU. > */ > if (IS_NONCONTIG_BUFFER(flags)) { > - DRM_ERROR("cannot use this gem memory type for fb.\n"); > + DRM_ERROR("Non-contiguous GEM memory is not supported.\n"); > return -EINVAL; > } > > Patch looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America