mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
To: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Raviteja Laggyshetty <raviteja.laggyshetty@oss.qualcomm.com>,
	Imran Shaik <imran.shaik@oss.qualcomm.com>,
	Xueyao An <xueyao.an@oss.qualcomm.com>,
	Sneh Mankad <sneh.mankad@oss.qualcomm.com>,
	Monish Chunara <quic_mchunara@quicinc.com>,
	Komal Bajaj <komal.bajaj@oss.qualcomm.com>,
	Rakesh Kota <rakesh.kota@oss.qualcomm.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, bibek.patro@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: shikra: Mark RPM message RAM as no-memory-wc
Date: Fri, 20 Nov 2026 15:06:50 +0530	[thread overview]
Message-ID: <a116e2b0-8857-48c8-85f6-be3a62325515@oss.qualcomm.com> (raw)
In-Reply-To: <20261118125534.7iyzuefhz4te35st@hu-mojha-hyd.qualcomm.com>


On 18-11-2026 06:25 pm, Mukesh Ojha wrote:
> On Wed, Nov 18, 2026 at 04:35:55PM +0530, Vishnu Santhosh wrote:
>> On 17-11-2026 09:49 pm, Mukesh Ojha wrote:
>>> On Tue, Nov 17, 2026 at 01:35:50PM +0530, Vishnu Santhosh wrote:
>>>> The RPM message RAM is shared with other subsystems, and parts of it
>>>> are not accessible to the APSS. It is expected to be mapped as Device
>>>> memory.
>>>>
>>>> The "mmio-sram" compatible makes the SRAM driver map the region as
>>>> write-combined (Normal Non-cacheable) memory instead, which allows
>>>> speculative reads into the protected parts and results in XPU
>>>> violations.
>>>>
>>>> Add no-memory-wc so the region is mapped as Device memory.
>>>>
>>>> Fixes: 66664b5701da ("arm64: dts: qcom: Introduce Shikra SoC base dtsi")
>>>> Signed-off-by: Vishnu Santhosh <vishnu.santhosh@oss.qualcomm.com>
>>> Why only for Shikra ?
>> This XPU violation was seen only on Shikra, and only with Linux
>> running at EL2 (KVM). It is not seen on Shikra when Linux runs at
>> EL1 under Gunyah. So, I kept the change to Shikra.
> Thats not explained in this commit, why this issue not seen under
> Gunyah ?

Under Gunyah, Linux runs at EL1 and Gunyah maps this region as Device
memory at stage-2. The stricter stage-2 type applies, so the
write-combined mapping from the SRAM driver has no effect.

With KVM, Linux runs at EL2 (VHE) and there is no stage-2, so the
write-combined mapping takes effect and speculative reads reach the
protected regions.

The region is expected to be mapped non-write-combined regardless of
the exception level, so I kept the commit message to that. I can add
the EL2 detail in v2 if you prefer.

Vishnu

>
>

  reply	other threads:[~2026-11-20  9:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:05 Vishnu Santhosh
2026-11-17 16:19 ` Mukesh Ojha
2026-11-18 11:05   ` Vishnu Santhosh
2026-11-18 12:55     ` Mukesh Ojha
2026-11-20  9:36       ` Vishnu Santhosh [this message]
2026-11-20 10:26         ` Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a116e2b0-8857-48c8-85f6-be3a62325515@oss.qualcomm.com \
    --to=vishnu.santhosh@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bibek.patro@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imran.shaik@oss.qualcomm.com \
    --cc=komal.bajaj@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.ojha@oss.qualcomm.com \
    --cc=quic_mchunara@quicinc.com \
    --cc=rakesh.kota@oss.qualcomm.com \
    --cc=raviteja.laggyshetty@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sneh.mankad@oss.qualcomm.com \
    --cc=xueyao.an@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®