From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932110AbXGZH4R (ORCPT ); Thu, 26 Jul 2007 03:56:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757218AbXGZH4B (ORCPT ); Thu, 26 Jul 2007 03:56:01 -0400 Received: from an-out-0708.google.com ([209.85.132.249]:13401 "EHLO an-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756579AbXGZH4A (ORCPT ); Thu, 26 Jul 2007 03:56:00 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=RmvlCq0CQFk5pC1HY8PS6FGgsi/P/ouMBFJZa62/Zcln2/UoN2EGQ2oWCalIlWYAGUbIso/+PnYM9glwVXUQqB4UdpHif6EwdAWjOEJQhdsl7z3oROsheaVFMxhVcob5iMcaudKvbcOaA57mvG3gpCf2i28PV65y1ReRK0AujnY= Message-ID: Date: Thu, 26 Jul 2007 16:55:59 +0900 From: "Hiroshi Miura" To: "Andrew Morton" Subject: Re: [PATCH]gx-suspmod.c use boot_cpu_data instead of current_cpu_data Cc: "Dave Young" , "Dave Jones" , linux-kernel@vger.kernel.org, cpufreq@www.linux.org.uk In-Reply-To: <20070724234045.2cec5525.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070725141905.GA4567@darkstar.te-china.tietoenator.com> <20070724234045.2cec5525.akpm@linux-foundation.org> X-Google-Sender-Auth: 929e079fdaa5819f Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org 2007/7/25, Andrew Morton : > On Wed, 25 Jul 2007 14:19:05 +0000 Dave Young wrote: > > > Hi, > > in preemptible kernel will report BUG: using smp_processor_id() in preemptible, so use boot_cpu_data instead of current_cpu_data. > > > > Signed-off-by: Dave Young > > > > --- > > arch/i386/kernel/cpu/cpufreq/gx-suspmod.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff -pur linux/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c linux.new/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c > > --- linux/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c 2007-07-25 14:11:06.000000000 +0000 > > +++ linux.new/arch/i386/kernel/cpu/cpufreq/gx-suspmod.c 2007-07-25 13:57:29.000000000 +0000 > > @@ -181,8 +181,8 @@ static __init struct pci_dev *gx_detect_ > > struct pci_dev *gx_pci = NULL; > > > > /* check if CPU is a MediaGX or a Geode. */ > > - if ((current_cpu_data.x86_vendor != X86_VENDOR_NSC) && > > - (current_cpu_data.x86_vendor != X86_VENDOR_CYRIX)) { > > + if ((boot_cpu_data.x86_vendor != X86_VENDOR_NSC) && > > + (boot_cpu_data.x86_vendor != X86_VENDOR_CYRIX)) { > > dprintk("error: no MediaGX/Geode processor found!\n"); > > return NULL; > > } > > um, I suspect it really wants to get at the current CPU. But putting a > preempt_disable() around just that code is meaningless: the current CPU > could change immediately before or after the code block. It needs deeper > fixing, methinks. I think we can remove these part. It checks chipset 's pci id (vendor id/device id) after this part as follows; /* detect which companion chip is used */ while ((gx_pci = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, gx_pci)) != NULL) { if ((pci_match_id(gx_chipset_tbl, gx_pci)) != NULL) return gx_pci; } It drives cpu frequency through chipset register, not CPU regsiter. It may be enough to check chipset pci id. Hiroshi -- HIroshi Miura NTT DATA Corp. and IPA OSS center miura@da-cha.org （株）NTTデータ /（独）情報処理推進機構 三浦広志