mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sarthak Garg <quic_sartgarg@quicinc.com>
To: Neil Armstrong <neil.armstrong@linaro.org>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	Rob Herring <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>
Cc: <linux-mmc@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
	<quic_cang@quicinc.com>, <quic_nguyenb@quicinc.com>,
	<quic_rampraka@quicinc.com>, <quic_pragalla@quicinc.com>,
	<quic_sayalil@quicinc.com>, <quic_nitirawa@quicinc.com>,
	<quic_bhaskarv@quicinc.com>, <kernel@oss.qualcomm.com>
Subject: Re: [PATCH V4 4/4] arm64: dts: qcom: sm8550: Remove SDR104/SDR50 broken capabilities
Date: Wed, 20 Aug 2025 12:49:48 +0530	[thread overview]
Message-ID: <a1252539-d35f-443b-9e0a-3316f9ff932a@quicinc.com> (raw)
In-Reply-To: <0257f893-fed8-4ee9-ad4e-cdcdad8b5c85@linaro.org>



On 8/19/2025 7:00 PM, Neil Armstrong wrote:
> On 14/08/2025 09:15, Sarthak Garg wrote:
>>
>>
>> On 8/13/2025 5:37 PM, Konrad Dybcio wrote:
>>> On 8/13/25 1:56 PM, Krzysztof Kozlowski wrote:
>>>> On 13/08/2025 13:21, Konrad Dybcio wrote:
>>>>> On 8/13/25 1:08 PM, Sarthak Garg wrote:
>>>>>>
>>>>>>
>>>>>> On 8/5/2025 2:55 PM, Krzysztof Kozlowski wrote:
>>>>>>> On 05/08/2025 11:19, Sarthak Garg wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 8/1/2025 2:32 PM, Krzysztof Kozlowski wrote:
>>>>>>>>> On 01/08/2025 10:45, Sarthak Garg wrote:
>>>>>>>>>> The kernel now handles level shifter limitations affecting SD 
>>>>>>>>>> card
>>>>>>>>>> modes, making it unnecessary to explicitly disable SDR104 and 
>>>>>>>>>> SDR50
>>>>>>>>>> capabilities in the device tree.
>>>>>>>>>>
>>>>>>>>>> However, due to board-specific hardware constraints 
>>>>>>>>>> particularly related
>>>>>>>>>> to level shifter in this case the maximum frequency for SD 
>>>>>>>>>> High-Speed
>>>>>>>>>> (HS) mode must be limited to 37.5 MHz to ensure reliable 
>>>>>>>>>> operation of SD
>>>>>>>>>> card in HS mode. This is achieved using the 
>>>>>>>>>> max-sd-hs-frequency property
>>>>>>>>>> in the board DTS.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Sarthak Garg <quic_sartgarg@quicinc.com>
>>>>>>>>>> ---
>>>>>>>>>>     
>>>>>>>>>> arch/arm64/boot/dts/qcom/sm8550-hdk.dts                     | 1 +
>>>>>>>>>>     
>>>>>>>>>> arch/arm64/boot/dts/qcom/sm8550-mtp.dts                     | 1 +
>>>>>>>>>>     
>>>>>>>>>> arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 1 +
>>>>>>>>>>     
>>>>>>>>>> arch/arm64/boot/dts/qcom/sm8550.dtsi                        | 
>>>>>>>>>> 3 ---
>>>>>>>>>>     4 files changed, 3 insertions(+), 3 deletions(-)
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>> This will break MMC for all of the users and nothing in commit 
>>>>>>>>> msg or
>>>>>>>>> cover letter explains that or mentions merging strategy.
>>>>>>>>>
>>>>>>>>> Exactly this case is covered by your internal guideline, no? 
>>>>>>>>> Please read it.
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>> Krzysztof
>>>>>>>>
>>>>>>>> Just to make sure I’m addressing the right concern — are you 
>>>>>>>> primarily
>>>>>>>> worried about the introduction of the max-sd-hs-frequency 
>>>>>>>> property in
>>>>>>>> the board DTS files, or about the removal of the sdhci-caps-mask
>>>>>>>> from the common sm8550.dtsi?
>>>>>>>
>>>>>>>
>>>>>>> Apply this patch and test MMC. Does it work? No. Was it working? 
>>>>>>> Yes.
>>>>>>>
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Krzysztof
>>>>>>
>>>>>>
>>>>>> You're absolutely right to raise the concern about potential 
>>>>>> breakage.
>>>>>> After conducting additional testing across multiple boards, I’ve 
>>>>>> confirmed that the removal of SDR104/SDR50 broken capabilities 
>>>>>> does indeed affect V1 SM8550 devices.
>>>>>
>>>>> v1 is a prototype revision, please forget it exists, we most 
>>>>> definitely
>>>>> do not support it upstream
>>>>
>>>>
>>>> You should double check. SM8450 (not v1!) needed it, so either it was
>>>> copied to SM8550 (v2!) by mistake or was also needed.
>>>
>>> I believe that the speed capabilities are indeed restricted on 
>>> 8550-final
>>> and that's why this patchset exists in the first place
>>>
>>> Konrad
>>
>> Hi Krzysztof, Konrad,
>>
>> Konrad is right — this patch series addresses limitations seen on
>> SM8550-final silicon.
>>
>> SDR50 mode: The tuning support introduced in this series helps ensure
>> reliable operation.
>> SDR104 mode: limitations are resolved in SM8550 v2.
> 
> I guess the state is the same for SM8650, it also requires the 
> max-sd-hs-frequency.
> 
> I guess all boards with a level-shifter on board would need such 
> limitation,
> including most of the HDK boards (SM8450 included)
> 
> Neil
>

Yes, that makes sense Neil — all boards with a level-shifter on board
would likely need this limitation, including SM8450, SM8550, and SM8650.

>>
>> But still to avoid regressions, *I’ll like to retain sdhci-caps-mask in
>> sm8550.dtsi for now and revisit its removal for future targets after
>> thorough validation and testing from the beginning.*
>>
>> Konrad suggested placing max-sd-hs-frequency in the SoC dtsi.
>> Krzysztof, could you please share your thoughts on this approach?
>>
>> Best regards,
>> Sarthak Garg
> 

  reply	other threads:[~2025-08-20  7:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01  8:45 [PATCH V4 0/4] Add level shifter support for qualcomm SOC's Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 1/4] mmc: sdhci-msm: Enable tuning for SDR50 mode for SD card Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 2/4] dt-bindings: mmc: controller: Add max-sd-hs-frequency property Sarthak Garg
2025-08-01  9:00   ` Krzysztof Kozlowski
2025-08-01 10:41     ` Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 3/4] mmc: core: Introduce a new flag max-sd-hs-frequency Sarthak Garg
2025-08-01  8:45 ` [PATCH V4 4/4] arm64: dts: qcom: sm8550: Remove SDR104/SDR50 broken capabilities Sarthak Garg
2025-08-01  9:02   ` Krzysztof Kozlowski
2025-08-05  9:19     ` Sarthak Garg
2025-08-05  9:25       ` Krzysztof Kozlowski
2025-08-13 11:08         ` Sarthak Garg
2025-08-13 11:21           ` Konrad Dybcio
2025-08-13 11:56             ` Krzysztof Kozlowski
2025-08-13 12:07               ` Konrad Dybcio
2025-08-14  7:15                 ` Sarthak Garg
2025-08-19 13:30                   ` Neil Armstrong
2025-08-20  7:19                     ` Sarthak Garg [this message]
2025-08-05  9:59       ` Dmitry Baryshkov
2025-08-05 13:08         ` Konrad Dybcio
2025-08-13 11:20           ` Sarthak Garg
2025-08-13 11:14         ` Sarthak Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1252539-d35f-443b-9e0a-3316f9ff932a@quicinc.com \
    --to=quic_sartgarg@quicinc.com \
    --cc=adrian.hunter@intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_bhaskarv@quicinc.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_nitirawa@quicinc.com \
    --cc=quic_pragalla@quicinc.com \
    --cc=quic_rampraka@quicinc.com \
    --cc=quic_sayalil@quicinc.com \
    --cc=robh@kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®