From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E408BC43470 for ; Fri, 7 May 2021 08:28:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B78136143C for ; Fri, 7 May 2021 08:28:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236238AbhEGI3i (ORCPT ); Fri, 7 May 2021 04:29:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39926 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236218AbhEGI3d (ORCPT ); Fri, 7 May 2021 04:29:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620376114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2EtsHTWG0I945KmFB2rvkJ4C7JnZYKjnyrdpp2fnzKI=; b=fvTIL1Z3QDkm2RhwLHYUksiXz/9ci24ADiDSY9sX4z87RdfMddbzwAzQAG7AjWhI0eSTZE 6D1hz2bQRbtQAE7UfkoAmHsHzxbHj5qATa7et3SOypHuihFGJK8QQE6AwSKkike+dsWqib 4e03uSTy8N+TGXv8pNzdrKK4WIMMs+g= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-9xAI6RUPMGqG1tubrlK0sg-1; Fri, 07 May 2021 04:28:32 -0400 X-MC-Unique: 9xAI6RUPMGqG1tubrlK0sg-1 Received: by mail-wr1-f72.google.com with SMTP id l2-20020adf9f020000b029010d6bb7f1cbso3265570wrf.7 for ; Fri, 07 May 2021 01:28:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2EtsHTWG0I945KmFB2rvkJ4C7JnZYKjnyrdpp2fnzKI=; b=fiNrwN623ASj9JEK6n4vqPczHSNsdPQJ1pcKVxveddCVWUT5pE7xqcQuolQqyT6AXA k9dIlxnFdpvabPnELS9B3g0Qx0xATnQRYbBldFiTmO0hW3yzfCdW87xdiKRPuKFjFbvj vaTavQi3+Nfxfa08B+G9bSlR3vNM2RDgcPNI0DpqH8kx+aghGPGiM4qPIB/YlBLqUA3s 1BB2EvIFKAGqDpU1HfoxQia2i0Ufk0Z0699uvLcqmcweBvnaD2qr/IWs1gBY9JUlagUP FSOr7IW+skYygTkdBfA0/phfamxzTKiT602xD/j53PiOqWYO3wbhg+pDBKE1DEz9npYs X/Jg== X-Gm-Message-State: AOAM532S2Gf0Nxf0+1/z7X7331gm86ojPNRUYQvnqIAALjlvo3vmxeNu 4q2+T7KcLaTRWfiUsUSZI5GmM74F7eZFavROiIxVLxP0pu38mqLncd+rl7G7f24Y1LvdXeIMAiw UaLWF8IBoUvVOmyY8IylAEIh0 X-Received: by 2002:a1c:4e06:: with SMTP id g6mr8566103wmh.30.1620376111671; Fri, 07 May 2021 01:28:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7DglUp/7+aIhLhSphLrJcy6WZJYfjkEbPnKZcfDzBYJtlkC3FZlonDpDwsI35pPuGY73A3A== X-Received: by 2002:a1c:4e06:: with SMTP id g6mr8566077wmh.30.1620376111514; Fri, 07 May 2021 01:28:31 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id l21sm12474008wme.10.2021.05.07.01.28.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 May 2021 01:28:30 -0700 (PDT) Subject: Re: [PATCH v3 5/8] KVM: x86/mmu: Add a field to control memslot rmap allocation To: Ben Gardon , LKML , kvm Cc: Peter Xu , Sean Christopherson , Peter Shier , Yulei Zhang , Wanpeng Li , Xiao Guangrong , Kai Huang , Keqian Zhu References: <20210506184241.618958-1-bgardon@google.com> <20210506184241.618958-6-bgardon@google.com> From: Paolo Bonzini Message-ID: Date: Fri, 7 May 2021 10:28:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/21 01:44, Ben Gardon wrote: >> struct kvm_vm_stat { >> @@ -1853,4 +1859,6 @@ static inline int kvm_cpu_get_apicid(int mps_cpu) >> >> int kvm_cpu_dirty_log_size(void); >> >> +inline bool kvm_memslots_have_rmaps(struct kvm *kvm); > Woops, this shouldn't be marked inline as it creates build problems > for the next patch with some configs. > Possibly stupid (or at least lazy) question: why can't it be a "normal" static inline function? Paolo