From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752069AbdHHJeW (ORCPT ); Tue, 8 Aug 2017 05:34:22 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:60266 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbdHHJeU (ORCPT ); Tue, 8 Aug 2017 05:34:20 -0400 X-AuditID: b6c32a49-f79a26d000001fba-b4-5989859956ea Subject: Re: [PATCH RFC] irqchip: gic-v3: Support forced cpu irq affinity setting To: Marc Zyngier , tglx@linutronix.de, linux-kernel@vger.kernel.org Cc: jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, shaik.ameer@samsung.com, aswani.reddy@samsung.com, abhinav.k@samsung.com, alim.akhtar@gmail.com, arjun.kv@samsung.com From: Alim Akhtar Message-ID: Date: Tue, 8 Aug 2017 14:57:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <7ea6b8d3-762a-d4e9-3b64-609b534c3960@arm.com> Content-Type: text/plain; charset="windows-1252"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOKsWRmVeSWpSXmKPExsWy7bCmhu7M1s5Ig1XbLCzePTzMbrH0VrXF 8pW7WCwObd7KbtG45DKLxabH11gtLu+aw2bx984/NosjD3ezW2zeNJXZgctjzbw1jB47Z91l 92g4cJ7F4925c+wem5fUe/RtWcXo8XmTXAB7FJdNSmpOZllqkb5dAlfGzBvd7AW/+Cp2nPRv YJzK08XIySEhYCKx5/Q+ZghbTOLCvfVsXYxcHEICuxklDl/dxAzhfGKUuLbxFBucM+1oHwtM +7qpc6GqdjJKLHuwA8p5yyjx+MV5VpAqYYFgifaXX9lAbBGBaIm7y2eAFTGDdDR03QTbziag LXF3+hYmEJtXwE5i2r7/YDaLgIpEc+8NsGZRgQiJbd9nsEHUCEqcnPkE7AxOAWuJT+9OgNUz CzhK/Hl8iBXCFpe49WQ+VFxeYvvbOWCLJQTa2SX+rYK4TkLARWLp+nOMELawxKvjW9ghbCmJ z+/2skHY5RLtV/9BNXcwSpyadA4aAPYSB67MgbJtJfbeXcwCsY1Povf3EyaIuKpE87urQHEO IJtXoqNNCCLsIdF94in7BEalWUj+mYXkh1lIfpiF5IcFjCyrGCVTC4pz01OLTQsM81LL9YoT c4tL89L1kvNzNzGCk5eW5w7GWed8DjEKcDAq8fCuSOuIFGJNLCuuzD3EKMHBrCTCez27M1KI NyWxsiq1KD++qDQntfgQozQHi5I477GdpZFCAumJJanZqakFqUUwWSYOTqkGxo1hv65/fc/J cs5HhedBW0n70xsNfo+nTA3lWz1rdS7r7Ojpfx85fX28OHPLy5NJDRskc/7IfA9p3Zxtt3vJ Dul12sxFvoH27rffnU2Rfs/Z/Ov54bMLcpwebJf/maDZbxxT0VNkKv3J9bOB9L+46E09v3mP hOV/+ZR92f/6nbQrTx6fmb3M44QSS3FGoqEWc1FxIgDy0J2zWgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsWy7bCSnO6M1s5Igwdv9S3ePTzMbrH0VrXF 8pW7WCwObd7KbtG45DKLxabH11gtLu+aw2bx984/NosjD3ezW2zeNJXZgctjzbw1jB47Z91l 92g4cJ7F4925c+wem5fUe/RtWcXo8XmTXAB7FJdNSmpOZllqkb5dAlfGzBvd7AW/+Cp2nPRv YJzK08XIySEhYCKxbupcZghbTOLCvfVsXYxcHEIC2xklXq5bzAKRkJa4vnECO4QtLLHy33N2 iKLXjBK3TreAJYQFgiXaX35lA7FFBKIl3q1exQpSxCywk1Fi96O/UB1nGCW2/uoGG8smoC1x d/oWJhCbV8BOYtq+/2A2i4CKRHPvDbBJogIREn1vL7ND1AhKnJz5BKyXU8Ba4tO7E2D1zAK2 Enfm7maGsMUlbj2ZDxWXl9j+dg7zBEbhWUjaZyFpmYWkZRaSlgWMLKsYRVMLinPTc4sLjPSK E3OLS/PS9ZLzczcxguNOK2kH46YZ4YcYBTgYlXh4V6R1RAqxJpYVV+YeYpTgYFYS4b2e3Rkp xJuSWFmVWpQfX1Sak1p8iFGag0VJnHd79YYIIYH0xJLU7NTUgtQimCwTB6dUA6MCt4x6+bQN v6fc9G92cWJpKGB6tvvgpNfPjR96NXjejJmV/yPVd7La0y9b7zhKTpjs/Xta1EHtjvP/9fS4 9qc37CyZd7HN1IfjUcPMnRMb2ZZZJefPCjm5wmXS0iO792le6Yhn0Cqv/X3qQ2CsOgfLJrNn ftwzZSRkT2+cfb29IZzZSFC8+IESS3FGoqEWc1FxIgA/gmurtwIAAA== X-CMS-MailID: 20170808093416epcas5p23cf35fb0558e8a18d883c8a66ac897fa X-Msg-Generator: CA X-Sender-IP: 182.195.40.14 X-Local-Sender: =?UTF-8?B?7JWM66a8G1NTSVItRkRTIFNXG+yCvOyEseyghOyekBsuL1Nl?= =?UTF-8?B?bmlvciBDaGllZiBFbmdpbmVlcg==?= X-Global-Sender: =?UTF-8?B?QUxJTSBBS0hUQVIbU1NJUi1GRFMgU1cbU2Ftc3VuZyBFbGVj?= =?UTF-8?B?dHJvbmljcxsuL1NlbmlvciBDaGllZiBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElEMDdJRDAxMDk5Nw==?= X-MTR: 20170808093416epcas5p23cf35fb0558e8a18d883c8a66ac897fa CMS-TYPE: 105P X-CMS-RootMailID: 20170808091129epcas1p48d0523675178cb841d97e64d5baab75f X-RootMTR: 20170808091129epcas1p48d0523675178cb841d97e64d5baab75f References: <1502183093-30327-1-git-send-email-alim.akhtar@samsung.com> <7ea6b8d3-762a-d4e9-3b64-609b534c3960@arm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2017 02:52 PM, Marc Zyngier wrote: > On 08/08/17 10:04, Alim Akhtar wrote: >> Skip check for online cpu mask when setting irq affinity of per cpu timer >> during early startup of not yet online cpu. >> >> Signed-off-by: Shaik Ameer Basha >> Signed-off-by: Aswani Reddy >> Signed-off-by: Alim Akhtar >> --- >> drivers/irqchip/irq-gic-v3.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> Currently when non boot CPUs comes up and if setting of IRQ affinity gets called >> before cpu online status gets updated, gic_mpidr_to_affinity() returns >> undesirable cpu number. Using __force__ flag ignore cpu_online_mask and setup >> the intended cpu affinity for the irq. >> >> The same approch is used in gicv2 >> (commit: ffde1de64012c: irqchip: Gic: Support forced affinity setting) >> >> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c >> index dbffb7a..c238c64 100644 >> --- a/drivers/irqchip/irq-gic-v3.c >> +++ b/drivers/irqchip/irq-gic-v3.c >> @@ -640,11 +640,16 @@ static void gic_smp_init(void) >> static int gic_set_affinity(struct irq_data *d, const struct cpumask *mask_val, >> bool force) >> { >> - unsigned int cpu = cpumask_any_and(mask_val, cpu_online_mask); >> + unsigned int cpu; >> void __iomem *reg; >> int enabled; >> u64 val; >> >> + if (!force) >> + cpu = cpumask_any_and(mask_val, cpu_online_mask); >> + else >> + cpu = cpumask_first(mask_val); >> + >> if (cpu >= nr_cpu_ids) >> return -EINVAL; >> >> > > See > > https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/commit/?h=irq/irqchip-4.13&id=65a30f8b300107266f316d550f060ccc186201a3 > Thanks Marc for above link. Is this already queued in some tree? I can't find this is linux-next. > M. >