From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 180D33A641A for ; Thu, 8 Jan 2026 11:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767871748; cv=none; b=Mm7oOkVcOEnUQqEkb5fhQhPk0Cm2+kHuna4EUJ0LqejkXHbOWz8u1MBoH0oz9GFFjQ/sBYrfwRhezUsXh6QidsqhztLc/D/Q6k6YKSmSegXJTiwfAYk/l3eYJW5PgsGqydHayHbCb0sIzO2ur+ST1txOpQ3LgMlcHsaybmQ5LqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767871748; c=relaxed/simple; bh=dJYi/b8U+Ys1LYlY9+h/mleeGks1F1L2iNDhWnfN3uM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lCl6e7+OQ1ejs6irtereEABtKA8b0eLe95UPxPLV+QFgaLf1wK6Alc3EebJEc1bJvgXKBzLV9lFElZlAG7KL/dLwrkbNBis/tJ5MUDzdZLMZviH9LsbCefIkSjSokBiB8dEEbL1r307hnWUVMyRbQQ9vDOJLy9TWyUBnwXVsTJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cSWFWXmH; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=dTXMHFJU; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cSWFWXmH"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="dTXMHFJU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767871744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D+a8/HgrrA9LGdGkGtxw3sexeM0b0Vs24vRvPS8jCcE=; b=cSWFWXmHychaMJiFdeP3nBpv77HeZyCP/hQ6XFqwSO+3QXJE3RoBeFfvn9W+FKE7PhPSw5 gHz/5hcifxU8O4QqXbX2GIADz9QRvwzed9QqtWl8LjOTNlJ1rkcfkuiwrKulgySIbdON8p Tql+aONYDC7lRe7I0CHoyE0JyXlNuyk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-159-dczC8C53MceKU3rLkZ2QYQ-1; Thu, 08 Jan 2026 06:29:03 -0500 X-MC-Unique: dczC8C53MceKU3rLkZ2QYQ-1 X-Mimecast-MFC-AGG-ID: dczC8C53MceKU3rLkZ2QYQ_1767871742 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-477a1e2b372so28372505e9.2 for ; Thu, 08 Jan 2026 03:29:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1767871742; x=1768476542; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D+a8/HgrrA9LGdGkGtxw3sexeM0b0Vs24vRvPS8jCcE=; b=dTXMHFJUqGb3Kc7ICyKyxoM5yhIEY9WZCtate5SghyqD1JIatYaYfaVykcjYk+qo3U I5NmqXTC9x4/03aTJxd/yacrXnw/iaXVlO2G4gzh7nUSirbxArOl4gzpEZA01Z5g2cm7 /XNEhx6Tce20gAAIfCIKepUVylv1xk/HgOPofe4syGgETxnGmAfrzh/YAGacQt7rmI7R Oqxnx3NHs83GNOciKRfGlhHYAYWcA52dmXRJg3eC2VBFHIc/hogrVlXyR/3XtjtZElgS PzjXBdpSFr24Xqrz3oWp8LI3HVWL/4PiMPwNs1mkd8uhH76ktMx/pO2LDtHc+ge5KUXQ Bc/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767871742; x=1768476542; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D+a8/HgrrA9LGdGkGtxw3sexeM0b0Vs24vRvPS8jCcE=; b=mv36OZUyeeCGnOEooF+L1bG3bg9/9VrY2692YRIPhtYMKU/0b9dtVqLBNOAvKaUgan Bo6OofJ8LAQcsiWrpSrnPHOhAKRGnyfyaGpf64A2YW6iG9viNQzcEdargnuD7zEnxLyS HdyXs0uMjApTdBTPs63LqStVGXiYvNgt+EOF5Owl8dYNOn0//mtWHIL9zkjC1cYnYyhq 917uuskMl66RRY49549dyE4LRUSSPevlMQm3+eV4CpZ43T5oPg8ctPO0j/thAhWDjSCA vt2DAsbKRmRA1ZLsW4mdI77F1oum9uxymtiLdJcwMcdcfRDPrBi1aBd8yUYE5u5XTpMA H43Q== X-Gm-Message-State: AOJu0YyAxoBVagP7KSQG/843PG60ey2+NcpfUXBMGkqGFw5tgdHDm8dy 67E10CkpTKqnhSfMaIn9R2F8MTAa35yDD05Eu8mYNyL2Bt7DPLdvQZ4nOgRe828DGbPLWCH5JtO 70YQ6oBQOR1zT4hdFg+rXNaf+5aJ6nStFHjM8vNJeDBYGe4wjNooVoGvXMV5iJYsQng== X-Gm-Gg: AY/fxX6H87J+DMBGWoKO6Aw75iA1zh/Rvfu1CWI+5BBbLuBrZ6ZChBjnNGYxHyVjnFv qQ7jPW780XQnPTdwFD3YzXoHITBKHMQ/kidubY8k5b26l4mA1vyJIsmUkfzlPUfL7zCNrAWhK6W 0FT8V+5iwA5eZZ8hl8GIbRAZWY2jPYPBn8WXHy+yT/QcUc69eRehIbdYbWtCjvs0MLWCQhOH7Xf v5hEVtlllbbCyl1FeFeXYgWWifZc2qNpVSUMcwI02lz6MiVD+qmwHiPLaFsCEd83aR/o10U5+yO fHFbB1dj6aeboDCXjpDqn1MAbpoaSdjCS3CABKW4Jw+HX4wj2mmnUZnbJFDmpFyk1oirIGubQL4 Dygbu6dmBkdDt9w== X-Received: by 2002:a05:600c:8119:b0:477:b0b9:3129 with SMTP id 5b1f17b1804b1-47d84b0a8dfmr65473595e9.3.1767871742166; Thu, 08 Jan 2026 03:29:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEgaAftp+naANwBwxcdTWbs47iqT+WgXibibJoopIEFumDXskHupti0hYSDGlBzsi6bm2o4vA== X-Received: by 2002:a05:600c:8119:b0:477:b0b9:3129 with SMTP id 5b1f17b1804b1-47d84b0a8dfmr65473285e9.3.1767871741741; Thu, 08 Jan 2026 03:29:01 -0800 (PST) Received: from [192.168.88.32] ([212.105.149.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47d8662c09bsm38373035e9.2.2026.01.08.03.28.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 03:29:01 -0800 (PST) Message-ID: Date: Thu, 8 Jan 2026 12:28:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v11 3/3] net: ti: icssm-prueth: Add support for ICSSM RSTP switch To: Parvathi Pudi , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, danishanwar@ti.com, rogerq@kernel.org, pmohan@couthit.com, basharath@couthit.com, afd@ti.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alok.a.tiwari@oracle.com, horms@kernel.org, pratheesh@ti.com, j-rameshbabu@ti.com, vigneshr@ti.com, praneeth@ti.com, srk@ti.com, rogerq@ti.com, krishna@couthit.com, mohan@couthit.com References: <20260105122549.1808390-1-parvathi@couthit.com> <20260105122549.1808390-4-parvathi@couthit.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260105122549.1808390-4-parvathi@couthit.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/5/26 1:23 PM, Parvathi Pudi wrote: > +static int icssm_prueth_ndev_port_link(struct net_device *ndev, > + struct net_device *br_ndev) > +{ > + struct prueth_emac *emac = netdev_priv(ndev); > + struct prueth *prueth = emac->prueth; > + unsigned long flags; > + int ret = 0; > + > + dev_dbg(prueth->dev, "%s: br_mbrs=0x%x %s\n", > + __func__, prueth->br_members, ndev->name); > + > + spin_lock_irqsave(&emac->addr_lock, flags); > + > + if (!prueth->br_members) { > + prueth->hw_bridge_dev = br_ndev; > + } else { > + /* This is adding the port to a second bridge, > + * this is unsupported > + */ > + if (prueth->hw_bridge_dev != br_ndev) { > + spin_unlock_irqrestore(&emac->addr_lock, flags); > + return -EOPNOTSUPP; > + } > + } > + > + prueth->br_members |= BIT(emac->port_id); > + > + ret = icssm_prueth_port_offload_fwd_mark_update(prueth); More AI generated feedback here that still looks valid to me: """ ndo_stop() can sleep (e.g., via rproc_shutdown()). This function appears to be called while holding a spinlock via the call chain: icssm_prueth_ndev_port_link() -> spin_lock_irqsave(&emac->addr_lock) -> icssm_prueth_port_offload_fwd_mark_update() -> icssm_prueth_change_mode() -> ndo_stop() / ndo_open() Is this intentional? The ndo_open() path also calls icssm_prueth_sw_init_fdb_table() which does kmalloc(GFP_KERNEL) and rproc_boot(), both of which may sleep. """ There are other similar cases; for the full report see: https://netdev-ai.bots.linux.dev/ai-review.html?id=ce23f731-f25b-4082-a5d0-c1261ab829ed /P