From: Brajesh Gupta <Brajesh.Gupta@imgtec.com>
To: Luigi Santivetti <Luigi.Santivetti@imgtec.com>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"airlied@gmail.com" <airlied@gmail.com>,
Alessio Belle <Alessio.Belle@imgtec.com>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>,
Alexandru Dadu <Alexandru.Dadu@imgtec.com>,
"mripard@kernel.org" <mripard@kernel.org>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"imagination@lists.freedesktop.org"
<imagination@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] drm/imagination: Tidy-up firmware interface checks
Date: Mon, 3 Aug 2026 06:41:23 +0000 [thread overview]
Message-ID: <a134f6d0905622490d1bc276aee0cdaa352b99a5.camel@imgtec.com> (raw)
In-Reply-To: <20260729-fwif-checks-updates-v1-0-af65e9606a7e@imgtec.com>
On Wed, 2026-07-29 at 15:57 +0100, Alessio Belle wrote:
Hi Alessio,
> *** NOTE: This is an internal email from Imagination Technologies ***
>
>
>
>
> The same macros were repeated in multiple header files, and another
> header that could have used them, didn't.
> Move things around to to sort out these minor issues.
>
> Strict checkpatch reports "Macro argument reuse 'member' - possible
> side-effects?" for FLEX_ARRAY_CHECK() but that's not a problem here.
For the whole series:
Reviewed-by: Brajesh Gupta <brajesh.gupta@imgtec.com>
Thanks,
Brajesh
>
>
> Signed-off-by: Alessio Belle <alessio.belle@imgtec.com>
> ---
> Alessio Belle (1):
> drm/imagination: Reuse layout check macros for MIPS FW structures
>
> Alexandru Dadu (1):
> drm/imagination: Move all FW interface check macros to pvr_checks.h
>
> drivers/gpu/drm/imagination/pvr_check.h | 36 +++++++++++
> drivers/gpu/drm/imagination/pvr_rogue_fwif_check.h | 26 +-------
> .../drm/imagination/pvr_rogue_fwif_client_check.h | 9 +--
> .../drm/imagination/pvr_rogue_fwif_shared_check.h | 9 +--
> drivers/gpu/drm/imagination/pvr_rogue_mips_check.h | 71 ++++++++--------------
> 5 files changed, 63 insertions(+), 88 deletions(-)
> ---
> base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
> change-id: 20260729-fwif-checks-updates-52adf8657615
>
> Best regards,
> --
> Alessio Belle <alessio.belle@imgtec.com>
>
next prev parent reply other threads:[~2026-08-03 6:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 14:57 Alessio Belle
2026-07-29 14:57 ` [PATCH 1/2] drm/imagination: Move all FW interface check macros to pvr_checks.h Alessio Belle
2026-07-29 14:57 ` [PATCH 2/2] drm/imagination: Reuse layout check macros for MIPS FW structures Alessio Belle
2026-08-03 6:41 ` Brajesh Gupta [this message]
2026-08-03 10:29 ` [PATCH 0/2] drm/imagination: Tidy-up firmware interface checks Alessio Belle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a134f6d0905622490d1bc276aee0cdaa352b99a5.camel@imgtec.com \
--to=brajesh.gupta@imgtec.com \
--cc=Alessio.Belle@imgtec.com \
--cc=Alexandru.Dadu@imgtec.com \
--cc=Luigi.Santivetti@imgtec.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imagination@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®