From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451AbdJDOmU (ORCPT ); Wed, 4 Oct 2017 10:42:20 -0400 Received: from mail-io0-f170.google.com ([209.85.223.170]:47426 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbdJDOmP (ORCPT ); Wed, 4 Oct 2017 10:42:15 -0400 X-Google-Smtp-Source: AOwi7QDDEzxiMPw1ZbUZY7i+YPy4Kuoc4EPRHgCxcy9QhgIqxp2ajcxvazpxqNxZeufc7lmOezQcBg== Subject: Re: [PATCH 1/2] writeback: eliminate work item allocation in bd_start_writeback() To: Jan Kara Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org References: <1507043781-2874-1-git-send-email-axboe@kernel.dk> <1507043781-2874-2-git-send-email-axboe@kernel.dk> <20171004072635.GP11879@quack2.suse.cz> From: Jens Axboe Message-ID: Date: Wed, 4 Oct 2017 08:42:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171004072635.GP11879@quack2.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/04/2017 01:26 AM, Jan Kara wrote: >> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h >> index 420de5c7c7f9..f0f1df29d6b8 100644 >> --- a/include/linux/backing-dev-defs.h >> +++ b/include/linux/backing-dev-defs.h >> @@ -116,6 +116,7 @@ struct bdi_writeback { >> >> struct fprop_local_percpu completions; >> int dirty_exceeded; >> + int start_all_reason; > > This should be 'enum wb_reason' instead of 'int'. Yes good point, I'll move the enum and change 'start_all_reason' to be of type enum wb_reason. Thanks for the review! -- Jens Axboe