From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F121A2206A7 for ; Thu, 25 Jun 2026 01:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782349289; cv=none; b=nbW5Z4m1rGvW/EfZhzAY4ZY1sNS4/NRcyPiCfEnstUbXZdV4UXs/d+Cek2juM3bS0668hjfaT2AztF85VQVh+pT7Xodi2IJKM5k1gfoRRAciRzjhGMxKSX5Vbm/mnjTU86+BIJ356jDdJRLie624of7TbxqZAMbhYgD2s3qcHQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782349289; c=relaxed/simple; bh=vLTeuALGLVem3atvJ6Rr7ZIJuSU0nlwaxwJE5U04Emc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Bm1434nh8tiZWvGCZuqi1TPbV6N+1H0FVGIgwgRSw4glfTIZpDjxC8ZWG5glG4uFBUlN0jbRv0yL/IjObAVEL0JXpe+4ks6crPJoviXBnmfthyHWck4+7uwmDUntix3lHxbDt3BSmGsxzsf3abrHb8pYh/htnuzyqCxy08bg+cQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZvA9h5M7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LX/4DRt6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZvA9h5M7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LX/4DRt6" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65OLqaQG486535 for ; Thu, 25 Jun 2026 01:01:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= k9Nczp6ZPD9k3X0chhFsGz8D+YeWBBIoPg1GZIWffTM=; b=ZvA9h5M7xX7s9iOu 5kdKGdO3Uprji+67EKohMHTyzZL3cqzFUQYDNDaD7aep3vQmeeFn5czi/BBmkPaE 6lkwreJDTBey9OUM/9KzVVNkyuUmK/szGOVgQQkyPE2a4qosqOjpbPWENsM/t5C4 /MCOR09Z5Nt4GysZckZrQSzrE3Z80uWbezJu5y8mAPyG3yxwGjV/1nqZMJ74Kn5i FreDKnT8shxu5fXAg3aqNHKMZ8L7z8PM0BTPLr/PVXprudx4vHIij6RrxXEVGLby ajyNE9BH1w9sxBQ02LABObmurXrirLDVJ1xfBRxpTFk19KtjavxTbA+7XhqY83KC 30FIFA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0996m5ea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 01:01:26 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c6a2ee8cc9so13900285ad.3 for ; Wed, 24 Jun 2026 18:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782349286; x=1782954086; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k9Nczp6ZPD9k3X0chhFsGz8D+YeWBBIoPg1GZIWffTM=; b=LX/4DRt6LI6HlRyPYN5oUnz/fX/r7Oiefab0tHPp5iK7aSdkk1ax/xELhaAKQEyKTi WikZj7v270i1xEbtWmLHd6/eJ2hEA0ZGn1eJnrIYAaEMbnRLNj5JAto+QaAdrfy8nqIV CDQqigQYu86TGapdIrpJMlhFIkXIdNLc7lgu0tJ6SGr9afhof+dcOejohaf5U0fhHtsw olnO8fcSBNdAMTKIA+uDreM8aiGTlcw2ZSRbapaQHPp+0LZRV5NpUMegF0yXvpGfZ3ai QcWgf7P4SWWJfMb0ljRQ9C8RzYVRramGUmcqi23+CxIhcimv2dYlMWl3a9m+YLHaO56S JXdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782349286; x=1782954086; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k9Nczp6ZPD9k3X0chhFsGz8D+YeWBBIoPg1GZIWffTM=; b=FV4xD5ERwqpG/JNGj/gdkksScXaCPrEY5q6TBoittSzR4GlIz3Oa+k7lXSS2gd3V8E tflkq801DKcciAUaTzNuDs+f5s4gBoZS38XO1avrUCWOdJ+uMl2nKeT7lgowpi7LY8Pu QwMs7Le5na33bb50HGCQ3zz2WhxMjNW94MKDxGWjwP7aeiuCfyLLJcgLPuo+5DVpSFFQ plPNF/hRj9UwsmFbLsQBvW/eRIjtX6LgpotglAKY7ZN6Odj58KeFBN5dNFOZyRY59bP5 B9Vh42M4IYjRoe/c4ET/vXOrp2MK0yZnlMteSaBldW468qHxyz3pKXybq5o1Sza3CDcv ehGQ== X-Forwarded-Encrypted: i=1; AHgh+Rokyt03cNf9PHRLLPxnOA1vT7Q3aFGTHbUQYtbB0PtcqtHj4riwCk875YEvjkDmCHZt0MF/mPaIz9b/sJU=@vger.kernel.org X-Gm-Message-State: AOJu0YwNGZSPwIS9FW7u8oEDDstcuzgbWiRW3doqG/x1YKPn0vpdaYP2 by9k4xawrk78sGQqPNPA7PiBP+5YXbK9a3IXzU3XK+qdVCXfXFe7aiPFbg3VDH694HF70Fs3sm9 GS3Pa0r+R5j0kZ8/ZY993EHxecVNrOJGW3Oc2/jlDrAnJM9lK+6wqz9DO3J2IMXFFOgw= X-Gm-Gg: AfdE7clAoA6bOFjp8dnnaH905hk3xKJs1lYY7ZwcTpq3b15Qo3YCqatzsSUEY9T1wxy nOV7rzmiB/SHq9H8fjoypP7FqZ+UyuN6JR6Q7Y6TTtMGQZAwv8V2ueMAR8C+VRvmQpog1ukk/3p MXh9xTL+b5V44lgV8CW6O6owwYGtiB04E+iXosZ7ky9WUWMEjyjiNLJqa6OutMRaLVdS60VHHaT UwDio5a/7KaPTBn6xvvbG6KwY/8ZQaXTXsjCgMNHAT5ERPIYq26uNqlaASbF1pnLdMoOXAeP9OV A2xuWeh6OFfjZG+vvLQZf1O7rpsEf5/xTVuyn2X6Cdatie8Ox0LTSrOsYpFebx4o5wo/6J5aUhX 7KLYbTGSQsXQ1FZPvXYln87J+j/9xcpSARtJVtSPqCcuDMqNjYwQwA8A6wqhZ5kko4wUeWtYtDc md X-Received: by 2002:a17:902:d489:b0:2c7:f4bd:91b5 with SMTP id d9443c01a7336-2c7fc382d31mr5407105ad.0.1782349285606; Wed, 24 Jun 2026 18:01:25 -0700 (PDT) X-Received: by 2002:a17:902:d489:b0:2c7:f4bd:91b5 with SMTP id d9443c01a7336-2c7fc382d31mr5406375ad.0.1782349284807; Wed, 24 Jun 2026 18:01:24 -0700 (PDT) Received: from [10.133.33.237] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f65062adsm7653335ad.75.2026.06.24.18.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Jun 2026 18:01:24 -0700 (PDT) Message-ID: Date: Thu, 25 Jun 2026 09:01:18 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: kaanapali: fix traceNoC probe issue To: Leo Yan , Suzuki K Poulose Cc: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Jingyi Wang , Abel Vesa , Mike Leach , James Clark , Yuanfang Zhang , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org References: <20260624-fix-tracenoc-probe-issue-v2-0-786520f62f21@oss.qualcomm.com> <20260624-fix-tracenoc-probe-issue-v2-2-786520f62f21@oss.qualcomm.com> <471d7a92-3629-4274-a303-8906d3626037@arm.com> <25d7d3a1-58e0-4f25-a73a-59a978130c47@oss.qualcomm.com> <20260624151610.GC575984@e132581.arm.com> Content-Language: en-US From: Jie Gan In-Reply-To: <20260624151610.GC575984@e132581.arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: gZmFWNF2jEdkx10vrn7t0wxXSG80P6pV X-Proofpoint-ORIG-GUID: gZmFWNF2jEdkx10vrn7t0wxXSG80P6pV X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDAwNiBTYWx0ZWRfXy+vBW2CecIlC P5M/AsL/5V23FugfyyLwOJH/SuVZMlVNOs0VHm9ccGU5g3FiKFUo26CTBgH6H5vJlTtQ7tvmI4G CCjs+VqAU+M5C8Lt9V8ODVNZCB5F0t8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDAwNiBTYWx0ZWRfX++6Awsj/sJ97 B9EVzZ5n0fTptbMNCtsJKiytP+vEInQ4VYDCALsC0+rzUsxt6SWvIUwO749qmu4dkNFE/FMIszq eNelmVEzVUMgJfYGB/TZd+Prd06bQzdNSZpdbOwhJetqUzhwQ/A6ip/N6I81E7H6v09/X1JYtiZ 4UqBI2qGc6oCn2wZZdRJPDagBmKS3RxIFw5pSjEZLeLOX5tKaw62MxnBtlAQ1ctiKDRIb0qZ+M8 5qI/oRbVn/b1QSTncq/+WfWz+g5IoFVq3oaUFojTkQfGtbdhfXGkNtkdScFfAl5r9lN4k554Fxj OPmxTuECjW11Hu3xwpvCy0OMtIgA5seD4taFkkBEcBkQ6XXtxpjoFxF+/g48QhHt25SJcJGR1Le wMIgVAJGlxtgTn9F7oLinu5iExlXwMaFDqTbGH9GIYazLWqTiCmP9vmYp3mbhk5hzdR7DyzKz6R GDf0yHj9JJasp6Bxy5g== X-Authority-Analysis: v=2.4 cv=Tv/WQjXh c=1 sm=1 tr=0 ts=6a3c7de6 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=jcv4FM0po0oPS6h7aqIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-24_04,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250006 On 6/24/2026 11:16 PM, Leo Yan wrote: > On Wed, Jun 24, 2026 at 11:08:32PM +0800, Jie Gan wrote: > > [...] > >>> Why does it fail ? power management ? hw broken ? Is it really AMBA or >>> do you pretend that to be an AMBA device by faking the CID/PID? >> >> The CID reads as 0 from the register, which I suspect is a hardware design >> issue. I have not yet confirmed this with the hardware team. As a >> workaround, I provided a fake periphid via a DT property to bypass >> amba_read_periphid. >> >> >> Leo commented in other thread: >>>> tnoc.c registers both an AMBA driver and a platform driver. Shouldn't >>it >>>> be registered as a platform device instead? >> >> The platform driver is intended for the interconnect TraceNoC device and is >> not designed to allocate an ATID. The issue is that the TPDM device borrows >> the ATID from the TraceNoC device, resulting in the ATID always being 0 when >> associated with an interconnect NoC device. >> >> However, I believe it is acceptable to allocate an ATID for the itNoC device >> and the issue can be fixed with this way. > > I think so. Hi Suzuki/Leo Which solution do you prefer to address the issue? The interconnect traceNoC platform driver is intended for the itnoc device, implying that no TPDM devices are connected to it. So, if I modify it to allocate an ATID, I think it would be better to rename the “itnoc” node accordingly? Or it's ok to leave it as-is? BTW, the traceNoC device definitely is an AMBA device with CID/PID registers. Thanks, Jie