From: Adrian Hunter <adrian.hunter@intel.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Sarthak Garg <quic_sartgarg@quicinc.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: <linux-mmc@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_cang@quicinc.com>,
<quic_nguyenb@quicinc.com>, <quic_rampraka@quicinc.com>,
<quic_pragalla@quicinc.com>, <quic_sayalil@quicinc.com>,
<quic_nitirawa@quicinc.com>, <quic_bhaskarv@quicinc.com>,
<kernel@oss.qualcomm.com>
Subject: Re: [PATCH V2] mmc: sdhci-msm: Ensure SD card power isn't ON when card removed
Date: Wed, 25 Jun 2025 13:25:09 +0300 [thread overview]
Message-ID: <a142960d-d30f-4845-86d3-a2b2888f1907@intel.com> (raw)
In-Reply-To: <61cffc10-3e05-4331-b967-6c01cc03d072@oss.qualcomm.com>
On 21/06/2025 13:59, Konrad Dybcio wrote:
>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
>> index bf91cb96a0ea..97a895d839c9 100644
>> --- a/drivers/mmc/host/sdhci-msm.c
>> +++ b/drivers/mmc/host/sdhci-msm.c
>> @@ -1566,6 +1566,14 @@ static inline void sdhci_msm_complete_pwr_irq_wait(
>> wake_up(&msm_host->pwr_irq_wait);
>> }
>>
>> +static int get_cd(struct sdhci_host *host)
>> +{
>> + struct mmc_host *mmc = host->mmc;
>> + const struct mmc_host_ops *mmc_ops = READ_ONCE(mmc->ops);
> What do you need the READ_ONCE for?> +
Yeah I was confusing it with bus_ops. READ_ONCE() is not needed.
sdhci already assumes mmc->ops->get_cd always exists, so
separate get_cd() is not much use.
With that and cosmetic changes, you can add:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
next prev parent reply other threads:[~2025-06-25 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 9:03 Sarthak Garg
2025-06-21 10:59 ` Konrad Dybcio
2025-06-25 10:25 ` Adrian Hunter [this message]
2025-07-01 6:52 ` Sarthak Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a142960d-d30f-4845-86d3-a2b2888f1907@intel.com \
--to=adrian.hunter@intel.com \
--cc=kernel@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_bhaskarv@quicinc.com \
--cc=quic_cang@quicinc.com \
--cc=quic_nguyenb@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=quic_pragalla@quicinc.com \
--cc=quic_rampraka@quicinc.com \
--cc=quic_sartgarg@quicinc.com \
--cc=quic_sayalil@quicinc.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®