From: Jyri Sarha <jsarha@ti.com>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>, <tomi.valkeinen@ti.com>,
<airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm: tilcdc: tilcdc_tfp410: make of_device_ids const.
Date: Mon, 3 Jul 2017 23:36:45 +0300 [thread overview]
Message-ID: <a143234a-b482-cb58-9ed2-8019baf503f7@ti.com> (raw)
In-Reply-To: <c26d4f2a89e7658942f903f4a25f002135cf6c6a.1498628403.git.arvind.yadav.cs@gmail.com>
On 06/28/17 08:42, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 1496 592 0 2088 828 drivers/gpu/drm/tilcdc/tilcdc_tfp410.o
>
> File size after constify:
> text data bss dec hex filename
> 1880 176 0 2056 808 drivers/gpu/drm/tilcdc/tilcdc_tfp410.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Thanks, I pick this up and push it in next merge window (for 4.14).
However, both this and the bundled panel driver is going away as soon as
I have time to do it, but it is unlikely to happen before v4.14.
Best regards,
Jyri
> ---
> Changes in v1:
> Subject was not correct.
>
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index aabfad8..236ca1e 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -290,8 +290,6 @@ static int tfp410_modeset_init(struct tilcdc_module *mod, struct drm_device *dev
> * Device:
> */
>
> -static struct of_device_id tfp410_of_match[];
> -
> static int tfp410_probe(struct platform_device *pdev)
> {
> struct device_node *node = pdev->dev.of_node;
> @@ -376,7 +374,7 @@ static int tfp410_remove(struct platform_device *pdev)
> return 0;
> }
>
> -static struct of_device_id tfp410_of_match[] = {
> +static const struct of_device_id tfp410_of_match[] = {
> { .compatible = "ti,tilcdc,tfp410", },
> { },
> };
>
prev parent reply other threads:[~2017-07-03 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 5:42 Arvind Yadav
2017-07-03 20:36 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a143234a-b482-cb58-9ed2-8019baf503f7@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=arvind.yadav.cs@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®