From: Carl Vanderlip <quic_carlv@quicinc.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: Oded Gabbay <ogabbay@kernel.org>, <linux-arm-msm@vger.kernel.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] accel/qaic: silence some uninitialized variable warnings
Date: Thu, 11 May 2023 08:34:34 -0700 [thread overview]
Message-ID: <a144e830-acf8-55c6-c323-d049095e9fac@quicinc.com> (raw)
In-Reply-To: <d11ee378-7b06-4b5e-b56f-d66174be1ab3@kili.mountain>
On 5/3/2023 3:41 AM, Dan Carpenter wrote:
> Smatch complains that these are not initialized if get_cntl_version()
> fails but we still print them in the debug message. Not the end of
> the world, but true enough. Let's just initialize them to a dummy value
> to make the checker happy.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
LGTM
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
next prev parent reply other threads:[~2023-05-11 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 10:41 Dan Carpenter
2023-05-10 14:57 ` Jeffrey Hugo
2023-05-10 16:48 ` Dan Carpenter
2023-05-16 19:24 ` Jeffrey Hugo
2023-05-11 15:34 ` Carl Vanderlip [this message]
2023-05-11 19:46 ` Pranjal Ramajor Asha Kanojiya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a144e830-acf8-55c6-c323-d049095e9fac@quicinc.com \
--to=quic_carlv@quicinc.com \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®