From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Sean Anderson" <sean.anderson@seco.com>
Cc: linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: timer: xlnx,xps-timer: Make PWM in example usable
Date: Wed, 28 May 2025 09:43:48 +0200 [thread overview]
Message-ID: <a14be34c-de2a-4bea-9282-1fac7780b9a4@kernel.org> (raw)
In-Reply-To: <20250527171504.346696-2-u.kleine-koenig@baylibre.com>
On 27/05/2025 19:15, Uwe Kleine-König wrote:
> With #pwm-cells = <0> no usable reference to that PWM can be created.
> Even though a xlnx,xps-timer device only provides a single PWM line, Linux
> would fail to determine the right (pwmchip, pwmnumber) combination.
>
> Fix the example to use the recommended value 3 for #pwm-cells.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Documentation/devicetree/bindings/timer/xlnx,xps-timer.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
And what about the binding itself? It allows any arbitrary value.
Setting it to const=3 would not break the ABI, as long as driver does
not care.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-28 7:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 17:15 Uwe Kleine-König
2025-05-27 17:25 ` Sean Anderson
2025-05-28 7:43 ` Krzysztof Kozlowski [this message]
2025-06-03 17:41 ` New default binding for PWM devices? [Was: Re: [PATCH] dt-bindings: timer: xlnx,xps-timer: Make PWM in example usable] Uwe Kleine-König
2025-06-06 14:13 ` Rob Herring
2025-06-06 14:57 ` Uwe Kleine-König
2026-03-30 12:12 ` Geert Uytterhoeven
2026-03-31 7:03 ` Uwe Kleine-König
2026-03-31 7:15 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a14be34c-de2a-4bea-9282-1fac7780b9a4@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sean.anderson@seco.com \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome