mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Doug Ledford <doug.ledford@hpe.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>
Cc: Slingshot Open Source Team <slingshot-os-team@groups.ext.hpe.com>,
	<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Iraimani P <iraimani.pavadai@hpe.com>,
	Mamila Santosh <santosh-kumar.mamila@hpe.com>
Subject: Re: [PATCH 00/11] Subject: [PATCH for-next 00/11] RDMA/cxi: add the HPE Cassini verbs driver
Date: Wed, 4 Nov 2026 08:17:22 -0800	[thread overview]
Message-ID: <a14c59c0-d523-4399-96b2-72f84b883ef4@hpe.com> (raw)
In-Reply-To: <20261104095424.GC478286@unreal>


[-- Attachment #1.1: Type: text/plain, Size: 2486 bytes --]

On 11/4/26 1:54 AM, Leon Romanovsky wrote:
> On Tue, Nov 03, 2026 at 10:30:04AM -0400, Jason Gunthorpe wrote:
>> On Tue, Nov 03, 2026 at 04:28:26PM +0200, Leon Romanovsky wrote:
>>> On Fri, Oct 30, 2026 at 09:35:28PM -0700, Doug Ledford wrote:
>>>> This series adds cxiverbs, an RDMA driver for the HPE Slingshot Cassini
>>>> NIC. It exposes the NIC through the verbs API using the UET reliable
>>>> unconnected (RU) queue pair type from the UET RDMA core series.
>>>>
>>>> cxiverbs does not drive the hardware itself. It is an auxiliary bus
>>>> client of the cxi-ss1 Cassini core driver and does everything through
>>>> that driver's exported CXI interface.
>>>
>>> <...>
>>>
>>>> Before posting, the series was reviewed with the Sashiko AI code
>>>> review tool and checkpatch. All valid findings are fixed, except the
>>>> open items listed above.
>>>
>>> <...>
>>>
>>>> ---
>>>> base-commit: 306a2f8432f516069b2e673de7a07043132c034f
>>>
>>> Sashiko failed to apply this series as this base-commit doesn't exist.
>>> ➜  kernel git:(wip/leon-for-rc) git show 306a2f8432f516069b2e673de7a07043132c034f
>>> fatal: bad object 306a2f8432f516069b2e673de7a07043132c034f
>>>
>>> https://sashiko.dev/#/patchset/20261030-cxi-for-next-v1-0-bc6e49e07037@hpe.com
>>>
>>> Please make sure that upstream sashiko runs on it too.
>>
>> I don't think he can, it relies on the core code series. I Don't know
>> how to instruct sashiko how to find another series to stich it
>> together
> 
> This may be a radical, unheard-of suggestion, but how about merging another
> series before sending follow-ups?

Well, we're caught in the "no dead code" rule trap.  Can't merge the UET
code because it has no consumer, and can't merge ours without it as a
consumer, so I have to make my branch based on their branch, and their
merge base went away.  They'll have to rebase and then I'll have to
rebase on theirs again.  But I expected a v3 for their code anyway, so
just whenever Eric gets around to fixing the Sashiko findings and
posting v3, I can rebase on that, and then the sashiko prompts can be
run.  But, FWIW, since the rdma portion of our submission was all brand
new code, it passed checkpatch and sashiko on our end.  It's the
existing code in the netdev tree that's where all the fun will be :-/.

-- 
Doug Ledford <doug.ledford@hpe.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2026-11-04 16:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31  4:35 Doug Ledford
2026-10-31  4:35 ` [PATCH 01/11] RDMA/core: read selected counters with timestamps Doug Ledford
2026-10-31  4:35 ` [PATCH 02/11] RDMA/core: allow jobs without an address table Doug Ledford
2026-10-31  4:35 ` [PATCH 03/11] RDMA/core: add Slingshot identifiers and driver-owned GIDs Doug Ledford
2026-10-31  4:35 ` [PATCH 04/11] RDMA/cxi: add the native ABI and resource definitions Doug Ledford
2026-10-31  4:35 ` [PATCH 05/11] RDMA/cxi: add the auxiliary device and driver ops Doug Ledford
2026-10-31  4:35 ` [PATCH 06/11] RDMA/cxi: add explicit context LNI and PID lifetimes Doug Ledford
2026-10-31  4:35 ` [PATCH 07/11] RDMA/cxi: add VNI-isolated queue pairs Doug Ledford
2026-10-31  4:35 ` [PATCH 08/11] RDMA/cxi: add native memory registration Doug Ledford
2026-10-31  4:35 ` [PATCH 09/11] RDMA/cxi: add services jobs profiles queues and counting triggers Doug Ledford
2026-10-31  4:35 ` [PATCH 10/11] RDMA/cxi: read the NIC telemetry through counters Doug Ledford
2026-10-31  4:35 ` [PATCH 11/11] RDMA/cxi: wire the driver into the build Doug Ledford
2026-11-03 14:28 ` [PATCH 00/11] Subject: [PATCH for-next 00/11] RDMA/cxi: add the HPE Cassini verbs driver Leon Romanovsky
2026-11-03 14:30   ` Jason Gunthorpe
2026-11-04  9:54     ` Leon Romanovsky
2026-11-04 16:17       ` Doug Ledford [this message]
2026-11-04 16:14     ` Doug Ledford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a14c59c0-d523-4399-96b2-72f84b883ef4@hpe.com \
    --to=doug.ledford@hpe.com \
    --cc=iraimani.pavadai@hpe.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=santosh-kumar.mamila@hpe.com \
    --cc=slingshot-os-team@groups.ext.hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®