From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BF3A41C2EA for ; Mon, 15 Jun 2026 17:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781545211; cv=none; b=IKzNJltXqCOf9W8lFD6IbZZVqJX9kpg7pzJ0mlbpfyYeCKQr0Tr45Kd9dIpWgPMRaBnGlQsh3HmGQCxu1cMrXKHBx07UHVCMTJ4qiDRu86FlU4W7O09W7jMSf+GUGvOg2R6veGXaSB03wUwflihh7oTbyXzkx/k6KkGfRQZ/E7k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781545211; c=relaxed/simple; bh=cgDCf60D1ZNChtIqUC1HmxRm6m46wBrGxdjrgS0ByM4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AvEKDU3FyaeqXf/MOssgsoTjYNKA1QfZVjLjorPRq3jrvvnNFNlktP/nZT9G5DS165mNGb+oJRYjUFB50e9fzoH8M9wU/e9svz0y4SemOa0Y/OIEyXEi3yw9Lr3VbgYvW/l6rc2XAV9R80VaXJyVOGRYaXNVKi+pB43ZQ8Ptdlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=j0pG1wD+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T0q5QVu1; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="j0pG1wD+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T0q5QVu1" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65FFhfmr3140081 for ; Mon, 15 Jun 2026 17:40:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mvFd73ztF1fu1Rm+GMEjLFt0KdftVYS/vwYiR9FM/dw=; b=j0pG1wD+m2K1K0m0 7nG9hYcZJyCznKklM6qJL1+5SUqyBdkzjaEM6LKhuDKAtKBIFzz+FVyXGMGK4K+e 9gG96BrUzHVaWO5lQSgaOf21xlEDY+NR+ja19NMMuSVMNkznHv63J1rWwHk6eBD1 z1gwOwi2/GXXtOP1OHeyWyCYIIgGogsPi/vogtl/bsJWWh7hGgyN001UDRQN02ph M0/5JPdM54+VqmOqnwbLnthxFKJ/xZTmzw8QlmulPxQSAt767rBVADUhC85Q8wwj iOhYfeUCfaG1N7DR4DdyLKoZypfj/qKbKjU7JUQqIjErdBizHbweNT61xhsirFja hfD6aw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ete9828d7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Jun 2026 17:40:09 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-36b982ec27aso2620332a91.1 for ; Mon, 15 Jun 2026 10:40:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781545209; x=1782150009; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mvFd73ztF1fu1Rm+GMEjLFt0KdftVYS/vwYiR9FM/dw=; b=T0q5QVu19S9ukJmjwZaViVMuqDrdIiXuf0HbxnaBljbpXkuEnPcGUNidM9v2Mo2WGz gB5UmE71AdpzJzHwPFnPLV8qYAIHtMz41h/zh6Lb7mDtrBr4EcMNNLDk26DMXje8UfIc SyQjpuyGiQ+nAnT5apoRhJENurWgJsHRsSO6ZK39EP59yiF2vnGjiiVWP/ceyNERfvUS cxySpmJFBOTNef1IoQZxmO2SXQoTWPr+32UITBQph8nC3bLyA8VTWbRhm/nmyLIh4smq LaQun6zitF2ie90NnIEhNZ9bdbTym80iIm8d4GKmMLgUy2nnJqiUjqKrse9C/P0B0f2i fMAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781545209; x=1782150009; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mvFd73ztF1fu1Rm+GMEjLFt0KdftVYS/vwYiR9FM/dw=; b=QCBISpXPxVJrHgZrJamrvHyiFVDlPbWb50l+EOeiZoPGcxFNQgGcCqWDjVLInEmVKJ huyhFu5LmXXGbrR+7kLsAuJA6kW/qraezRBlC3CLI/kgl6eANYSFf56OaYdQ7flhd3dr XedaSgpi7m302PWChxtlzBW1nWdPb3BPL3rQDSp1kDsm2DVLSV5edYuVtK0nOMjYM00A oR6bDtXgb3YbpSX49RQOjqfE8Dl/BluQAj4Y3Buow7OcarhT4R9T1y8qbQAHYvALcZ02 8Z9dz017sD9pdv97ixubrezJuMGf3A/l0nKACGlm7T9IMiaQXE2i/zTQl8R+tJsyq+GV Ihbw== X-Forwarded-Encrypted: i=1; AFNElJ9NuSinxNtuAiVfBi41pShyjthy3xRuKiHCQ2tETCDRfH9QYRN+xMPgAj8cEbToB2s/3c4wSU73FTEUnz4=@vger.kernel.org X-Gm-Message-State: AOJu0YzcSm2n1FP308MNxfIGioHTppKsod/2vYAe/JNU82Du37Cgj9FC gCwsLqii+VWVMBXemFUE6T4396UlcUNSOCs9IgaXmxIhFuwa5pXAAUZA42LgHOe5yHVSm210gwT s4/tBvAhOqnxNOSgqcwFNyEynLedT+caUuNZtrnIX0RiN3d3fXVZ6TMXbjV43yEgOUXM= X-Gm-Gg: Acq92OFO+oKpGC6S+VqQn69pnv/m2eWsb0RUP/ZyCu/fXyfbY6k3gJdkqSSRDKl5gBH dl5ziS2IL9CgA7GbI2fvzPbwz7JMjtrJ9QFqiWJ8ZkmazWx46SN8UCZMWUlzK/MgyTVkfH46wA8 y+VjwqM0ohK0KushXn7YDnNv8dJre4Ex6uL4gBRwOsIiCTChjlZg1w57G/FprgqBgauXmxM95HD 9ryBRE0AG7yvh2E+avtImIbjTljCWgHmmzWfQHtriwGdzHgnJVed+P0wAZRrYJ3ZwGNR2P5T1Ga 5n21mnJbiulVe7aFKBkAHdoathi9e/5/ZazBPovvzb8B7jI+sgZtPp3uykchrYlKwIJfMIXPBJG Y0A4XH1afQoIfzhbG7Ve8C5BN8ElHBHzWu01Wp3ti6CDqdW+Sm/dVPxHmCsnnOPTZ6A== X-Received: by 2002:a17:90b:51c4:b0:377:424b:59e3 with SMTP id 98e67ed59e1d1-37c2bd5c7f3mr11720615a91.24.1781545208981; Mon, 15 Jun 2026 10:40:08 -0700 (PDT) X-Received: by 2002:a17:90b:51c4:b0:377:424b:59e3 with SMTP id 98e67ed59e1d1-37c2bd5c7f3mr11720591a91.24.1781545208484; Mon, 15 Jun 2026 10:40:08 -0700 (PDT) Received: from [192.168.1.48] ([122.164.85.44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-379e7b2c312sm6933191a91.1.2026.06.15.10.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Jun 2026 10:40:07 -0700 (PDT) Message-ID: Date: Mon, 15 Jun 2026 23:10:02 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] regulator: qcom-refgen: add support for the IPQ9650 SoC To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dmitry Baryshkov References: <20260615-ipq9650_refgen-v3-0-5f611623629c@oss.qualcomm.com> <20260615-ipq9650_refgen-v3-3-5f611623629c@oss.qualcomm.com> <737655dd-2059-421d-a9ca-91ebd1b1209b@sirena.org.uk> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=V5tNF+ni c=1 sm=1 tr=0 ts=6a3038f9 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=BchUXt3FRQcObq55vMoYrw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=3IG1bLz3NaerdrZfOx0A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: JDCc1OyVIwacRKMrq39dkh3rfUwYItOL X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE1MDE4NyBTYWx0ZWRfX124pvr1fKuAZ LbVcd+DtBwAs7AswRCyP7ixMToRT50SLPZbXc7ASjsjXjXVUpGXpsc2zM00nkLwn1tcLxy1jA4z TTpg52A/BUyeiopKEyyTL/NMQxZVPrI= X-Proofpoint-ORIG-GUID: JDCc1OyVIwacRKMrq39dkh3rfUwYItOL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE1MDE4NyBTYWx0ZWRfX3JZteL/SpCmm QLzNrypoZtJnHi5ynsvkCIttEtGf6ppC7iQrqKAZdDsqfKihCQuP++CYIoUFVUGMN731aPvkber pzd4C+BoOU62ioprwEcZOTDYzd6jGOlgeu+1acTZ8q+f5ox49EBHrlhiDOUjVETmLUxr48I0ZIh QuxVUXsn9aohsC5VT1fDwN4r//N+k2h7ziXANIxnQyBfz0Q3wC6uKY4Fa0JLcn4G2zma66M7F13 gmbjd8Kwxwjn5ebTo1oZYpKGtdEJ+yEwMxOcFQWjrrDIgRJsBPI3nc/lCzhKRDcWE2zYyXttR2v ByD2W6SaVMFfyRvWzwccVzPra7WBSih/I2eiKYHBXztEmT8wDeb9Dlr9SGQygls5V8SaRDzz1B6 YNl4w7x2LKTcPJ3ByIrLp3k8leqLQfoeOfBTQvkGQOIJyifFhMUwKo2JxHPozKeenipXs7BhYCz rM78DUmZTJrPHbLrWjw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-15_04,2026-06-15_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 phishscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606150187 On 6/15/2026 11:01 PM, Mark Brown wrote: > On Mon, Jun 15, 2026 at 10:54:26PM +0530, Kathiravan Thirumoorthy wrote: >> On 6/15/2026 9:28 PM, Mark Brown wrote: >>> This looks like a get_status() operation, not an enable operation? The >>> enables and disables are pure clock operations. >> Thanks, Mark for the review. If I understand correctly, I should track the >> clock enable/disable operations and return that state in the is_enabled() >> callback (as I did in v1). Please let me know if my understanding does not >> align with your expectations. > Yes. If as it seems the device can actually implement a get_status() > operation the driver should do that as well. Thanks Mark. I shall introduce get_status() with STATUS register read back and update the is_enabled() to track the clock enable / disable operation.