From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3D4C4332F for ; Mon, 21 Nov 2022 10:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbiKUKxf (ORCPT ); Mon, 21 Nov 2022 05:53:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiKUKxb (ORCPT ); Mon, 21 Nov 2022 05:53:31 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C45A1F2FC for ; Mon, 21 Nov 2022 02:53:30 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id i10so27549305ejg.6 for ; Mon, 21 Nov 2022 02:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=blackwall-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oVR9zxWFI/yiTfyZ4zmDueQDkqj32nHPs9Uh0PG4vPE=; b=KOwk43K2prxMCTWU5zSDoD7OjmzMBpZe59DoyncDt6F+Tc+Qtsvgf+G5R0i17IT+Nj 3gvfVY0T0UI3OCVP31Cq8Ar0xgsEjJD4bJn5jEFhuvh0dEd7Z0nFgvwKuA6na0brxsD4 YoLyr+iMi5GVBqKJsZYB1KlyEU41+29Va65MF/LNUJq3dEJA2A0PSFCdO1UnYKiKH8TK A1o6q7JMNuSS3kDcOWAHOUt3HLy6qmD3lSiknCa1sZtShQ0PMymnlJxVg1/gfvzGsVIs kCydES3mx6bQxzdRK2QcZgTLQLu68suH5cg2TxcFPmrtS7oFhHTx4ZIoeyyF9xHVJA7E 1yMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oVR9zxWFI/yiTfyZ4zmDueQDkqj32nHPs9Uh0PG4vPE=; b=aHSkKgBbUfQH1Jqvn7u0IVhK7i1+0DWfwAbIVSff9BF1PLCWAS6G3M3BZcJxMq0FJV 2Vs3qycXkjtwuYlL7pUiYHadE51DSiF3SXLmHKYeNmUvw6IyTKYoiK/87iklg9p2KbSf GwqV0sIjWUhP+MZnru0Ls61tv3+AUmlqgIpTObICo2hCQXR1BgMMS0Jz+GmKFWAV8jXS 9gdezftE95gbDjbn4eytq4StH9/rNG/6o5pDtfjZ7xFfmHHh7/s7kfsr9TGQCaV/ekA4 Uaqv8JXPaMpjQNDJX//ZHbv/8ACRmokO5jg8BTlKWF9IAy18UK9hKLbA0Ez71pNvXuSJ PdiA== X-Gm-Message-State: ANoB5pkUExkNi2FAKDbmuLQqIWkRVp1jEZpmlk3R3e7VO5Siw59Jxu0w 7wWraOoS7SQ+8+a8qVCrkzSbvQ== X-Google-Smtp-Source: AA0mqf70BnFvfvb0IuSIgQsK2SzIyUkBrZLyuZoXrSWjPOnvQcHmbXrvzYpC3wtlID8hDdv5F+6kMg== X-Received: by 2002:a17:906:81c4:b0:78d:9858:e538 with SMTP id e4-20020a17090681c400b0078d9858e538mr15153542ejx.502.1669028008557; Mon, 21 Nov 2022 02:53:28 -0800 (PST) Received: from [192.168.0.161] (79-100-144-200.ip.btc-net.bg. [79.100.144.200]) by smtp.gmail.com with ESMTPSA id i17-20020aa7c9d1000000b004638ba0ea96sm4962888edt.97.2022.11.21.02.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 02:53:25 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 12:53:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH 1/5] kobject: make kobject_get_ownership() take a constant kobject * Content-Language: en-US To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Trond Myklebust , Anna Schumaker , Roopa Prabhu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, bridge@lists.linux-foundation.org, netdev@vger.kernel.org References: <20221121094649.1556002-1-gregkh@linuxfoundation.org> From: Nikolay Aleksandrov In-Reply-To: <20221121094649.1556002-1-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/11/2022 11:46, Greg Kroah-Hartman wrote: > The call, kobject_get_ownership(), does not modify the kobject passed > into it, so make it const. This propagates down into the kobj_type > function callbacks so make the kobject passed into them also const, > ensuring that nothing in the kobject is being changed here. > > This helps make it more obvious what calls and callbacks do, and do not, > modify structures passed to them. > > Cc: "Rafael J. Wysocki" > Cc: Trond Myklebust > Cc: Anna Schumaker > Cc: Roopa Prabhu > Cc: Nikolay Aleksandrov > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Chuck Lever > Cc: Jeff Layton > Cc: linux-nfs@vger.kernel.org > Cc: bridge@lists.linux-foundation.org > Cc: netdev@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/base/class.c | 2 +- > drivers/base/core.c | 8 ++++---- > fs/nfs/sysfs.c | 4 ++-- > include/linux/kobject.h | 8 ++++---- > lib/kobject.c | 4 ++-- > net/bridge/br_if.c | 2 +- > net/core/net-sysfs.c | 8 ++++---- > net/sunrpc/sysfs.c | 8 ++++---- > 8 files changed, 22 insertions(+), 22 deletions(-) > For the bridge: Acked-by: Nikolay Aleksandrov