From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00B231D4606 for ; Fri, 2 Oct 2026 19:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790970989; cv=none; b=B1FPJtbvGlaR8k4x41nNzgXbhf/tI+JBZY0pXc4i6CdIjvZqYPkUj0x8cf/LOTXTfMoCqHPz/3oBzON96uRWXBgYOqDCQwC0G+OIfBJquYB8AZL7KGnjEHFWrtgZL+eVvQUJrFv2vmktOSdxgjMbzEmrY5dLTK2HiqeOrBexK/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790970989; c=relaxed/simple; bh=RAm0gUhki2pqljTZWQr8CrgmhZ5p9hcCadzRxn5CSGM=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ugU+iYx1a0QNn22BkfqYG0X1ZR8HZOqMCQJQ/1kvTqSaZRDzBEzzQ7Kr9cxfPsTO31AS2G8apWNWKnQtJCmXpMRZ+THFl2T+0skcMo99lAxpe+k7DmVkiYVuMzhXVf6qY2YnPy0XzYrIXYIvyxFPsTePccxMTsg39uICx89l/wY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca; spf=pass smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20251104.gappssmtp.com header.i=@ndufresne-ca.20251104.gappssmtp.com header.b=kllv/0IM; arc=none smtp.client-ip=209.85.219.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20251104.gappssmtp.com header.i=@ndufresne-ca.20251104.gappssmtp.com header.b="kllv/0IM" Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-917aca1aee5so1775516d6.2 for ; Fri, 02 Oct 2026 12:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20251104.gappssmtp.com; s=20251104; t=1790970985; x=1791575785; darn=vger.kernel.org; h=mime-version:user-agent:content-type:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NJl6vN2DYWl5SvECY/MNPFkAoXMpLzutrBdwcjZxYRo=; b=kllv/0IM3PbW8aScYN2euRWeTP2DK5sSB7+A8+NESTWA+J9dfxdnQyrrOR8BIMzAxq I6eh3op+3Btg/hJs7zmF62amZuH00b+DtxjGJ66yprzE6SR6wSpuSAfznWhwgWqjym6H qoBR1X/S1f/KSKsNIWORLKzHg/Q5gY9VTFzLAprQxfvlfwWV5eB2k4X4UhONu7ZgwYfa WvoaIvKUUZ1Wv6q/G6dCGC3nJ75ayuP4ZNJxJg5FuCVHnMia6oTlwP48WhingQwBjWFl Od3Ne/miqBBeaXEc19fisWlDlOwxfwMM//fITp96BMR/p2kGs4AOIkS9yACwScaGz1xX kHgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790970985; x=1791575785; h=mime-version:user-agent:content-type:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NJl6vN2DYWl5SvECY/MNPFkAoXMpLzutrBdwcjZxYRo=; b=jKGqMmSAPzKPewNnw9tFr03AF1+WACSocVRRzRGSrtWt68Loy5C3ZHv8/7XPl1wynq 2GSlHCvndBI7W3MSqmQAItcBsDdJtLYrrFb5hDC6yIFTydxr7VZl3xpLhLC9tCuvCSoN G2MM7aU+De+z5oMYKR/kC4S4fzRA6q1jNmgbf9XWkwoJxNn3srEGSrf2rUzgO15Y+9/k 0bG04lDVVajSxDbdbNKTY26zTRgjPXdlBtmuqx+3krEYWrS9likmsoEx3+M3+kTiPdof e0fZaa72kvGrQjQD1fwzHLePemRP4W31a61MZaqxLuQHiy/jRSrREWeN4t5MsNpy+rv7 QyPA== X-Forwarded-Encrypted: i=1; AKwUvByoVX3rq3wg9wCraNVS/8uGNlbIUQinaYXPuwbg3ydh4KTET3WnJIQLoIN/fTu5iQxg9U94vLU2fd3loTA=@vger.kernel.org X-Gm-Message-State: AFuF++n1KiUpAN6oByPN4WxK2AqJlxddZ9WsC4mhT3J2aAGn80mwpfIg XUAmSnMxUKvKrwh2H2EQkeoRain0SvqbZUIuH4/swdRwzgzMxOycfn3yOzbXLb5OcZR2UXDePlM 5glR9eSo= X-Gm-Gg: AYBFou0mOLKv5tSOGhSqcdGBDMqhGxLZT/EF+7qaIzLQS/tYGl7a6iIwDF0cb0i5WvF yE2fbD9gJP1d1KM9FVmNsEtmy6J9ZHS0GB1XGYiZR4CGbVafG1PyGVzspY9p/OK1vyyZG07Jmgk XtU9dO6U/q5SEQxmk+7qTywMdAjkJ5jLgbE6IXUoZ9rq+4rn5TBaVjyclQvLRc9AWsovLaXKGot FkF6oSI0ElJo4p6sawUvt3j/WydHo4pL+JHx/DU0QY9z5NjZxU+uEx9nvPXX5Ascz4Lf5Mtc/ey Arkuz1fmCRqqQyFEib6IrfPBANJ1Epiq96w1RauuzDg8lFuossFThKzM5sjheOIWz7l3TtIRZna 4IhNE0sECjJk46fasYlLWYfhRaOW9ekyLbWGuSFF8mf7NMk9SR8dOL2OS8+2Hjo77JCcyavC49m pG3pQGP9cnkx+7L/hnjBMkaSbpiwweBKBvTGB6/dF0SqNuH8FLKxt+LtG/dXPJRPFV1gNi378Tw dfRLeWUmsnY+g== X-Received: by 2002:a05:620a:6413:b0:93c:b766:2bfc with SMTP id af79cd13be357-93e50fa6a3dmr87378085a.17.1790970985078; Fri, 02 Oct 2026 12:56:25 -0700 (PDT) Received: from ?IPv6:2606:6d00:11:34bd::5ac? ([2606:6d00:11:34bd::5ac]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-917e0c17b8esm27137276d6.43.2026.10.02.12.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 12:56:24 -0700 (PDT) Message-ID: Subject: Re: [PATCH 2/3] media: rockchip: rga: Switch to modern PM_OPS From: Nicolas Dufresne To: Diederik de Haas , Dafna Hirschfeld , Laurent Pinchart , Mauro Carvalho Chehab , Heiko Stuebner , Detlev Casanova , Ezequiel Garcia , Jacob Chen Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Fri, 02 Oct 2026 15:56:23 -0400 In-Reply-To: <20261001173610.158931-3-diederik@cknow-tech.com> References: <20261001173610.158931-1-diederik@cknow-tech.com> <20261001173610.158931-3-diederik@cknow-tech.com> Autocrypt: addr=nicolas@ndufresne.ca; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-1Mpu87nLgk5Us+/k4nVo" User-Agent: Evolution 3.60.2 (3.60.2-2.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-1Mpu87nLgk5Us+/k4nVo Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeudi 01 octobre 2026 =C3=A0 19:34 +0200, Diederik de Haas a =C3=A9crit= =C2=A0: > A new set of modern PM_OPS macros got defined in commit > 1a3c7bb08826 ("PM: core: Add new *_PM_OPS macros, deprecate old ones") >=20 > Switch to those new macros so that the PM callbacks are always seen by th= e > compiler, but discarded if not used. This lets us drop the __maybe_unused > annotation from the callback functions. >=20 > Signed-off-by: Diederik de Haas Reviewed-by: Nicolas Dufresne > --- > drivers/media/platform/rockchip/rga/rga.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/pl= atform/rockchip/rga/rga.c > index b3cb6bf8eb86..f28c93d63760 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -883,7 +883,7 @@ static void rga_remove(struct platform_device *pdev) > pm_runtime_disable(rga->dev); > } > =20 > -static int __maybe_unused rga_runtime_suspend(struct device *dev) > +static int rga_runtime_suspend(struct device *dev) > { > struct rockchip_rga *rga =3D dev_get_drvdata(dev); > =20 > @@ -892,7 +892,7 @@ static int __maybe_unused rga_runtime_suspend(struct = device *dev) > return 0; > } > =20 > -static int __maybe_unused rga_runtime_resume(struct device *dev) > +static int rga_runtime_resume(struct device *dev) > { > struct rockchip_rga *rga =3D dev_get_drvdata(dev); > =20 > @@ -900,8 +900,7 @@ static int __maybe_unused rga_runtime_resume(struct d= evice *dev) > } > =20 > static const struct dev_pm_ops rga_pm =3D { > - SET_RUNTIME_PM_OPS(rga_runtime_suspend, > - rga_runtime_resume, NULL) > + RUNTIME_PM_OPS(rga_runtime_suspend, rga_runtime_resume, NULL) > }; > =20 > static const struct of_device_id rockchip_rga_match[] =3D { > @@ -927,7 +926,7 @@ static struct platform_driver rga_pdrv =3D { > .remove =3D rga_remove, > .driver =3D { > .name =3D RGA_NAME, > - .pm =3D &rga_pm, > + .pm =3D pm_ptr(&rga_pm), > .of_match_table =3D rockchip_rga_match, > }, > }; --=-1Mpu87nLgk5Us+/k4nVo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCasAMZwAKCRDZQZRRKWBy 9Nm3AP4y8JqQZKv9U0OttedqiWp5M0Ofbzvm9AyImGL7/X3BggEA6Av0uZd+Ipgu Sn0DcrUr/Ux6st7B3vMRPFDOud8b9gM= =w8WG -----END PGP SIGNATURE----- --=-1Mpu87nLgk5Us+/k4nVo--