From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA568C77B76 for ; Fri, 14 Apr 2023 10:48:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230303AbjDNKsf (ORCPT ); Fri, 14 Apr 2023 06:48:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbjDNKsd (ORCPT ); Fri, 14 Apr 2023 06:48:33 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B4AE59C5; Fri, 14 Apr 2023 03:48:32 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 4516766031C9; Fri, 14 Apr 2023 11:48:22 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681469303; bh=FylSFIVBnE7RXP+PfgYkJCcaPRTztLjwILG6wpZ/BJI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UWo5Cr6rDZb6UXxn1c6QDkxl9wIWtGPQLHecpLErzGMSW/rLafm9chY1DQnmoIMGs mZ2GeVL5CidyylhE9IjbRidVWkPbFCxkf2vqWTeTfheeHsv6/DJu9JizqbuKfPYwVn no5tVt4CEjnHDUiaidhbEgKcqnfTsR99dKJiDgnRNFbivJIe7X/L2E+GVomWh2F+YQ JCzw8msfQdsrDlwydHVaHsU0je0J7SKtykzZItKwVuDcEtyov2KoZZCb/LtUs0vJy8 gj6FVTIQzoNtgbybuhAXQJlDmHsmGlt3jfYW98XrqcAlzWIZNFjqea5bIUOdaVLid8 rXd9P/7vM5Cdg== Message-ID: Date: Fri, 14 Apr 2023 12:48:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v1 3/6] soc: mediatek: virt: geniezone: Introduce GenieZone hypervisor support Content-Language: en-US To: =?UTF-8?B?WWktRGUgV3UgKOWQs+S4gOW+tyk=?= , "corbet@lwn.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski@linaro.org" , "catalin.marinas@arm.com" , "krzysztof.kozlowski+dt@linaro.org" , =?UTF-8?B?WWluZ3NoaXVhbiBQYW4gKOa9mOepjui7kik=?= , "matthias.bgg@gmail.com" , "will@kernel.org" Cc: "linux-kernel@vger.kernel.org" , "linux-mediatek@lists.infradead.org" , =?UTF-8?B?TVkgQ2h1YW5nICjojormmI7ouo0p?= , "devicetree@vger.kernel.org" , =?UTF-8?B?UGVpTHVuIFN1ZWkgKOmai+WfueWAqyk=?= , =?UTF-8?B?TGlqdS1jbHIgQ2hlbiAo6Zmz6bqX5aaCKQ==?= , =?UTF-8?B?SmFkZXMgU2hpaCAo5pa95ZCR546oKQ==?= , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?B?U2hhd24gSHNpYW8gKOiVreW/l+elpSk=?= , =?UTF-8?B?TWlsZXMgQ2hlbiAo6Zmz5rCR5qi6KQ==?= , "linux-doc@vger.kernel.org" , =?UTF-8?B?SXZhbiBUc2VuZyAo5pu+5b+X6LuSKQ==?= , =?UTF-8?B?WmUteXUgV2FuZyAo546L5r6k5a6HKQ==?= References: <20230413090735.4182-1-yi-de.wu@mediatek.com> <20230413090735.4182-4-yi-de.wu@mediatek.com> <1aa701cc-92ca-71be-0663-df4bfae66c2f@linaro.org> <5c1d69c8-d973-fa7b-1f14-c72729ff5594@gmail.com> <533a1a9b653cf63f1e5df7f95d1b23902809561d.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <533a1a9b653cf63f1e5df7f95d1b23902809561d.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 14/04/23 10:43, Yi-De Wu (吳一德) ha scritto: > On Thu, 2023-04-13 at 19:08 +0200, Matthias Brugger wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 13/04/2023 14:55, Krzysztof Kozlowski wrote: >>> On 13/04/2023 11:07, Yi-De Wu wrote: >>>> From: "Yingshiuan Pan" >>>> >>>> GenieZone is MediaTek proprietary hypervisor solution, and it is >>>> running >>>> in EL2 stand alone as a type-I hypervisor. This patch exports a >>>> set of >>>> ioctl interfaces for userspace VMM (e.g., crosvm) to operate >>>> guest VMs >>>> lifecycle (creation, running, and destroy) on GenieZone. >>>> >>>> Signed-off-by: Yingshiuan Pan >>>> Signed-off-by: Yi-De Wu >>>> --- >>>> arch/arm64/include/uapi/asm/gzvm_arch.h | 79 ++++ >>>> drivers/soc/mediatek/Kconfig | 2 + >>>> drivers/soc/mediatek/Makefile | 1 + >>>> drivers/soc/mediatek/virt/geniezone/Kconfig | 17 + >>> >>> Hypervisor drivers do not go to soc. Stop shoving there everything >>> from >>> your downstream. Find appropriate directory, e.g. maybe >>> drivers/virt. >> >> Acked, what is the reason you want to add this to drivers/soc instead >> of >> drivers/virt? >> >> Regards, >> Matthias >> > Noted. We would take your advice and move it from > drivers/soc/mediatek/virt to /drivers/virt on next version. > > The reason we put it under our soc/ is that the drver is highly > propietary for mediatek's product and for aarch64 only. Maybe it's not > general enough to put in under /drivers/virt. This is the same reason why mediatek-drm is in drivers/gpu/drm/ and the same why mediatek-cpufreq is in drivers/cpufreq/. I know that this is a MediaTek specific implementation, but it *is* a hypervisor driver, hence it belongs to the hypervisor drivers folder. It's not even granted that this will not support other MediaTek architectures in the future, but that's not a discussion to do right here and right now, and it's anyway irrelevant in this moment. By the way, good job with upstreaming your drivers targeting MediaTek Android SW! I'm enthusiast to see that. Regards, Angelo