From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbeAEC70 (ORCPT + 1 other); Thu, 4 Jan 2018 21:59:26 -0500 Received: from vern.gendns.com ([206.190.152.46]:42840 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbeAEC7Y (ORCPT ); Thu, 4 Jan 2018 21:59:24 -0500 Subject: Re: [PATCH v4 6/7] ARM: davinci: convert to common clock framework From: David Lechner To: Sekhar Nori , linux-arm-kernel@lists.infradead.org Cc: Kevin Hilman , Adam Ford , linux-kernel@vger.kernel.org References: <1514763588-31560-1-git-send-email-david@lechnology.com> <1514763588-31560-7-git-send-email-david@lechnology.com> Message-ID: Date: Thu, 4 Jan 2018 20:59:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/04/2018 11:50 AM, David Lechner wrote: > > > On 1/4/18 6:39 AM, Sekhar Nori wrote: >> On Monday 01 January 2018 05:09 AM, David Lechner wrote: >>> This converts all of arch/arm/mach-davinci to the common clock framework. >>> The clock drivers from clock.c and psc.c have been moved to drivers/clk, >>> so these files are removed. >>> >>> There is one subtle change in the clock trees. AUX, BPDIV and OSCDIV >>> clocks now have "ref_clk" as a parent instead of the PLL clock. These >>> clocks are part of the PLL's MMIO block, but they bypass the PLL and >>> therefore it makes more sense to have "ref_clk" as their parent since >>> "ref_clk" is the input clock of the PLL. >>> >>> CONFIG_DAVINCI_RESET_CLOCKS is removed since the common clock frameworks >>> takes care of disabling unused clocks. >>> >>> Known issue: This breaks CPU frequency scaling on da850. >> >> This functionality needs to be restored as part of this series since we >> cannot commit anything with regressions. >> > > Do you have a suggestion on how to accomplish this? I don't have a board for testing, so I don't have a way of knowing if my changes will work or not. > >>> >>> Also, the order of #includes are cleaned up in files while we are touching >>> this code. >>> >>> Signed-off-by: David Lechner >> >> This is a pretty huge patch again and I hope it can be broken down. >> Ideally one per SoC converted and then the unused code removal. >> > > Will do. Well, I can do this, but I don't think it will compile or run. We can't have the common clock framework and the legacy davinci clocks enabled at the same time.