From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A086D2D3EE4 for ; Tue, 18 Nov 2025 10:06:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763460384; cv=none; b=miCrlYJr9sm40u8rlRFA8vKEGLY5ePFeUfNcRpUlMpiXZeHUcugA4kBgeZbdvsRxUS8YfW9ti7tpTBoKxdo9QxHOf/rYGbqbgp3tksyFgZ/CEwt51of+Gsyxa3ejZhHFwuLcesD6nUaTtR3snyCFLfuZ4+QDHWoBDQRsvcBJO/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763460384; c=relaxed/simple; bh=KY2l8PHq7RVG3qLF9LgOeU40q+GxktV7lIxlZnv2EpQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DNjl8Gfth6y8yZ88AdU0vNe7dOAkUQM88X0LXj2UCwTvdUihrkK1WwtzA/cbCfFj6nMHfXsWCAmYZFV4tKbA27eoGhUiguKT4V68UjDa7PS8BBAvU8jO0H5Akr5KW3CwqRWfVUrQ9Z60iMAh10ikcv3dS7/XeIz6G9yue6MH/QI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wn2itwLW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d11MDPHd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wn2itwLW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d11MDPHd" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AI6fSbn2272085 for ; Tue, 18 Nov 2025 10:06:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UzBTwNhUFUJYg6NGu4k4BlSP3SJfK6K5/WiEomAXFhw=; b=Wn2itwLWzwzBHJUx hU1coe7jrMwfno1O3pdFKk+jf2bovfTvtgaa4cqpiIrlYuOnk9cZnZxh3D1KuwNC gCR8mOGSOnojaB2PMpL6/TP/kLPqqdhIIzOehzN2me4pfS773LC8z+YhH3BRW6ID ZvwGex3pDl0+7EdQGauT1qKFR/AwhN5W+fzItwy3Cxw3DSZ/Hgj9S0TvMA+kOX2M 3g4DzD9xTbx6/wgFycYcIshen6VJD2YyUO3Ci0K0EX5qsHUVN+memHYgu3PWAewp tM6t2Fa02D9DpcMV1g7F7RlejCK0rinAqrxsSV1OZgb9j/NyL05zjoN2wCh4Md10 CSH+hw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4agkrmgm1r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 18 Nov 2025 10:06:21 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4edaa289e0dso25902651cf.3 for ; Tue, 18 Nov 2025 02:06:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763460381; x=1764065181; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UzBTwNhUFUJYg6NGu4k4BlSP3SJfK6K5/WiEomAXFhw=; b=d11MDPHdgGi6p2lfEW/+EOty8D2rANvYCKz/QwBsjy/zUfvZbTZlCxVZC1+CFnFkeM U1eZ9Q0qod6NN5c5mTNvsLfMkkummVD3B4Y56tePaNDXa8SRETAlPnvcQExt8bjG9936 Xg6fIj4cApRadM9w4+GYHAn+0n595MbDlUXIZkgEiFi56gNfthwgYeOJUWlB8ePoJIZd yne88E6UW2LMRXDwitx5MSfyvSJeYKOg4seqcC16cuATA1yyQwcc5BZqpm/+XHZR4uDL 68VZi6sARkVE6rn3AQmvxVDpwIifGNpxp84MBUQlp+9DvrVPdjMa34X68eHBCupBxPOo femA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763460381; x=1764065181; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UzBTwNhUFUJYg6NGu4k4BlSP3SJfK6K5/WiEomAXFhw=; b=j8L8qjX57tiBO5flDbXYM6I3OkjbWq0mmz8oKAv/4tEAcTqKkhVoXwPwLCjPreabWN vMyKqw5dd8GND7YbgDeVk3tbmfI81135iSw4TWM4n5TlNkQslNky+s7DthDmIuDCYsJB 8YOe7k0wt/sHjz4ho5rvY8ddFp2CX2T0wpIXwtHMBAKN1ztIYc8wShA8heyKzI9Pkovz mP7pEKcDSC0O4J3HIdhJ4cBuoSyyuvZ0pLNdq8n5yn2VZ/K9C7y0Xi8rzVnwUVlQUAas B64c9pu6wcuQAjnUeZq/59aeMqNfQx3k9noCxH+eanoHZ7qnz8nOF00tj8yFFRcT+IPj D58g== X-Forwarded-Encrypted: i=1; AJvYcCWxPogiRLZpjxBhiHCDiam8GAgS0gB0aZHe8YrHnila8fN4ZucVjBNo5uOnTkNTbZDwjcR2/npJjK/yD80=@vger.kernel.org X-Gm-Message-State: AOJu0YyxACaA79+zUq4KvnE3DzxJt65DNJatcVFD8blEYI9nhX8RKGb/ irf2OaxwRaRp2zZiOc6mXBWsvOy9gbSxnSgw/RGqkPFMtLrYdGcJysiy+xwYHs4JH6fyz4qUmf7 XrygFI8uTALVizamS8SgEpbMaEV9puDupg7KhzvblsHc+Rrd/bO093+mnZEFaxztHzH4= X-Gm-Gg: ASbGncvRiD7AqQkNHMpAoFIyO8TXU/mKildUbdAcD9rZ7+iYaxoYbjyNdRxe78SyBhM YjsJ9Eg9KOul4bBClvl9yyoYVeBB6yOq94Zz9Nb6xd+0IZ0e5eMxLpY/UjfUERwKg2sAUL0KxlX Vi9C2x9I16kwc5R8qVX6+G5bMXK4cN4upUoUaqLCEMbBv8R2EkX6RFyJVi3gdvQa0x3rRgvLUUc qM0raCg4QmLIKx5ahPXETBoXAvs0KuDkNKCDwF5ihaAwXDUvdk+t1xppcZr7OzDzh1k9bQNSrRa QABt+pDOQfX3zuDJ6DIeRYLq6ijpI6jwcU+rOGyshrXlZOUyN5cCLckHqQisfMCMQ4F1fmgz3Wn 5NYVfgtD+nrAMSP53XWVE2GGSSIpIOnvE52z0Ueo4ZTO5WXXnl3xywZtcUPXPKTL+Oxg= X-Received: by 2002:a05:622a:5c8:b0:4ee:87e:dedf with SMTP id d75a77b69052e-4ee317b4682mr20705101cf.8.1763460380771; Tue, 18 Nov 2025 02:06:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEnOq/xkhybJYoebHJv4d6wLh3+wQrarETtemCNL/T2oYMB4/PkghvSjrNm52XXxeRJf+cyxQ== X-Received: by 2002:a05:622a:5c8:b0:4ee:87e:dedf with SMTP id d75a77b69052e-4ee317b4682mr20704691cf.8.1763460380242; Tue, 18 Nov 2025 02:06:20 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b73785d0e04sm932538166b.47.2025.11.18.02.06.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 02:06:19 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 11:06:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Add CAMSS support for SM6350 To: Bryan O'Donoghue , Luca Weiss , Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <3ph8XeidoxkUIsK7qiOH29pde94sdwa3ReWKVVrPabgS5enIAmwVAC5plyFnBMJGKQBnxFB6df6j69OMFIeavw==@protonmail.internalid> <20251114-sm6350-camss-v2-0-d1ff67da33b6@fairphone.com> <17e7ebc9-3b88-4334-b87d-1bce6d5bb120@linaro.org> <893b97ad-7d2b-4408-bab5-2cd63fdaa33b@oss.qualcomm.com> <28f33d3a-6866-4bdb-a1e5-d193dcb7d4d1@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <28f33d3a-6866-4bdb-a1e5-d193dcb7d4d1@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE4MDA4MCBTYWx0ZWRfXy1qR0T/yC8q4 yOxd1OOHG9JjAtLnbf6Dc2UEmhd+tVCs4MxO4cK9I5WxM6lX3UxY6a+tELK0olcw4WPSd1XukMi ozgzcf62h3gECaJLmpMxupg5oxm7lrxjpCpEktOON45qh+lImfoajY5e8O6o5Hfz+wwi+GCaIdi XVnif8tq+7zD3tICrUN83tDDA+dghNMFPtPYEPDVn7XHmgQTTAVF53vqQYedq2of+edAK1ewkKG B3+6zkq+F1YD2Q01g8TSqjmCU6ptdUD9JEsBRUDEY2msLzvIFozoC81l+VJZWiFBvGoq1CMv8FQ MyEYnUpvv8e5cNcmNHs1R5VjrBsXuKzpPWqpPyjzvZMNw+nhj3pcQcj5g/++i7Z4oj06rfjRhAe utnlBsx/D4KkeY32PGFfxWFEDpnHvQ== X-Proofpoint-ORIG-GUID: q4hjpuiPbxAEMJOZA1mglXjujVicJDE_ X-Proofpoint-GUID: q4hjpuiPbxAEMJOZA1mglXjujVicJDE_ X-Authority-Analysis: v=2.4 cv=JfWxbEKV c=1 sm=1 tr=0 ts=691c451d cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=NEAV23lmAAAA:8 a=Gbw9aFdXAAAA:8 a=FLGiUj2T8VF-baS2uQUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 a=9vIz8raoGPyDa4jBFAYH:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-17_04,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 suspectscore=0 adultscore=0 spamscore=0 impostorscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511180080 On 11/18/25 10:33 AM, Bryan O'Donoghue wrote: > On 17/11/2025 12:53, Konrad Dybcio wrote: >> On 11/16/25 3:30 PM, Bryan O'Donoghue wrote: >>> On 14/11/2025 15:59, Luca Weiss wrote: >>>> On Fri Nov 14, 2025 at 4:51 PM CET, Bryan O'Donoghue wrote: >>>>> On 14/11/2025 11:15, Luca Weiss wrote: >>>>>> Add bindings, driver and dts to support the Camera Subsystem on the >>>>>> SM6350 SoC. >>>>>> >>>>>> These patches were tested on a Fairphone 4 smartphone with WIP sensor >>>>>> drivers (Sony IMX576 and IMX582), the camera pipeline works properly as >>>>>> far as I can tell. >>>>>> >>>>>> Though when stopping the camera stream, the following clock warning >>>>>> appears in dmesg. But it does not interfere with any functionality, >>>>>> starting and stopping the stream works and debugcc is showing 426.4 MHz >>>>>> while the clock is on, and 'off' while it's off. >>>>>> >>>>>> Any suggestion how to fix this, is appreciated. >>>>>> >>>>>> [ 5738.590980] ------------[ cut here ]------------ >>>>>> [ 5738.591009] gcc_camera_axi_clk status stuck at 'on' >>>>>> [ 5738.591049] WARNING: CPU: 0 PID: 6918 at drivers/clk/qcom/clk-branch.c:87 clk_branch_toggle+0x170/0x190 >>>>> >>>>> Do you have a full and complete kernel tree we could look at here ? >>>> >>>> Sure, this branch has everything in: >>>> >>>> https://github.com/sm6350-mainline/linux/tree/sm6350-6.17.y/ >>>> >>>> For further refence, at least two other people have tested this branch >>>> in postmarketOS, nothing particularly exciting to report from there, >>>> apart from that the sdm-skin-thermal thermal zone (thermistor right next >>>> to SoC) is currently configured with 55 degC as critical trip, which is >>>> quickly achieved when starting a video recording, but that's not really >>>> an issue with camss, but will need some tweaking regardless. >>>> >>>> https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/7281 >>> >>> diff --git a/drivers/clk/qcom/gcc-sm6350.c b/drivers/clk/qcom/gcc-sm6350.c >>> index a4d6dff9d0f7f..229629ef82809 100644 >>> --- a/drivers/clk/qcom/gcc-sm6350.c >>> +++ b/drivers/clk/qcom/gcc-sm6350.c >>> @@ -908,9 +908,7 @@ static struct clk_branch gcc_camera_ahb_clk = { >>> >>>   static struct clk_branch gcc_camera_axi_clk = { >>>          .halt_reg = 0x17018, >>> -       .halt_check = BRANCH_HALT, >>> -       .hwcg_reg = 0x17018, >>> -       .hwcg_bit = 1, >> >> No reason to drop the hwcg description >> >>> +       .halt_check = BRANCH_VOTED, >> >> It'd be useful to explain why we should ignore the hw feedback in this case >> >>>          .clkr = { >>>                  .enable_reg = 0x17018, >>>                  .enable_mask = BIT(0), >> >> Konrad > > vfe170 is what we have on sdm845 > > So I'm just asking Luca to try the sdm845 method of waggling this clock since what we have doesn't work. It's of course going to work because this way you're not calling the code that throws this error I was curious whether you know the actual reason why this is being done in some other GCC drivers Konrad