mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Chao Yu <chao@kernel.org>, xiang@kernel.org
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Yue Hu <zbestahu@gmail.com>,
	Jeffle Xu <jefflexu@linux.alibaba.com>,
	Sandeep Dhavale <dhavale@google.com>,
	Chunhai Guo <guochunhai@vivo.com>,
	Hongbo Li <lihongbo22@huawei.com>,
	Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] erofs: introduce nolargefolio mount option
Date: Tue, 10 Mar 2026 15:02:24 +0800	[thread overview]
Message-ID: <a15eeac5-8035-4ac5-93b5-5c71f3ce7105@linux.alibaba.com> (raw)
In-Reply-To: <dc645bd1-2881-4472-8918-0eada3786ab3@kernel.org>



On 2026/3/10 14:43, Chao Yu wrote:
> Xiang,
> 
> On 3/9/26 11:03, Gao Xiang wrote:
>> Hi Chao,
>>
>> (+cc -fsdevel, willy, Jan kara)
>>
>> On 2026/3/9 10:30, Chao Yu wrote:
>>> This patch introduces a new mount option 'nolargefolio' for EROFS.
>>> When this option is specified, large folio will be disabled by
>>> default for all inodes, this option can be used for environments
>>> where large folio resources are limited, it's necessary to only
>>> let specified user to allocate large folios on demand.
>>
>> For this kind of options, I think more real backgrounds
>> about avoiding high-order allocations are needed in the
>> commit message (at least for later reference) also like
>> what I observed in:
>> https://android-review.googlesource.com/c/kernel/common/+/3877981
> 
> Basically, the background is about contention scenario on large folio allocation,
> it's among multiple users including EROFS in Android-system, as it's related to
> internal scene of product, so I can not provide more details now, I'm sorry
> about that, but I'm glad to discuss based on the background and pain point once
> if I can share more, let's see. :)

Understood, but I think it's hard to justify an upstream
solution without a public load for discussion.  Anyway,
I can imagine some real workloads which large folios could
cause unnecessary pressure since I once worked for Android,
but I think others need an explicit one anyway to justify
this.

As Matthew and Jan mentioned, it's hard to add a per-fs
knob like this.  If it's Android-specific and no possible
public infos, I suggest leaving the changes Android
downstream for now, until the workloads can be made public.

Thanks,
Gao Xiang

  reply	other threads:[~2026-03-10  7:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09  2:30 Chao Yu
2026-03-09  3:01 ` Gao Xiang
2026-03-09  3:03 ` Gao Xiang
2026-03-09 13:03   ` Matthew Wilcox
2026-03-09 13:19     ` Jan Kara
2026-03-10  6:43   ` Chao Yu
2026-03-10  7:02     ` Gao Xiang [this message]
2026-03-10  7:13       ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a15eeac5-8035-4ac5-93b5-5c71f3ce7105@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=chao@kernel.org \
    --cc=dhavale@google.com \
    --cc=guochunhai@vivo.com \
    --cc=jack@suse.cz \
    --cc=jefflexu@linux.alibaba.com \
    --cc=lihongbo22@huawei.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    --cc=xiang@kernel.org \
    --cc=zbestahu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®