From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: darcagn@protonmail.com, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the ACPI global lock
Date: Sun, 27 Mar 2022 11:04:15 -0700 [thread overview]
Message-ID: <a1607f0d-9d6c-fb55-d0d2-b57e4fdfda23@roeck-us.net> (raw)
In-Reply-To: <CAB95QASpZTz4eMger46WEa9xWJNmARShBUNb7edJA1eij3KBwA@mail.gmail.com>
On 3/27/22 09:21, Eugene Shalygin wrote:
> On Sun, 27 Mar 2022 at 14:15, Eugene Shalygin <eugene.shalygin@gmail.com> wrote:
>> + /* number of board EC sensors */
>> + u8 nr_sensors;
>
> Re-added by mistake, will be fixed in the next patch version.
>
>> + if (ACPI_FAILURE(status)) {
>> + dev_err(dev,
>> + "Failed to get hardware access guard AML mutex"
>> + "'%s': error %d",
>> + mutex_path, status);
>
> Can't choose between various options to fix this broken string
> literal. Would be thankful, Günter, for a suggestion.
>
What is the problem other than that the string is split across
multiple lines ? That can easily be fixed by not splitting it,
so you'll have to be more specific.
Guenter
next prev parent reply other threads:[~2022-03-27 18:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 12:14 [PATCH 0/4] asus-ec-sensors: add support for board families Eugene Shalygin
2022-03-27 12:14 ` [PATCH 1/4] hwmon: (asus-ec-sensors) introduce ec_board_info struct for board data Eugene Shalygin
2022-03-29 13:44 ` Guenter Roeck
2022-03-29 19:22 ` Eugene Shalygin
2022-03-29 20:26 ` Guenter Roeck
2022-03-30 7:51 ` Eugene Shalygin
2022-03-30 14:09 ` Guenter Roeck
2022-03-27 12:14 ` [PATCH 2/4] hwmon: (asus-ec-sensors) implement locking via the ACPI global lock Eugene Shalygin
2022-03-27 16:21 ` Eugene Shalygin
2022-03-27 18:04 ` Guenter Roeck [this message]
2022-03-27 18:51 ` Eugene Shalygin
2022-03-27 23:25 ` Guenter Roeck
2022-03-28 14:44 ` Eugene Shalygin
2022-03-28 15:50 ` Nathan Chancellor
2022-03-29 11:36 ` Eugene Shalygin
2022-03-29 21:23 ` Guenter Roeck
2022-03-29 22:11 ` Eugene Shalygin
2022-03-29 23:37 ` Guenter Roeck
2022-03-30 7:36 ` Eugene Shalygin
2022-03-27 12:14 ` [PATCH 3/4] hwmon: (asus-ec-sensors) add support for board families Eugene Shalygin
2022-03-27 12:14 ` [PATCH 4/4] hwmon: (asus-ec-sensors) add PRIME X470-PRO board Eugene Shalygin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1607f0d-9d6c-fb55-d0d2-b57e4fdfda23@roeck-us.net \
--to=linux@roeck-us.net \
--cc=darcagn@protonmail.com \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®